All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Alexander Shiyan <shc_work@mail.ru>,
	Kukjin Kim <kgene.kim@samsung.com>,
	Tomasz Figa <t.figa@samsung.com>,
	Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Alexandre Courbot <gnurou@gmail.com>
Subject: Re: [PATCH] gpio: samsung: Add missing "break" statement
Date: Thu, 27 Mar 2014 10:11:04 +0100	[thread overview]
Message-ID: <CACRpkdZAWKqCiK_JXqbOKajivUZZiu3GSPVo3MKod1YWhkF89w@mail.gmail.com> (raw)
In-Reply-To: <1395477322-19951-1-git-send-email-shc_work@mail.ru>

On Sat, Mar 22, 2014 at 9:35 AM, Alexander Shiyan <shc_work@mail.ru> wrote:

> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
> ---
>  drivers/gpio/gpio-samsung.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpio/gpio-samsung.c b/drivers/gpio/gpio-samsung.c
> index a85e00b..07105ee 100644
> --- a/drivers/gpio/gpio-samsung.c
> +++ b/drivers/gpio/gpio-samsung.c
> @@ -379,6 +379,7 @@ static int s5p64x0_gpio_setcfg_rbank(struct samsung_gpio_chip *chip,
>         case 6:
>                 shift = ((off + 1) & 7) * 4;
>                 reg -= 4;
> +               break;
>         default:
>                 shift = ((off + 1) & 7) * 4;
>                 break;

Obviously no semantic effect so patch applied as it adds code
readability.

But I'm wondering if default should not be doing reg -= 4; as
well?

Yours,
Linus Walleij

      reply	other threads:[~2014-03-27  9:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-22  8:35 [PATCH] gpio: samsung: Add missing "break" statement Alexander Shiyan
2014-03-27  9:11 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZAWKqCiK_JXqbOKajivUZZiu3GSPVo3MKod1YWhkF89w@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=gnurou@gmail.com \
    --cc=kgene.kim@samsung.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=s.nawrocki@samsung.com \
    --cc=shc_work@mail.ru \
    --cc=t.figa@samsung.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.