From: Linus Walleij <linus.walleij@linaro.org>
To: Biju Das <biju.das.jz@bp.renesas.com>,
Drew Fustini <dfustini@baylibre.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "Rob Herring" <robh+dt@kernel.org>,
"Krzysztof Kozlowski" <krzysztof.kozlowski+dt@linaro.org>,
"Geert Uytterhoeven" <geert+renesas@glider.be>,
"Thierry Reding" <thierry.reding@gmail.com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org,
devicetree@vger.kernel.org,
"Chris Paterson" <Chris.Paterson2@renesas.com>,
"Biju Das" <biju.das@bp.renesas.com>,
"Prabhakar Mahadev Lad" <prabhakar.mahadev-lad.rj@bp.renesas.com>
Subject: Re: [PATCH v5 0/9] Add RZ/G2L POEG support
Date: Thu, 29 Dec 2022 02:19:37 +0100 [thread overview]
Message-ID: <CACRpkdZCEvpLAWvH7pCLH7KwbDMzz0EN+4HbxVGfFPi_C1b8+g@mail.gmail.com> (raw)
In-Reply-To: <20221215213206.56666-1-biju.das.jz@bp.renesas.com>
On Thu, Dec 15, 2022 at 10:32 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> This patch series add support for controlling output disable function using sysfs.
What's wrong with using the debugfs approach Drew implemented in
commit 6199f6becc869d30ca9394ca0f7a484bf9d598eb
"pinctrl: pinmux: Add pinmux-select debugfs file"
?
Something driver specific seems like a bit of a hack, does it not?
If this should go into sysfs we should probably create something
generic, such as a list of stuff to be exported as sysfs switches.
It generally also looks really dangerous, which is another reason
for keeping it in debugfs. It's the big hammer to hurt yourself with,
more or less.
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-12-29 1:17 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-15 21:31 [PATCH v5 0/9] Add RZ/G2L POEG support Biju Das
2022-12-15 21:31 ` [PATCH v5 1/9] dt-bindings: pinctrl: renesas: Add RZ/G2L POEG binding Biju Das
2022-12-29 1:20 ` Linus Walleij
2022-12-15 21:31 ` [PATCH v5 2/9] drivers: pinctrl: renesas: Add RZ/G2L POEG driver support Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 3/9] pwm: rzg2l-gpt: Add support for output disable request from gpt Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 4/9] pinctrl: renesas: rzg2l-poeg: Add support for GPT Output-Disable Request Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 5/9] pwm: rzg2l-gpt: Add support for output disable when both output low Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 6/9] pinctrl: renesas: rzg2l-poeg: output-disable request from GPT when both outputs are low Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 7/9] pwm: rzg2l-gpt: Add support for output disable on dead time error Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 8/9] pinctrl: renesas: rzg2l-poeg: output-disable request from GPT " Biju Das
2022-12-15 21:32 ` [DO NOT APPLY PATCH v5 9/9] tools/poeg: Add test app for poeg Biju Das
2022-12-29 1:19 ` Linus Walleij [this message]
2023-01-03 9:01 ` [PATCH v5 0/9] Add RZ/G2L POEG support Geert Uytterhoeven
2023-01-03 9:03 ` Geert Uytterhoeven
2023-01-09 13:16 ` Linus Walleij
2023-01-09 13:41 ` Geert Uytterhoeven
2023-01-09 14:00 ` Andy Shevchenko
2023-01-09 14:03 ` Andy Shevchenko
2023-01-10 8:09 ` Linus Walleij
2023-01-10 9:33 ` Drew Fustini
2023-01-09 15:10 ` Biju Das
2023-01-10 8:15 ` Linus Walleij
2023-01-10 9:09 ` Biju Das
2023-03-03 7:52 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkdZCEvpLAWvH7pCLH7KwbDMzz0EN+4HbxVGfFPi_C1b8+g@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Chris.Paterson2@renesas.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=biju.das@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=dfustini@baylibre.com \
--cc=geert+renesas@glider.be \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=robh+dt@kernel.org \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.