From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755837AbeDZMYc (ORCPT ); Thu, 26 Apr 2018 08:24:32 -0400 Received: from mail-it0-f67.google.com ([209.85.214.67]:35416 "EHLO mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755511AbeDZMYa (ORCPT ); Thu, 26 Apr 2018 08:24:30 -0400 X-Google-Smtp-Source: AB8JxZpj7yOKUj+EEipgwiMgfUk/O8iTM79ldxc8tpjFuJ4f4nXwa9xUbgDj7rA9qMgdIPTCUoSSjO8dBPapd3O0YgA= MIME-Version: 1.0 In-Reply-To: <1523422726-7910-3-git-send-email-matheus@castello.eng.br> References: <1523422726-7910-1-git-send-email-matheus@castello.eng.br> <1523422726-7910-3-git-send-email-matheus@castello.eng.br> From: Linus Walleij Date: Thu, 26 Apr 2018 14:24:29 +0200 Message-ID: Subject: Re: [PATCH v5 2/3] pinctrl: bcm2835: Add support for generic pinctrl binding To: Matheus Castello , Stephen Warren Cc: Rob Herring , Stefan Wahren , Eric Anholt , Mark Rutland , Rob Herring , "linux-kernel@vger.kernel.org" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 11, 2018 at 6:58 AM, Matheus Castello wrote: > To keep driver up to date we add generic pinctrl binding support, which covers > the features used in this driver and has additional node properties that this > SoC has compatibility, so enabling future implementations of these properties > without the need to create new node properties in the device trees. > > The logic of this change maintain the old brcm legacy binding support in order > to keep the ABI stable. > > Signed-off-by: Matheus Castello Looking good, just need to address Stefan's comments. (I already merged patch 1 so you do not need to resend this.) The driver is kind of part of what Stefan and Eric maintains but it would be nice to get a nod from Stephen Warren as well as in my mind he is also maintainer for this. Please include him on subsequent postings as well. Yours, Linus Walleij