From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 680C4C2D0E4 for ; Tue, 24 Nov 2020 08:41:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 013BE2076E for ; Tue, 24 Nov 2020 08:41:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f0o9UbG9" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730652AbgKXIla (ORCPT ); Tue, 24 Nov 2020 03:41:30 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45358 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730537AbgKXIl3 (ORCPT ); Tue, 24 Nov 2020 03:41:29 -0500 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 891D9C0613CF for ; Tue, 24 Nov 2020 00:41:29 -0800 (PST) Received: by mail-lf1-x142.google.com with SMTP id d17so27689310lfq.10 for ; Tue, 24 Nov 2020 00:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sNwTVNPBk8PIyQSaRwIDJIv+OY57OQDUkBkRypcUFWg=; b=f0o9UbG9hmobiGVCxN59MBg5MaBa59ZM2Zg3Jm6BVg6Bo6tVJkh7REKf/yFLX32WSN 82fBss5g+Ox8BjRTin4YiJasXM2xvdxW0XFj8SElEU6A6QNw6HuuwOvH/8MKra3/WU/o hi/IC9ObwHeeQl/x2Bt8m8qFGEUUlxiLXGZUtcGdr5n8EZQqsv0LA5yU6CJPG9guscMN rQ1m2YoqOHuupByKqgaP2UVnSm0o7J1WSdZ4FA5vQPVB9t6qVo4XzxeRbEABWU0WDHpE AwesjAkKHFy1APO3zUNt8A4mAXjPck0opUOrCRyIP6dk9qtNTCqxqkSwbouog8ZnLJ6O x1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sNwTVNPBk8PIyQSaRwIDJIv+OY57OQDUkBkRypcUFWg=; b=eRaA1aWe99Mo92SNJ8wYkgFEsLMOx5grr/yDk8cFIR4E2re63tEgSun5nrqyQR/ztt vHjHU8U4hXqUqNAYQISXxFP78KA6dk3+KlRMmvMqiYqgapM2/VQgfFyjTUplBGCgTIpY fSSBiNAouF7b3psORxFfYp9U3myPc4zPfeC83l08KifRuNBNrAY7KPc/tNIPYaiNffgH aMN7wD8OSzU/zbBwnn9GTYZUivz4K+CGhysaErVis1+XAcsloqM8/OOumQpmJIzURxAt +uvxEkKzgQOocdGqAc0z+NsQ5F4xmwC2xi9JFodkYaiNefUdvsj8H3VrPvq/rD2Rkzxk 5lng== X-Gm-Message-State: AOAM5315e9dC0AG9lGfX1BKpJ8thFZ8IN8DmujlZI2PViRJ81mMbFhv1 Gb/Lcrqbirk/1E/+T+JJvqSVAT6DAFXsWqsivvg8rg== X-Google-Smtp-Source: ABdhPJxegvXTPaufGbRnugZ49YnXR7JJuw3F0XnFokWZ/jjLdCPnwW/VrQ9FokWeWM4tulGN96EjM8LA2b+J0aAoMm0= X-Received: by 2002:a19:8686:: with SMTP id i128mr1242866lfd.333.1606207288068; Tue, 24 Nov 2020 00:41:28 -0800 (PST) MIME-Version: 1.0 References: <470ebae22fc5434ad5409c4f6e29255467b3cef6.1604988979.git.frank@allwinnertech.com> In-Reply-To: <470ebae22fc5434ad5409c4f6e29255467b3cef6.1604988979.git.frank@allwinnertech.com> From: Linus Walleij Date: Tue, 24 Nov 2020 09:41:17 +0100 Message-ID: Subject: Re: [RESEND PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON To: Frank Lee Cc: Frank Lee , "open list:GPIO SUBSYSTEM" , Linux ARM , "linux-kernel@vger.kernel.org" , Maxime Ripard , Chen-Yu Tsai Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Nov 10, 2020 at 7:24 AM Frank Lee wrote: > From: Yangtao Li > > The interrupt descriptor cannot be found in the interrupt processing > function, and this situation cannot happen when the system is running > normally. It doesn't seem right to return directly to the status of not > handling gic. In this case, it must be a bug, let's mark it with > WARN_ON. > > Signed-off-by: Yangtao Li Patch applied. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 11F3BC2D0E4 for ; Tue, 24 Nov 2020 08:41:55 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 71D792075A for ; Tue, 24 Nov 2020 08:41:54 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="eB3Ymald"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="f0o9UbG9" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 71D792075A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YNizRBt7PGRhViDHFq+8nR1Qe3zS3o3M+vGj/GHNrJc=; b=eB3YmaldaJeFEhYP4MsO1dhfH ze54IV+2BzJTYYhz/YCQAn7FS5AHVWuc1K7Sg8J3xPTbm+FTvBEUJ8s3F1ubQrLnlsfUFxPgNqGKi rsI37z5aUmWtGsEnwdTLEMWiZrieLowNw35zFk6gQmhw8635HpXNV60CgPDEsAJMvZ6Csrs6SQYEt UMRZgD5hIYJtqmMTCBQn7s6XJwbNQbJJY1cN1FebR0HJjF+F/u1ReWmt8y4t7PZy34wBpdot4Eklt gqZ7V3wdLYWhW8M2lG0a9MXIBHYa1dlziGGeQkQvtmh57jdz/R63ZjdqrD6FPMiD/y1tdVSMH8EOF 486anJxSA==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTtE-00058A-Eg; Tue, 24 Nov 2020 08:41:32 +0000 Received: from mail-lf1-x143.google.com ([2a00:1450:4864:20::143]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khTtB-00057e-GJ for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 08:41:30 +0000 Received: by mail-lf1-x143.google.com with SMTP id u19so27736204lfr.7 for ; Tue, 24 Nov 2020 00:41:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sNwTVNPBk8PIyQSaRwIDJIv+OY57OQDUkBkRypcUFWg=; b=f0o9UbG9hmobiGVCxN59MBg5MaBa59ZM2Zg3Jm6BVg6Bo6tVJkh7REKf/yFLX32WSN 82fBss5g+Ox8BjRTin4YiJasXM2xvdxW0XFj8SElEU6A6QNw6HuuwOvH/8MKra3/WU/o hi/IC9ObwHeeQl/x2Bt8m8qFGEUUlxiLXGZUtcGdr5n8EZQqsv0LA5yU6CJPG9guscMN rQ1m2YoqOHuupByKqgaP2UVnSm0o7J1WSdZ4FA5vQPVB9t6qVo4XzxeRbEABWU0WDHpE AwesjAkKHFy1APO3zUNt8A4mAXjPck0opUOrCRyIP6dk9qtNTCqxqkSwbouog8ZnLJ6O x1Dg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sNwTVNPBk8PIyQSaRwIDJIv+OY57OQDUkBkRypcUFWg=; b=jlStGjGeWaJDGr5Fcw2JoUX+DmGeeD/Ujx5LVSeLHgMZ/hlQSzfokcLNsFYKQ68yUW wGpaILADTXBa+NDA2IWdZuAkBkkMP3e23SOYgyBWtOajwuLITFB94DMRZIjN2HmGhv/e TWFX3f31znhdG3OrjOyuF6s8/Uy55pmJyI44ZPoUVZE2krNzAF2th0ms6/OYYnW/E4r0 NHbKOOE6rWFdRnNV7I1qgPUmrqS+RNpYjez4nh+n/geiPOyjTRPQrn+vOdEhT8xy1Pd8 jYP8BDRuStgXwP35/EsNag/NzyxbNP9ZHtnL4IU8n79rOPgd+0RP1o+FYTNKmUOk8jO8 UWBQ== X-Gm-Message-State: AOAM530UCDwrh7EGKz9CiB7xiKGYnULQgpkpxps4UAMlOsw7X2R507CM gVpWqv4cbI8bfc6gFuyqI6XGD5iH6YUiqIJIDS/jSqSfgZ2OmQ== X-Google-Smtp-Source: ABdhPJxegvXTPaufGbRnugZ49YnXR7JJuw3F0XnFokWZ/jjLdCPnwW/VrQ9FokWeWM4tulGN96EjM8LA2b+J0aAoMm0= X-Received: by 2002:a19:8686:: with SMTP id i128mr1242866lfd.333.1606207288068; Tue, 24 Nov 2020 00:41:28 -0800 (PST) MIME-Version: 1.0 References: <470ebae22fc5434ad5409c4f6e29255467b3cef6.1604988979.git.frank@allwinnertech.com> In-Reply-To: <470ebae22fc5434ad5409c4f6e29255467b3cef6.1604988979.git.frank@allwinnertech.com> From: Linus Walleij Date: Tue, 24 Nov 2020 09:41:17 +0100 Message-ID: Subject: Re: [RESEND PATCH 02/19] pinctrl: sunxi: Mark the irq bank not found in sunxi_pinctrl_irq_handler() with WARN_ON To: Frank Lee X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201124_034129_547660_6CD233FC X-CRM114-Status: GOOD ( 12.05 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Frank Lee , "linux-kernel@vger.kernel.org" , Maxime Ripard , "open list:GPIO SUBSYSTEM" , Chen-Yu Tsai , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Nov 10, 2020 at 7:24 AM Frank Lee wrote: > From: Yangtao Li > > The interrupt descriptor cannot be found in the interrupt processing > function, and this situation cannot happen when the system is running > normally. It doesn't seem right to return directly to the status of not > handling gic. In this case, it must be a bug, let's mark it with > WARN_ON. > > Signed-off-by: Yangtao Li Patch applied. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel