From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D237EC433E0 for ; Wed, 12 Aug 2020 07:30:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AC275204EC for ; Wed, 12 Aug 2020 07:30:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zdy95b1k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726803AbgHLHac (ORCPT ); Wed, 12 Aug 2020 03:30:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38482 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726182AbgHLHab (ORCPT ); Wed, 12 Aug 2020 03:30:31 -0400 Received: from mail-lf1-x142.google.com (mail-lf1-x142.google.com [IPv6:2a00:1450:4864:20::142]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 65176C06174A for ; Wed, 12 Aug 2020 00:30:31 -0700 (PDT) Received: by mail-lf1-x142.google.com with SMTP id b11so617438lfe.10 for ; Wed, 12 Aug 2020 00:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5FdXAIZx+ZP41PS8ejWt0zp2dMev1+Pg53fxOJb49go=; b=zdy95b1kTPcTbrYCuGrt2C7Mi8xpkU0SHcP3cHovIvD8Rf8PcG/9Y4VLbg39S9gweq FxEP/lmv6XHHGIgWcfar5m/IGWRMciwaw2f62Xezz5t/KZZ1tU9gOdsRk2p+FOQ+vKUb 9P2pGawIOuIANgF0+HWyVLwfTgOpI31SsDgCWY0rjzD1XpQ6R2NmtxWpnDO3JGXpcUaw 2MXLfuQl5U7csaDC7/5zEvjZX+YywjdEWnPa+z7gF5q4zFjRxTGoJM4huW5c6humymcO r4BbIxlPHUQOk9R+nJdV4AAUKhqpeiHazJbNaf+Atp+blNAiOqI2RwVZ8M47yqPt7YQy NT3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5FdXAIZx+ZP41PS8ejWt0zp2dMev1+Pg53fxOJb49go=; b=h/+XHIQuqASn40IvlGk/L6Upq+Kz0124TSCgJINJdCTy3FENZINvwtJpUC4C/9n4+2 dbaOWHYW1lFMNW9FNWqGNAgn6sRMvVrbBklWHlw8AKpvUtoTv27xTokSW+T/rbSYUvlD xL4+hJnrw/4zXNsd4VieE90liS6sPS6Gt2uLSpxKWbwcDs76o6BOl+P2g4r9Ps43tLz7 GfFg1s5H6N4oqSjvspvHc6aIuJ8XH28eGjIXRCZS6vePyb6OPTdz2VxTMidMvMp7pWpN LYUqdElnYlVkJ+vvKvciAvgeKbeY+5WvBS2fuMfUvs/tt76Pk4J4Jjp7Dipl6dm0VjND DoQg== X-Gm-Message-State: AOAM530p3JzUFalJIKWO+EGpJGE55lFCPPrmhwgwqvFCFUpVZS/yhNtg K2O/bLSEtcrgo2w0BMmGBLT5TokhuNk8jgi0RM5uLQ== X-Google-Smtp-Source: ABdhPJz4sufS9uL7t6Eocg+3nINh6YsIEewzxgjPWMWJmSeXpCf0IVIfT6TSWwDe2md+cFp4whCdIXttT1Jknix5buY= X-Received: by 2002:a19:cb53:: with SMTP id b80mr5027209lfg.77.1597217428378; Wed, 12 Aug 2020 00:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20200720203506.3883129-1-linus.walleij@linaro.org> <20200721112841.jxocq26yxhwy3gag@holly.lan> In-Reply-To: <20200721112841.jxocq26yxhwy3gag@holly.lan> From: Linus Walleij Date: Wed, 12 Aug 2020 09:30:17 +0200 Message-ID: Subject: Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings To: Daniel Thompson Cc: Lee Jones , Jingoo Han , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, Jul 21, 2020 at 1:28 PM Daniel Thompson wrote: > I'm a bit sceptical of having a max-brightness in the DT and a driver > defined lookup table in the driver itself. That doesn't make a whole lot > of sense to me since the maximum brightness here is basically relies on > knowing what scale the Linux driver has opted to implement in its tables. That's a good point. > I think there are two options here. > > 1. Throw away the brightness table in the driver and expose the hardware > steps directly (maybe using allowing properties such as > max-brightness = 24 if the top 8 values cannot be distinguished > visually). I think I will opt for this. It makes most sense given how we use the device tree to restrict maximum brightness, and that is definitely related to the hardware max brightness. Thanks Daniel! Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4ECBFC433DF for ; Wed, 12 Aug 2020 07:30:33 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 22D2E20771 for ; Wed, 12 Aug 2020 07:30:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="zdy95b1k" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 22D2E20771 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 576696E8BF; Wed, 12 Aug 2020 07:30:32 +0000 (UTC) Received: from mail-lf1-x144.google.com (mail-lf1-x144.google.com [IPv6:2a00:1450:4864:20::144]) by gabe.freedesktop.org (Postfix) with ESMTPS id 899AC6E8BF for ; Wed, 12 Aug 2020 07:30:31 +0000 (UTC) Received: by mail-lf1-x144.google.com with SMTP id m15so629915lfp.7 for ; Wed, 12 Aug 2020 00:30:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5FdXAIZx+ZP41PS8ejWt0zp2dMev1+Pg53fxOJb49go=; b=zdy95b1kTPcTbrYCuGrt2C7Mi8xpkU0SHcP3cHovIvD8Rf8PcG/9Y4VLbg39S9gweq FxEP/lmv6XHHGIgWcfar5m/IGWRMciwaw2f62Xezz5t/KZZ1tU9gOdsRk2p+FOQ+vKUb 9P2pGawIOuIANgF0+HWyVLwfTgOpI31SsDgCWY0rjzD1XpQ6R2NmtxWpnDO3JGXpcUaw 2MXLfuQl5U7csaDC7/5zEvjZX+YywjdEWnPa+z7gF5q4zFjRxTGoJM4huW5c6humymcO r4BbIxlPHUQOk9R+nJdV4AAUKhqpeiHazJbNaf+Atp+blNAiOqI2RwVZ8M47yqPt7YQy NT3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5FdXAIZx+ZP41PS8ejWt0zp2dMev1+Pg53fxOJb49go=; b=q039x4oUCmKyalKfcKowEy3DsRVvZ3E87d9aSSxRzr9WnHXqi6nC/o9GVFN8GLs1wd xv3huoHyL6Snyp9XGA1Z4Wc985uxJvYFh+NvsGDdjev6qzkjpyhSqAUL5g3JuXuNxVK3 U6rviYqK+hhXp0XmHLiWxiqogxbm1YoPcU1BLTr6LHn21Sw36q+5vMWaiDnnl7WowIF2 SudNhyVJ0amhK0RLJZ814KO0cJor26gkxS6W9jgF/Btbse6Xib3a50iaavj6tuyazra0 YAl0NGxkdNfBt+a7p2Phk09/I1THzPubKktBosJiNLNYWtZp8cO1CFDkWNHi+Du2Ls6S dI0g== X-Gm-Message-State: AOAM533F36OYpjuxJfoRlUSYYaPvJBiXzGXpJB23x478r+Mn/vCViU4o qieXOZe3IFQVPqB2fV1ik2Or4VpCgSvH0wlc95zn4Q== X-Google-Smtp-Source: ABdhPJz4sufS9uL7t6Eocg+3nINh6YsIEewzxgjPWMWJmSeXpCf0IVIfT6TSWwDe2md+cFp4whCdIXttT1Jknix5buY= X-Received: by 2002:a19:cb53:: with SMTP id b80mr5027209lfg.77.1597217428378; Wed, 12 Aug 2020 00:30:28 -0700 (PDT) MIME-Version: 1.0 References: <20200720203506.3883129-1-linus.walleij@linaro.org> <20200721112841.jxocq26yxhwy3gag@holly.lan> In-Reply-To: <20200721112841.jxocq26yxhwy3gag@holly.lan> From: Linus Walleij Date: Wed, 12 Aug 2020 09:30:17 +0200 Message-ID: Subject: Re: [PATCH 1/2 v1] dt-bindings: backlight: Add Kinetic KTD253 bindings To: Daniel Thompson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jingoo Han , Lee Jones , "open list:DRM PANEL DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Jul 21, 2020 at 1:28 PM Daniel Thompson wrote: > I'm a bit sceptical of having a max-brightness in the DT and a driver > defined lookup table in the driver itself. That doesn't make a whole lot > of sense to me since the maximum brightness here is basically relies on > knowing what scale the Linux driver has opted to implement in its tables. That's a good point. > I think there are two options here. > > 1. Throw away the brightness table in the driver and expose the hardware > steps directly (maybe using allowing properties such as > max-brightness = 24 if the top 8 values cannot be distinguished > visually). I think I will opt for this. It makes most sense given how we use the device tree to restrict maximum brightness, and that is definitely related to the hardware max brightness. Thanks Daniel! Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel