From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B0FAC433F5 for ; Tue, 4 Oct 2022 09:02:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230201AbiJDJCZ (ORCPT ); Tue, 4 Oct 2022 05:02:25 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43700 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229661AbiJDJCX (ORCPT ); Tue, 4 Oct 2022 05:02:23 -0400 Received: from mail-ej1-x630.google.com (mail-ej1-x630.google.com [IPv6:2a00:1450:4864:20::630]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D91742B603 for ; Tue, 4 Oct 2022 02:02:18 -0700 (PDT) Received: by mail-ej1-x630.google.com with SMTP id nb11so27428328ejc.5 for ; Tue, 04 Oct 2022 02:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=kOrG/KsOgzPslDjCA/2wVvVO8wIY+Cw63qRlS34Bc2Gp0ysABkZAdfwKG3GoOZ3Qov t4oapKrVCSblA5nYqcznfIMp6w4ItdU0n5J/SYR+0Hceg0Jqz/Q6SNrd3vhaaCFEqQdD zeNuwz5e8oIdedEly8BXGR4rPJLr85M/PVlA/PCGFIq+Ggxp+UmRpOxC53yYJetG5DYL Q+HgO/POXHyWYUav/27yx9hiPsg7rGyNS5edBzAQjt7AAACiph3U60WYVAvU393riZGy 0XVfHUXoDmykiCYSMMFso6leDg6qDMmNQAV3bd8hLOxObTYNZhQ4bCRzK59pirN9TatC 3v8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=zaMf7uUkYekzryYSQiyEoWu6hWfdHVFuHu+dlSaBYbyEvIB8bAqa02x48V2S/OHI+Y GIHDOIWCaSAZ3ogD+kEB4DgFOGz2qXG1A/4Lg5XXVvwbqWqRI6SQgeZgArpQ6D+SA8vf ZrUKHoBB34ZTAbuXxjSXCOX7Ilg1HrawxvAvKD2Vg1fupfsOtFbqgfmh+4VJSNKHumnd f7sBOda5rN+noic9+LmcIxuhdleasSJq3+mIU76dhgwl7FTolkvD3UXX8zkI9h5IhnP6 hPCLFRlqiaHCrPXf5+gVj3H9ZZyS17puF9CpbLj0I6jv/YMLFKv0krbkoif0P0CvgRzu 7uuQ== X-Gm-Message-State: ACrzQf0T3C9fIZ5E1mON2G4bAmxQ36PsX7sZM1HVrhRtvM+XH2wqYMP3 8jfu8Y/CqeYyAciXW4d1M4KbpCt+BIlydqpb0O5ytQ== X-Google-Smtp-Source: AMsMyM4xndojXaNMN2ex8pnWSc6yo524zQadaqbeACW6jhGMMrzwPKdUyNStMO3sE6xymDGbSG30wCrcXWZUR4MZZtg= X-Received: by 2002:a17:906:5d04:b0:77f:ca9f:33d1 with SMTP id g4-20020a1709065d0400b0077fca9f33d1mr19070022ejt.526.1664874137461; Tue, 04 Oct 2022 02:02:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Tue, 4 Oct 2022 11:02:06 +0200 Message-ID: Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API To: Dmitry Torokhov , Sascha Hauer Cc: Krzysztof Kozlowski , Rob Herring , Lee Jones , Daniel Thompson , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov wrote: > Properties describing GPIOs should be named as "-gpios" or > "-gpio", and that is what gpiod API expects, however the > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > note that the reset line is active low as that is also important to > gpiod API. > > Signed-off-by: Dmitry Torokhov I think the gods of Open Firmware will try to punish you for such incompatible changes. But I have long since renounced them. > Another option is to add another quirk into gpiolib-of.c, but we > may end up with a ton of them once we convert everything away from > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. We need to know if i.MX is shipping device trees stored in flash, or if they bundle it with the kernel. In the former case, you have to add quirks, in the latter case this patch is fine. Sascha, what does the Freescale maintainer say? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id F0A38C433F5 for ; Tue, 4 Oct 2022 09:02:23 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D814C10E3AA; Tue, 4 Oct 2022 09:02:21 +0000 (UTC) Received: from mail-ej1-x635.google.com (mail-ej1-x635.google.com [IPv6:2a00:1450:4864:20::635]) by gabe.freedesktop.org (Postfix) with ESMTPS id E92E310E3AA for ; Tue, 4 Oct 2022 09:02:18 +0000 (UTC) Received: by mail-ej1-x635.google.com with SMTP id bj12so27382001ejb.13 for ; Tue, 04 Oct 2022 02:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=kOrG/KsOgzPslDjCA/2wVvVO8wIY+Cw63qRlS34Bc2Gp0ysABkZAdfwKG3GoOZ3Qov t4oapKrVCSblA5nYqcznfIMp6w4ItdU0n5J/SYR+0Hceg0Jqz/Q6SNrd3vhaaCFEqQdD zeNuwz5e8oIdedEly8BXGR4rPJLr85M/PVlA/PCGFIq+Ggxp+UmRpOxC53yYJetG5DYL Q+HgO/POXHyWYUav/27yx9hiPsg7rGyNS5edBzAQjt7AAACiph3U60WYVAvU393riZGy 0XVfHUXoDmykiCYSMMFso6leDg6qDMmNQAV3bd8hLOxObTYNZhQ4bCRzK59pirN9TatC 3v8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=fg69EfqY2OTyjOnaM0VJBjZu19n9jqomSm11uDSaTCS/WCaKxGlnsIrq5OJmEvZKZL +6kMsR2+Qj/Rgs5YfXfrMrigrPzjH6UwJCL94xSh07aCMbvL6/S2bH7H0CulqsVXB1JV UNZ5UeSF0GyJA4s4ontqoUi6GDiNtwQDfEVEFil5Nlo7XEK+cFnmLmxlaoHw/TvxpJ9N jxOZUsm4ZuVUxV8o3MWs/p7tQ01sfICEor/3XXYnXBZzAa4ezdQr+5iDTm/KTDN2iU3B DMbAbzCHz9lOpDetpas1TEF+wlq9D0DUFkM4OLrql11x0wRdV3/fJS/HoIaXHxh4OJuY Hi2A== X-Gm-Message-State: ACrzQf0bc4FovImfwwhwyjn5ka6V9FjCsimbwqJEbVQsPQglSxDl+aFC JdI/feDyoSoZBYk9QF63x8aWFv6m++xhw/B0pYqpsQ== X-Google-Smtp-Source: AMsMyM4xndojXaNMN2ex8pnWSc6yo524zQadaqbeACW6jhGMMrzwPKdUyNStMO3sE6xymDGbSG30wCrcXWZUR4MZZtg= X-Received: by 2002:a17:906:5d04:b0:77f:ca9f:33d1 with SMTP id g4-20020a1709065d0400b0077fca9f33d1mr19070022ejt.526.1664874137461; Tue, 04 Oct 2022 02:02:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Tue, 4 Oct 2022 11:02:06 +0200 Message-ID: Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API To: Dmitry Torokhov , Sascha Hauer Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Daniel Thompson , Jingoo Han , Lee Jones , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Rob Herring , NXP Linux Team , Krzysztof Kozlowski , Shawn Guo , linux-arm-kernel@lists.infradead.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov wrote: > Properties describing GPIOs should be named as "-gpios" or > "-gpio", and that is what gpiod API expects, however the > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > note that the reset line is active low as that is also important to > gpiod API. > > Signed-off-by: Dmitry Torokhov I think the gods of Open Firmware will try to punish you for such incompatible changes. But I have long since renounced them. > Another option is to add another quirk into gpiolib-of.c, but we > may end up with a ton of them once we convert everything away from > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. We need to know if i.MX is shipping device trees stored in flash, or if they bundle it with the kernel. In the former case, you have to add quirks, in the latter case this patch is fine. Sascha, what does the Freescale maintainer say? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CC01FC433FE for ; Tue, 4 Oct 2022 09:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=9Zw+6Q5HeP37ZclSYKyXAoBQsMfq4Qky5+MhO9DVnfQ=; b=Yz5NCR+Up8iZ6V FgrRq06VtNxouvypV+yAmgNdgPdw9cbaXD2jOoQe5Ljo9oP4xoAq89jy5e31hCx3lSFatthJR+FMT 5bR+mDsnPtWnAOJrKK3TPlO8Q9uMiV5LuC9rEtVP6+iYPIV2xh/8YGXU6wppF890ReU+6saMS6kEr TNeroR2+YCesC5rq2kcyvossvMgzdBeDGNiU7VrAKCm7Vv59iF0AGZR5Fgg3dlT9t39aR1eCotaKt /CalZ8CYAcw+rCINIBggwAZEBo++FxBWo5pxk9fwaEYuCdY+MQH0OlnGEMIkWglU7fOwcMgcU2g4f FpQCaGv2otkTHPwDuK4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofdol-0093cq-Vg; Tue, 04 Oct 2022 09:02:24 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ofdog-0093cJ-SI for linux-arm-kernel@lists.infradead.org; Tue, 04 Oct 2022 09:02:22 +0000 Received: by mail-ej1-x633.google.com with SMTP id lt21so2145422ejb.0 for ; Tue, 04 Oct 2022 02:02:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=kOrG/KsOgzPslDjCA/2wVvVO8wIY+Cw63qRlS34Bc2Gp0ysABkZAdfwKG3GoOZ3Qov t4oapKrVCSblA5nYqcznfIMp6w4ItdU0n5J/SYR+0Hceg0Jqz/Q6SNrd3vhaaCFEqQdD zeNuwz5e8oIdedEly8BXGR4rPJLr85M/PVlA/PCGFIq+Ggxp+UmRpOxC53yYJetG5DYL Q+HgO/POXHyWYUav/27yx9hiPsg7rGyNS5edBzAQjt7AAACiph3U60WYVAvU393riZGy 0XVfHUXoDmykiCYSMMFso6leDg6qDMmNQAV3bd8hLOxObTYNZhQ4bCRzK59pirN9TatC 3v8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=MaE+VYQSDiY92kjGX4h2jSkOyA7XFQBMOSLljPLW3Fs=; b=o3EhhNLOY2GcqGm5amyG5wwiX0PLnDvpDe7yBdLsNedzjHmztD8SQRubxM8T0mU9py oEP4KtI3p1n8w7vQcKe6S/LcmRM2BKOXM5RAXFJVpzIi6kmXwmhXysbAz2SN8hgdS7TB yxCh2PDItmFrw13mJnKDN9eSeP0YomR9aPY3mmxiPzbYG7D6m0SVZi89PWjzOxEZ/zeY Ty35gwS5sS2dNyqxBMxHgiBH1OM6fcvhMLYHHKhUKImVRzwTKTgeVjlSdtFUSdBJ6J3V dPIur3Tlpk5M9PGRpcTH3cum9uSEJmJGX80B1ckfyIBVxgtNNoy/y7UhjFpt9Jy01x3N CfoA== X-Gm-Message-State: ACrzQf14P+Vxn3PesMVooP++TTCQYajEQYi0cI7i0941AHPbcLiAnO8I BqI+xSW5rjPjntltwpFE19zrpuLgFlWy3Oc6TpiaMgcq5fY= X-Google-Smtp-Source: AMsMyM4xndojXaNMN2ex8pnWSc6yo524zQadaqbeACW6jhGMMrzwPKdUyNStMO3sE6xymDGbSG30wCrcXWZUR4MZZtg= X-Received: by 2002:a17:906:5d04:b0:77f:ca9f:33d1 with SMTP id g4-20020a1709065d0400b0077fca9f33d1mr19070022ejt.526.1664874137461; Tue, 04 Oct 2022 02:02:17 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Tue, 4 Oct 2022 11:02:06 +0200 Message-ID: Subject: Re: [RFC/PATCH] backlight: hx8357: prepare to conversion to gpiod API To: Dmitry Torokhov , Sascha Hauer Cc: Krzysztof Kozlowski , Rob Herring , Lee Jones , Daniel Thompson , Jingoo Han , Shawn Guo , Fabio Estevam , NXP Linux Team , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221004_020218_958506_6920F5FA X-CRM114-Status: GOOD ( 14.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Sep 28, 2022 at 12:32 AM Dmitry Torokhov wrote: > Properties describing GPIOs should be named as "-gpios" or > "-gpio", and that is what gpiod API expects, however the > driver uses non-standard "gpios-reset" name. Let's adjust this, and also > note that the reset line is active low as that is also important to > gpiod API. > > Signed-off-by: Dmitry Torokhov I think the gods of Open Firmware will try to punish you for such incompatible changes. But I have long since renounced them. > Another option is to add another quirk into gpiolib-of.c, but we > may end up with a ton of them once we convert everything away from > of_get_named_gpio() to gpiod API, so I'd prefer not doing that. We need to know if i.MX is shipping device trees stored in flash, or if they bundle it with the kernel. In the former case, you have to add quirks, in the latter case this patch is fine. Sascha, what does the Freescale maintainer say? Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel