From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] spi: bitbang: convert to using core message queue Date: Mon, 19 Mar 2012 00:33:14 +0100 Message-ID: References: <20120315092923.951203E04FD@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Cc: spi-devel-general-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Magnus Damm To: Guennadi Liakhovetski Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: spi-devel-general-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: linux-spi.vger.kernel.org On Sat, Mar 17, 2012 at 12:39 AM, Guennadi Liakhovetski wrote: > The SPI subsystem core now manages message queues internally. Remove the > local message queue implementation from the spi-bitbang driver and > migrate to the common one. > > Signed-off-by: Guennadi Liakhovetski This is great stuff! Acked-by: Linus Walleij (Since I've never really used the bitbang driver I wouldn't trust me to do any deeper review.) Quick thought: > +static int spi_bitbang_dummy_prepare(struct spi_master *master) > +{ > + =A0 =A0 =A0 return 0; (...) > + =A0 =A0 =A0 master->prepare_transfer_hardware =3D spi_bitbang_dummy_pre= pare; > + =A0 =A0 =A0 master->unprepare_transfer_hardware =3D spi_bitbang_dummy_p= repare; Maybe we should think about making these two hooks optional if this pattern turns up a lot. I'll try to fix some refactoring further down the road if nobody beats me to it. Yours, Linus Walleij ---------------------------------------------------------------------------= --- This SF email is sponsosred by: Try Windows Azure free for 90 days Click Here = http://p.sf.net/sfu/sfd2d-msazure