From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 0/3] pinctrl: sunxi: Support generic pinconf functions Date: Thu, 20 Oct 2016 15:13:29 +0200 Message-ID: References: <20161004015112.20833-1-wens@csie.org> Reply-To: linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Sender: linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org In-Reply-To: <20161004015112.20833-1-wens-jdAy2FN1RRM@public.gmane.org> List-Post: , List-Help: , List-Archive: , List-Unsubscribe: , To: Chen-Yu Tsai Cc: Maxime Ripard , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , linux-sunxi List-Id: linux-gpio@vger.kernel.org On Tue, Oct 4, 2016 at 3:51 AM, Chen-Yu Tsai wrote: > This series fixes up generic pinconf support for the sunxi pinctrl driver > library. The driver was doing some bits wrong, like a) storing the pinconf > config value in its struct, and not actually reading the hardware to get > the current config, and b) not using the right arguments for the bias > parameters. Looks OK to me, Maxime are you OK with me applying this, or are we waiting for a new iteration of this patch set? I have started to apply Maxime's generic binding rework, will it clash with these? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S938606AbcJTNNc (ORCPT ); Thu, 20 Oct 2016 09:13:32 -0400 Received: from mail-qk0-f174.google.com ([209.85.220.174]:34212 "EHLO mail-qk0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934247AbcJTNNa (ORCPT ); Thu, 20 Oct 2016 09:13:30 -0400 MIME-Version: 1.0 In-Reply-To: <20161004015112.20833-1-wens@csie.org> References: <20161004015112.20833-1-wens@csie.org> From: Linus Walleij Date: Thu, 20 Oct 2016 15:13:29 +0200 Message-ID: Subject: Re: [PATCH 0/3] pinctrl: sunxi: Support generic pinconf functions To: Chen-Yu Tsai Cc: Maxime Ripard , "linux-gpio@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , linux-sunxi Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 4, 2016 at 3:51 AM, Chen-Yu Tsai wrote: > This series fixes up generic pinconf support for the sunxi pinctrl driver > library. The driver was doing some bits wrong, like a) storing the pinconf > config value in its struct, and not actually reading the hardware to get > the current config, and b) not using the right arguments for the bias > parameters. Looks OK to me, Maxime are you OK with me applying this, or are we waiting for a new iteration of this patch set? I have started to apply Maxime's generic binding rework, will it clash with these? Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Thu, 20 Oct 2016 15:13:29 +0200 Subject: [PATCH 0/3] pinctrl: sunxi: Support generic pinconf functions In-Reply-To: <20161004015112.20833-1-wens@csie.org> References: <20161004015112.20833-1-wens@csie.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Oct 4, 2016 at 3:51 AM, Chen-Yu Tsai wrote: > This series fixes up generic pinconf support for the sunxi pinctrl driver > library. The driver was doing some bits wrong, like a) storing the pinconf > config value in its struct, and not actually reading the hardware to get > the current config, and b) not using the right arguments for the bias > parameters. Looks OK to me, Maxime are you OK with me applying this, or are we waiting for a new iteration of this patch set? I have started to apply Maxime's generic binding rework, will it clash with these? Yours, Linus Walleij