All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Janek Kotas <jank@cadence.com>, Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	linux-gpio <linux-gpio@vger.kernel.org>,
	linux-devicetree <devicetree@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2 2/2] gpio: Add Cadence GPIO driver
Date: Fri, 21 Dec 2018 11:37:04 +0100	[thread overview]
Message-ID: <CACRpkdZJoPKacABqSbxKOZnt7vUar_1_H7q7Brxxo6e2oBnfRw@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJX5ScpYCL0DhM99U=sbhU4VOxaA+gPzBJ698gs0-UFMxQ@mail.gmail.com>

On Tue, Dec 18, 2018 at 3:06 PM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:
> wt., 18 gru 2018 o 14:54 Janek Kotas <jank@cadence.com> napisał(a):

> > I can reimplement the driver using regmap, but It seems in such case
> > I won’t be able to use the Generic GPIO Infrastructure, would I?
> > So I would need to provide functions for setting direction, etc.
> > I think it would make the driver code bigger.
>
> Indeed. If anything: gpio-mmio would need to be converted to using regmap.

Ouch, let's go with this for now.

I think for gpio-mmio we have two new cases we really need to cover:
- port-mapped I/O (x86)
- regmap I/O

Augmenting gpio-mmio for these could probably strip out quite a
bunch of code from several drivers.

Yours,
Linus Walleij

  reply	other threads:[~2018-12-21 10:37 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-17 15:36 [PATCH v2 0/2] gpio: Add a driver for Cadence GPIO controller Jan Kotas
2018-12-17 15:36 ` Jan Kotas
2018-12-17 15:36 ` [PATCH v2 1/2] dt-bindings: gpio: Add bindings for Cadence GPIO Jan Kotas
2018-12-17 15:36   ` Jan Kotas
2018-12-18 17:33   ` Rob Herring
2018-12-17 15:36 ` [PATCH v2 2/2] gpio: Add Cadence GPIO driver Jan Kotas
2018-12-17 15:36   ` Jan Kotas
2018-12-17 15:51   ` Bartosz Golaszewski
2018-12-17 22:21     ` Linus Walleij
2018-12-18 12:50       ` Bartosz Golaszewski
2018-12-18 13:54         ` Janek Kotas
2018-12-18 14:06           ` Bartosz Golaszewski
2018-12-21 10:37             ` Linus Walleij [this message]
2018-12-21 10:34   ` Linus Walleij
2018-12-21 10:34     ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZJoPKacABqSbxKOZnt7vUar_1_H7q7Brxxo6e2oBnfRw@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=jank@cadence.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.