From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v1 1/4] gpio: acpi: Don't return 0 on acpi_gpio_count() Date: Thu, 16 Mar 2017 15:42:51 +0100 Message-ID: References: <20170220161549.39490-1-andriy.shevchenko@linux.intel.com> <20170220161549.39490-2-andriy.shevchenko@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <20170220161549.39490-2-andriy.shevchenko@linux.intel.com> Sender: platform-driver-x86-owner@vger.kernel.org To: Andy Shevchenko Cc: "linux-gpio@vger.kernel.org" , Dmitry Torokhov , Linux Input , Darren Hart , platform-driver-x86 , Benjamin Tissoires , "linux-kernel@vger.kernel.org" List-Id: linux-gpio@vger.kernel.org On Mon, Feb 20, 2017 at 5:15 PM, Andy Shevchenko wrote: > It's unusual to have error checking like (ret <= 0) in cases when > counting GPIO resources. In case when it's mandatory we propagate the > error (-ENOENT), otherwise we don't use the result. > > This makes consistent behaviour across all possible variants called in > gpiod_count(). > > Signed-off-by: Andy Shevchenko Patch applied with Mika's ACK. Yours, Linus Walleij