From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs Date: Fri, 7 Apr 2017 11:12:53 +0200 Message-ID: References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170407084823.GB3412@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-it0-f51.google.com ([209.85.214.51]:36804 "EHLO mail-it0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755863AbdDGJMy (ORCPT ); Fri, 7 Apr 2017 05:12:54 -0400 Received: by mail-it0-f51.google.com with SMTP id 19so19841846itj.1 for ; Fri, 07 Apr 2017 02:12:54 -0700 (PDT) In-Reply-To: <20170407084823.GB3412@localhost.localdomain> Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Charles Keepax Cc: Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , Mark Brown , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax wrote: > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: >> On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij wrote: >> > On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald >> > wrote: >> > >> >> This patch adds a header file of register definitions for Cirrus >> >> Logic "Madera" class codecs. These codecs are all based off a common >> >> set of hardware IP so have a common register map (with a few minor >> >> device-to-device variations). These are complex devices with a large >> >> mber of features and so have a correspondingly large register set. >> >> The registers.h file has been auto-generated from the hardware register >> >> definitions, stripped down to only registers we need to access from >> >> the driver. >> >> >> >> Signed-off-by: Richard Fitzgerald >> > >> > This: >> > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++ >> > >> > Get included in all subdrivers I suppose? >> > >> > So you are broadcasting 8800+ lines into every subdriver across the >> > entire kernel. >> > >> > Just the time spent in the preprocessor parsing this will affect compilation >> > time. >> >> Or maybe this is a necessary sacrifice to get the regmap cache >> centralized in MFD. I don't know. I feel stupid. >> >> I guess I should focus on "my" subsystems... >> > > This only gets included in files that are part of this driver, it > shouldn't affect compilation time for anyone not building the > madera driver and even then it should only affect compilation > times for the 10 or so C files that make up the driver. Also I > don't really see any other way to specify the registers for the > device. No when using regmap cache this seems necessary. I was just wrong. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932678AbdDGJM6 (ORCPT ); Fri, 7 Apr 2017 05:12:58 -0400 Received: from mail-it0-f47.google.com ([209.85.214.47]:33065 "EHLO mail-it0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755916AbdDGJMy (ORCPT ); Fri, 7 Apr 2017 05:12:54 -0400 MIME-Version: 1.0 In-Reply-To: <20170407084823.GB3412@localhost.localdomain> References: <1491386884-30689-1-git-send-email-rf@opensource.wolfsonmicro.com> <1491386884-30689-2-git-send-email-rf@opensource.wolfsonmicro.com> <20170407084823.GB3412@localhost.localdomain> From: Linus Walleij Date: Fri, 7 Apr 2017 11:12:53 +0200 Message-ID: Subject: Re: [PATCH 01/16] mfd: madera: Add register definitions for Cirrus Logic Madera codecs To: Charles Keepax Cc: Richard Fitzgerald , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , Lee Jones , Mark Brown , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Apr 7, 2017 at 10:48 AM, Charles Keepax wrote: > On Fri, Apr 07, 2017 at 10:30:12AM +0200, Linus Walleij wrote: >> On Fri, Apr 7, 2017 at 10:27 AM, Linus Walleij wrote: >> > On Wed, Apr 5, 2017 at 12:07 PM, Richard Fitzgerald >> > wrote: >> > >> >> This patch adds a header file of register definitions for Cirrus >> >> Logic "Madera" class codecs. These codecs are all based off a common >> >> set of hardware IP so have a common register map (with a few minor >> >> device-to-device variations). These are complex devices with a large >> >> mber of features and so have a correspondingly large register set. >> >> The registers.h file has been auto-generated from the hardware register >> >> definitions, stripped down to only registers we need to access from >> >> the driver. >> >> >> >> Signed-off-by: Richard Fitzgerald >> > >> > This: >> > include/linux/mfd/madera/registers.h | 8832 ++++++++++++++++++++++++++++++++++ >> > >> > Get included in all subdrivers I suppose? >> > >> > So you are broadcasting 8800+ lines into every subdriver across the >> > entire kernel. >> > >> > Just the time spent in the preprocessor parsing this will affect compilation >> > time. >> >> Or maybe this is a necessary sacrifice to get the regmap cache >> centralized in MFD. I don't know. I feel stupid. >> >> I guess I should focus on "my" subsystems... >> > > This only gets included in files that are part of this driver, it > shouldn't affect compilation time for anyone not building the > madera driver and even then it should only affect compilation > times for the 10 or so C files that make up the driver. Also I > don't really see any other way to specify the registers for the > device. No when using regmap cache this seems necessary. I was just wrong. Yours, Linus Walleij