From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10B06C433DF for ; Mon, 25 May 2020 11:46:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CE666204EF for ; Mon, 25 May 2020 11:46:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vQj9QTA/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390343AbgEYLqh (ORCPT ); Mon, 25 May 2020 07:46:37 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49074 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390326AbgEYLqg (ORCPT ); Mon, 25 May 2020 07:46:36 -0400 Received: from mail-lj1-x241.google.com (mail-lj1-x241.google.com [IPv6:2a00:1450:4864:20::241]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D4D83C061A0E for ; Mon, 25 May 2020 04:46:35 -0700 (PDT) Received: by mail-lj1-x241.google.com with SMTP id m18so20425358ljo.5 for ; Mon, 25 May 2020 04:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bWYfxIAWJy3heGwDbod2HfNErYY2yOdF0+bL0dgrzOk=; b=vQj9QTA/DYg7DsXQPvNV6nUI3a1yOwQ0VWk/U90mDlQ+3gSPHznwIlKZyHy5k+jTf5 TmTOR4mRbWMy8bWaGbSjNkS4vLc5io5opo3fEHfWbxwNXLhasackcimYv1hG3hTuWztm aOhePHz6h4Pt1j6cIVD8yn7Kpd1IORvt05AFGF8MRJQBM0exJAOG8K/VmeH8OmefyeCd Llf3CtTVnB7HB15c88DYuKUBvV5Xi7IkN8BANcOBFrs3Ri9rQfE1X1neP1HvwWCc4cbf Wf09jsYaD55J1NkY54FHhGosQmbzGZ0rv2+u4sGszipJPKvqcrC/IoXwHicrKzN3xhjB v6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bWYfxIAWJy3heGwDbod2HfNErYY2yOdF0+bL0dgrzOk=; b=YtBWkxywEFQtEBLVUYRGFWIt2pfRnupbYCiTMR1u/2kOLH6/E+MF20OhIZfhvz9Yed 7YcRF2VRoM4HotaOGZy9UuGwNa82i2pNOqIzGJJ5TvSFPPMLCFA8em1yfAi260GKxST3 OGI95t5wsLzlRLIi/T29TxfmSwkpgfEgQD7NiNRtAb+QiUaWZjmlHJWttsURKQeyGhGP L2pkyA+MxEIKMmY78ul1ZnF88w3V/X9b8zqP9f+aNmbOvIMKM59O0lAmC+lthk8r8bEk 6vrHZjt8vSE/PNCjP4X/ABtSMjWADeO4uxqLQWLXbg2XJ75DpQsRwD+q4xIvvF0CWTvt 2iaA== X-Gm-Message-State: AOAM530KL1DZyCXD8thSEtSrDZtPSTE1UfN20XYSsknSWTrDVkp9gc7f sAoxoXmA2D8usQcgUbxdwdqCKXsQyIGLCilW7QShbA== X-Google-Smtp-Source: ABdhPJzXMklVyxm7HDHg3O3m/NvqorX6wkSQG4H/xaCPXxKdEbCUmEhq/fmnpSE8dPrcbHFjkt73KKvjjV+jtcSincc= X-Received: by 2002:a2e:711c:: with SMTP id m28mr13382847ljc.104.1590407194394; Mon, 25 May 2020 04:46:34 -0700 (PDT) MIME-Version: 1.0 References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-6-sudeep.holla@arm.com> In-Reply-To: <20200523170859.50003-6-sudeep.holla@arm.com> From: Linus Walleij Date: Mon, 25 May 2020 13:46:23 +0200 Message-ID: Subject: Re: [PATCH 5/8] soc: ux500: Switch to use DEVICE_ATTR_RO() To: Sudeep Holla Cc: "linux-kernel@vger.kernel.org" , Linux ARM , Arnd Bergmann , Greg Kroah-Hartman Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF8C9C433E0 for ; Mon, 25 May 2020 11:46:44 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 61D88204EF for ; Mon, 25 May 2020 11:46:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="hDEkP+Z4"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="vQj9QTA/" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61D88204EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=q68Y8MFLMz0ItoUfyeejA0rr+f18GpUGeon0sKwu3f8=; b=hDEkP+Z4oDVyWh 3dCBQSpcWrtRjcJHL9x1oVMrXdaVuyeDS8M2/bfGbXdqCQoOet4ar1dM0KrMnRmSkZQiUwZEIS/tT 4cYBe4ELe3zuRHnhugIsfNglR864MEAFOOzn17PultarllQcPQ2F2zeewx8MIBYko9G3akGzdEvZi Abp1LfdQGIsn3A8Rs8Yn49QB0WymwdjadiINzR8lQrduhtsDi/ePKlYNAu3KpiioeABD0/kQMW3Gc atmhj38AcZNTIuNAM3iifJUTAe4Aw8s6fxEmWP8lZkoXkbNMmLofcWEOmzyuPqT9xEoRjY4XsgPKi D36dln/vIHgLEIAAwIYQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdBZ4-0005af-Lb; Mon, 25 May 2020 11:46:42 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jdBYy-0005WR-5r for linux-arm-kernel@lists.infradead.org; Mon, 25 May 2020 11:46:37 +0000 Received: by mail-lj1-x243.google.com with SMTP id z18so20382157lji.12 for ; Mon, 25 May 2020 04:46:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bWYfxIAWJy3heGwDbod2HfNErYY2yOdF0+bL0dgrzOk=; b=vQj9QTA/DYg7DsXQPvNV6nUI3a1yOwQ0VWk/U90mDlQ+3gSPHznwIlKZyHy5k+jTf5 TmTOR4mRbWMy8bWaGbSjNkS4vLc5io5opo3fEHfWbxwNXLhasackcimYv1hG3hTuWztm aOhePHz6h4Pt1j6cIVD8yn7Kpd1IORvt05AFGF8MRJQBM0exJAOG8K/VmeH8OmefyeCd Llf3CtTVnB7HB15c88DYuKUBvV5Xi7IkN8BANcOBFrs3Ri9rQfE1X1neP1HvwWCc4cbf Wf09jsYaD55J1NkY54FHhGosQmbzGZ0rv2+u4sGszipJPKvqcrC/IoXwHicrKzN3xhjB v6gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bWYfxIAWJy3heGwDbod2HfNErYY2yOdF0+bL0dgrzOk=; b=rkVPSKFywakWtMW5QWbsD3kkiubAIVQIzYwoBs1Wt1SlQtzj00OOZCL6rEkPJ3f8kW 4pXteempwMSuTd2FmnCLoUiYVyxS6YklDVKx0LdlZjBEgST73uTUR2QIXMPFjn2bR/0P m3pqJb9FOUcUcIrHfxIl1Toe3G1P8jPJYmyWS3ZEMUhKi5eG59aYF6zJ5UgA4FvJOyMz kyHvcyCpiOCxwOfpLHcgnXcfzXGLLCS8U5dftCaOPMBooVNpPX6cAmez/HWffDaMxvmZ SX0k7ZoYbMcw26+QEAwI1uV9823YDB0z2tw8INdn/lV+ZMCSGTMM35fd+3emDDF2WQL0 z/sg== X-Gm-Message-State: AOAM5307xrDIfU1svsUhbnobS1Kh/s12wPQ4wktGK23OuJj3Pn3IYSPv o6Zie885wmVqSS0QmTEQA7w5ntxX5Yu1sPqkpa8egedw5Nw= X-Google-Smtp-Source: ABdhPJzXMklVyxm7HDHg3O3m/NvqorX6wkSQG4H/xaCPXxKdEbCUmEhq/fmnpSE8dPrcbHFjkt73KKvjjV+jtcSincc= X-Received: by 2002:a2e:711c:: with SMTP id m28mr13382847ljc.104.1590407194394; Mon, 25 May 2020 04:46:34 -0700 (PDT) MIME-Version: 1.0 References: <20200523170859.50003-1-sudeep.holla@arm.com> <20200523170859.50003-6-sudeep.holla@arm.com> In-Reply-To: <20200523170859.50003-6-sudeep.holla@arm.com> From: Linus Walleij Date: Mon, 25 May 2020 13:46:23 +0200 Message-ID: Subject: Re: [PATCH 5/8] soc: ux500: Switch to use DEVICE_ATTR_RO() To: Sudeep Holla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200525_044636_233659_6400B73B X-CRM114-Status: UNSURE ( 8.04 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Greg Kroah-Hartman , Arnd Bergmann , "linux-kernel@vger.kernel.org" , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, May 23, 2020 at 7:09 PM Sudeep Holla wrote: > Move device attributes to DEVICE_ATTR_RO() as that would make things > a lot more "obvious" what is happening over the existing __ATTR usage. > > Cc: Linus Walleij > Signed-off-by: Sudeep Holla Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel