From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v3 11/17] pinctrl: madera: Add driver for Cirrus Logic Madera codecs Date: Fri, 9 Jun 2017 11:13:34 +0200 Message-ID: References: <1496415790-19164-1-git-send-email-rf@opensource.wolfsonmicro.com> <1496415790-19164-12-git-send-email-rf@opensource.wolfsonmicro.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: <1496415790-19164-12-git-send-email-rf-yzvPICuk2AATkU/dhu1WVueM+bqZidxxQQ4Iyu8u01E@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Richard Fitzgerald Cc: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , "alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald wrote: > These codecs have a variable number of I/O lines each of which > is individually selectable to a wide range of possible functions. > > The functionality is slightly different from the traditional muxed > GPIO since most of the functions can be mapped to any pin (and even > the same function to multiple pins). Most pins have a dedicated > "alternate" function that is only available on that pin. The > alternate functions are usually a group of signals, though it is > not always necessary to enable the full group, depending on the > alternate function and how it is to be used. The mapping between > alternate functions and GPIO pins varies between codecs depending > on the number of alternate functions and available pins. > > Note on the Kconfig options: > The formula "default y if..." is used for PINCTRL_MADERA so that its > select options will be processed, allowing us to group selects for > pinctrl into the pinctrl Kconfig where they logically belong instead > of accumulating under the parent MFD Kconfig. > > Signed-off-by: Richard Fitzgerald > --- > Changes since V2: > - Removed unused drive strength settings to tidy the code > - Use devm_pinctrl_register_and_init() to avoid the problems with > pinctrl_register() > - Replaced a couple of hardcoded masks with the defined constant There is a Kconfig problem as pointed out by the build robot. Apart from that this looks like merge material, and we need to think about a merge strategy like with the GPIO patch, once the MFD portions are ready. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751786AbdFIJNj (ORCPT ); Fri, 9 Jun 2017 05:13:39 -0400 Received: from mail-io0-f182.google.com ([209.85.223.182]:36165 "EHLO mail-io0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751647AbdFIJNf (ORCPT ); Fri, 9 Jun 2017 05:13:35 -0400 MIME-Version: 1.0 In-Reply-To: <1496415790-19164-12-git-send-email-rf@opensource.wolfsonmicro.com> References: <1496415790-19164-1-git-send-email-rf@opensource.wolfsonmicro.com> <1496415790-19164-12-git-send-email-rf@opensource.wolfsonmicro.com> From: Linus Walleij Date: Fri, 9 Jun 2017 11:13:34 +0200 Message-ID: Subject: Re: [PATCH v3 11/17] pinctrl: madera: Add driver for Cirrus Logic Madera codecs To: Richard Fitzgerald Cc: Lee Jones , Mark Brown , Alexandre Courbot , Rob Herring , Thomas Gleixner , Jason Cooper , "alsa-devel@alsa-project.org" , "open list:WOLFSON MICROELECTRONICS DRIVERS" , "linux-gpio@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jun 2, 2017 at 5:03 PM, Richard Fitzgerald wrote: > These codecs have a variable number of I/O lines each of which > is individually selectable to a wide range of possible functions. > > The functionality is slightly different from the traditional muxed > GPIO since most of the functions can be mapped to any pin (and even > the same function to multiple pins). Most pins have a dedicated > "alternate" function that is only available on that pin. The > alternate functions are usually a group of signals, though it is > not always necessary to enable the full group, depending on the > alternate function and how it is to be used. The mapping between > alternate functions and GPIO pins varies between codecs depending > on the number of alternate functions and available pins. > > Note on the Kconfig options: > The formula "default y if..." is used for PINCTRL_MADERA so that its > select options will be processed, allowing us to group selects for > pinctrl into the pinctrl Kconfig where they logically belong instead > of accumulating under the parent MFD Kconfig. > > Signed-off-by: Richard Fitzgerald > --- > Changes since V2: > - Removed unused drive strength settings to tidy the code > - Use devm_pinctrl_register_and_init() to avoid the problems with > pinctrl_register() > - Replaced a couple of hardcoded masks with the defined constant There is a Kconfig problem as pointed out by the build robot. Apart from that this looks like merge material, and we need to think about a merge strategy like with the GPIO patch, once the MFD portions are ready. Yours, Linus Walleij