All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Lars-Peter Clausen <lars@metafoo.de>
Cc: Jonathan Cameron <jic23@kernel.org>,
	Tiberiu Breana <tiberiu.a.breana@intel.com>,
	Peter Meerwald-Stadler <pmeerw@pmeerw.net>,
	linux-iio <linux-iio@vger.kernel.org>
Subject: Re: [PATCH 2/3] iio: kxsd9: Don't return error code in trigger handler
Date: Mon, 25 Oct 2021 02:05:54 +0200	[thread overview]
Message-ID: <CACRpkdZPjYPUPj233csw+jBVc_-VYDztz2k_X0ryoKt9P8V9yA@mail.gmail.com> (raw)
In-Reply-To: <20211024171251.22896-2-lars@metafoo.de>

On Sun, Oct 24, 2021 at 7:13 PM Lars-Peter Clausen <lars@metafoo.de> wrote:

> IIO trigger handlers need to return one of the irqreturn_t values.
> Returning an error code is not supported.
>
> The kxsd9 interrupt handler returns an error code if reading the data
> registers fails. In addition when exiting due to an error the trigger
> handler does not call `iio_trigger_notify_done()`. Which when not done
> keeps the triggered disabled forever.
>
> Modify the code so that the function returns a valid irqreturn_t value as
> well as calling `iio_trigger_notify_done()` on all exit paths.
>
> Since we can't return the error code make sure to at least log it as part
> of the error message.
>
> Fixes: 0427a106a98a ("iio: accel: kxsd9: Add triggered buffer handling")
> Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

  reply	other threads:[~2021-10-25  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-10-24 17:12 [PATCH 1/3] iio: ltr501: Don't return error code in trigger handler Lars-Peter Clausen
2021-10-24 17:12 ` [PATCH 2/3] iio: kxsd9: " Lars-Peter Clausen
2021-10-25  0:05   ` Linus Walleij [this message]
2021-10-24 17:12 ` [PATCH 3/3] iio: stk3310: Don't return error code in interrupt handler Lars-Peter Clausen
2021-10-28 14:05 ` [PATCH 1/3] iio: ltr501: Don't return error code in trigger handler Jonathan Cameron

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZPjYPUPj233csw+jBVc_-VYDztz2k_X0ryoKt9P8V9yA@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=jic23@kernel.org \
    --cc=lars@metafoo.de \
    --cc=linux-iio@vger.kernel.org \
    --cc=pmeerw@pmeerw.net \
    --cc=tiberiu.a.breana@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.