From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA51EB64D7 for ; Wed, 28 Jun 2023 19:19:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229626AbjF1TTC (ORCPT ); Wed, 28 Jun 2023 15:19:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231453AbjF1TSy (ORCPT ); Wed, 28 Jun 2023 15:18:54 -0400 Received: from mail-yb1-xb2e.google.com (mail-yb1-xb2e.google.com [IPv6:2607:f8b0:4864:20::b2e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9C9CF1FF7 for ; Wed, 28 Jun 2023 12:18:50 -0700 (PDT) Received: by mail-yb1-xb2e.google.com with SMTP id 3f1490d57ef6-c15a5ed884dso80318276.2 for ; Wed, 28 Jun 2023 12:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=bwFjvvNcUJo7//TF8Jp1vEu1xBV6qJmdrgeX0/ANiiVkekDwHHURXv+DV88cWYT6jW RbHZEIn3r9PtHYcU4fIMjie5zJI6IS0zU0Yq+6jHzzBqH1S+8mbos0IDAI3y4O1YxynU imdW1P2optY818M2gbNF5hU4q2ZU/cpterMPuJEU5VtKZ63vv5BOPOYpaOXFEVDcJCZe njEyQ1uoFmFpp8jWN7ztedU+45WHoCMjLCJHxIZUoYY3yo0OHqUkekyUbJVC4tKKMOka OguEhhd/Ez61qhzCh0w6nIJMbVWfYEit5vhI4og1FaIZ6NwTsVbGXZoQEAU8iEt/P0Zs bmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=EN9INhvY94SzW/5l+YELHHjlXhVtJtzLLErkNPDw6+zrX/SUcvOM+6PuSX2WBTC9hR bpj+yLfewKc8DkXiuYfZihuKmF+7kChbAIRp44bNhiOA6T2+vfIWYqLcgQkbMFkhFh9b XBZOicskJm5xsafmPPG6xQwfZqaPGD+/VcgqZBQwCyW6ZuojhN+NSWVCS9wNs58M9+W2 K27pyIYYfzy/+SSak2R11BNu4fNIlaTB/IdsbUlkgr2YC1PKLTHvNKng1xfcNKHIKtwZ EQ98gfWP15VBGFviDAtGwMt4rMw2b3+2ce3YYK0yf50bwBe+LoAhftlWkxD7MbVK1NPn o9Nw== X-Gm-Message-State: AC+VfDzu4snwqZG9/gTKvVhnz/c/cpATQ96N8oHz8OlKuo5DV5EJ/Vwa XJ849utTunFbLaMUsd8nstsHopx2abxXuPo9tSMkoA== X-Google-Smtp-Source: ACHHUZ7rpDB3iLiEU8xufHcYAsfVBnrCQGv7FT1VlaIgweQmvXwzogrWdJylssczyf5duNaEFnucjJqA02PevJT363c= X-Received: by 2002:a05:6902:91:b0:bb8:4cc6:9d09 with SMTP id h17-20020a056902009100b00bb84cc69d09mr28026725ybs.29.1687979929795; Wed, 28 Jun 2023 12:18:49 -0700 (PDT) MIME-Version: 1.0 References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-10-541c341d6bee@somainline.org> In-Reply-To: From: Linus Walleij Date: Wed, 28 Jun 2023 21:18:38 +0200 Message-ID: Subject: Re: [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 To: Marijn Suijten Cc: Neil Armstrong , Sam Ravnborg , David Airlie , Daniel Vetter , Caleb Connolly , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Andy Gross , Bjorn Andersson , devicetree@vger.kernel.org, Jami Kettunen , linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Abhinav Kumar , Konrad Dybcio , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Dmitry Baryshkov , Jessica Zhang , Kuogee Hsieh Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Wed, Jun 28, 2023 at 4:20=E2=80=AFPM Marijn Suijten wrote: > But for now we might already create a step-up version of that by having > a "Samsung panel driver library" to deduplicate generic commands, which > drivers can freely call into? Yeah something like that is likely what we want. > On the other hand of the spectrum we currently have 4 downstream panels > for Sony devices that all declare to be using the sofef01 controller, > but with vastly different command sets. And even if we "accidentally" > send the wrong set for the wrong device, the panel works anyway with no > noticeable color shifts or otherwise... Yeah that is typically the case :/ We should try to group the similar code together and expect that sooner or later we will figure out what display controller(s) it is and name it af= ter that rather than after the panel (which I define as the combination of a display controller and an actual panel). Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 00764EB64DA for ; Wed, 28 Jun 2023 19:18:52 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0C3A310E0B8; Wed, 28 Jun 2023 19:18:52 +0000 (UTC) Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by gabe.freedesktop.org (Postfix) with ESMTPS id 005CC10E0B8 for ; Wed, 28 Jun 2023 19:18:50 +0000 (UTC) Received: by mail-yb1-xb36.google.com with SMTP id 3f1490d57ef6-be30cbe88b3so84420276.1 for ; Wed, 28 Jun 2023 12:18:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=bwFjvvNcUJo7//TF8Jp1vEu1xBV6qJmdrgeX0/ANiiVkekDwHHURXv+DV88cWYT6jW RbHZEIn3r9PtHYcU4fIMjie5zJI6IS0zU0Yq+6jHzzBqH1S+8mbos0IDAI3y4O1YxynU imdW1P2optY818M2gbNF5hU4q2ZU/cpterMPuJEU5VtKZ63vv5BOPOYpaOXFEVDcJCZe njEyQ1uoFmFpp8jWN7ztedU+45WHoCMjLCJHxIZUoYY3yo0OHqUkekyUbJVC4tKKMOka OguEhhd/Ez61qhzCh0w6nIJMbVWfYEit5vhI4og1FaIZ6NwTsVbGXZoQEAU8iEt/P0Zs bmkQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687979930; x=1690571930; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7DUD/shWe46KMvA0LBMlGn2qbYD6iSa8fQ8POxlPlXM=; b=jG1n2yPK81gVTMZxzROhRYFi7b0Na4kXCvTMlwhBe8BSDVOT1plX4pXVUjYbYgv2Ls QWAIOlKo0qxJB8ERfwMYFzXfJTOpK7tiLGt2oqbYbAVEveGxdkb1yRzhTFq1GdcQg/T5 gwoH4dHTXu9JVIpPYjKmzyu/EOdPNJ75LMhJnllfzVGM918bCU09La71/NORbTt803VM jV6OX7QY6F5ZKfHckEM+7saUviQmA/uXRFHJ3CIayUoVlpjSC82kNNy+icjdtyKeZwhp PqpW4Wl6vkTV1GBHINJH2RGg1Winzwgjh2zvuKz2XbHExJ/pYPYieMMK/tVweOX9aSnU woTw== X-Gm-Message-State: AC+VfDx+CWuXBmw28FIsaHwIKq7fIyeUj64lGHPmsXwwzTsUUAA3DDWv M8jwI3cLuwruaKRevY34nEPzJqhVHpaibtaQ0ZU4vA== X-Google-Smtp-Source: ACHHUZ7rpDB3iLiEU8xufHcYAsfVBnrCQGv7FT1VlaIgweQmvXwzogrWdJylssczyf5duNaEFnucjJqA02PevJT363c= X-Received: by 2002:a05:6902:91:b0:bb8:4cc6:9d09 with SMTP id h17-20020a056902009100b00bb84cc69d09mr28026725ybs.29.1687979929795; Wed, 28 Jun 2023 12:18:49 -0700 (PDT) MIME-Version: 1.0 References: <20230521-drm-panels-sony-v1-0-541c341d6bee@somainline.org> <20230521-drm-panels-sony-v1-10-541c341d6bee@somainline.org> In-Reply-To: From: Linus Walleij Date: Wed, 28 Jun 2023 21:18:38 +0200 Message-ID: Subject: Re: [PATCH RFC 10/10] drm/panel/sony-griffin-samsung: Add panel driver for Sony Xperia 1 To: Marijn Suijten Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dri-devel@lists.freedesktop.org, Caleb Connolly , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Sam Ravnborg , Kuogee Hsieh , Andy Gross , Jessica Zhang , devicetree@vger.kernel.org, Conor Dooley , linux-arm-msm@vger.kernel.org, Abhinav Kumar , Rob Herring , Martin Botka , ~postmarketos/upstreaming@lists.sr.ht, Neil Armstrong , Jami Kettunen , Bjorn Andersson , linux-kernel@vger.kernel.org, Konrad Dybcio , Dmitry Baryshkov Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Wed, Jun 28, 2023 at 4:20=E2=80=AFPM Marijn Suijten wrote: > But for now we might already create a step-up version of that by having > a "Samsung panel driver library" to deduplicate generic commands, which > drivers can freely call into? Yeah something like that is likely what we want. > On the other hand of the spectrum we currently have 4 downstream panels > for Sony devices that all declare to be using the sofef01 controller, > but with vastly different command sets. And even if we "accidentally" > send the wrong set for the wrong device, the panel works anyway with no > noticeable color shifts or otherwise... Yeah that is typically the case :/ We should try to group the similar code together and expect that sooner or later we will figure out what display controller(s) it is and name it af= ter that rather than after the panel (which I define as the combination of a display controller and an actual panel). Yours, Linus Walleij