From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RFC PATCH V2 8/8] irqchip/gic: Add support for tegra AGIC interrupt controller Date: Thu, 17 Dec 2015 14:32:47 +0100 Message-ID: References: <1450349309-8107-1-git-send-email-jonathanh@nvidia.com> <1450349309-8107-9-git-send-email-jonathanh@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1450349309-8107-9-git-send-email-jonathanh-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jon Hunter , "linux-pm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "Rafael J. Wysocki" Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Jiang Liu , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Soren Brinkmann , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Ulf Hansson List-Id: linux-tegra@vger.kernel.org On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter wrote: > Add a driver for the Tegra-AGIC interrupt controller which is compatible > with the ARM GIC-400 interrupt controller. (...) > +static const struct dev_pm_ops gic_pm_ops = { > + SET_RUNTIME_PM_OPS(gic_runtime_suspend, > + gic_runtime_resume, NULL) > + SET_SYSTEM_SLEEP_PM_OPS(gic_suspend, gic_resume) > +}; Now you do what I commented on in the earlier patch: assign the runtime PM functions to normal suspend/resume. This will have the effect of inhibiting any IRQs marked for wakeup on the GIC, even if you just want to go to sleep until something happens, will it not? You should turn on the alarm clock before going to bed, not turn it off, as figure of speak ... Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934695AbbLQNcu (ORCPT ); Thu, 17 Dec 2015 08:32:50 -0500 Received: from mail-ob0-f170.google.com ([209.85.214.170]:35613 "EHLO mail-ob0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753119AbbLQNcs (ORCPT ); Thu, 17 Dec 2015 08:32:48 -0500 MIME-Version: 1.0 In-Reply-To: <1450349309-8107-9-git-send-email-jonathanh@nvidia.com> References: <1450349309-8107-1-git-send-email-jonathanh@nvidia.com> <1450349309-8107-9-git-send-email-jonathanh@nvidia.com> Date: Thu, 17 Dec 2015 14:32:47 +0100 Message-ID: Subject: Re: [RFC PATCH V2 8/8] irqchip/gic: Add support for tegra AGIC interrupt controller From: Linus Walleij To: Jon Hunter , "linux-pm@vger.kernel.org" , "Rafael J. Wysocki" Cc: Thomas Gleixner , Jason Cooper , Marc Zyngier , Jiang Liu , Stephen Warren , Thierry Reding , Kevin Hilman , Geert Uytterhoeven , Grygorii Strashko , Lars-Peter Clausen , Soren Brinkmann , "linux-kernel@vger.kernel.org" , "linux-tegra@vger.kernel.org" , Ulf Hansson Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 17, 2015 at 11:48 AM, Jon Hunter wrote: > Add a driver for the Tegra-AGIC interrupt controller which is compatible > with the ARM GIC-400 interrupt controller. (...) > +static const struct dev_pm_ops gic_pm_ops = { > + SET_RUNTIME_PM_OPS(gic_runtime_suspend, > + gic_runtime_resume, NULL) > + SET_SYSTEM_SLEEP_PM_OPS(gic_suspend, gic_resume) > +}; Now you do what I commented on in the earlier patch: assign the runtime PM functions to normal suspend/resume. This will have the effect of inhibiting any IRQs marked for wakeup on the GIC, even if you just want to go to sleep until something happens, will it not? You should turn on the alarm clock before going to bed, not turn it off, as figure of speak ... Yours, Linus Walleij