From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B39F2C433B4 for ; Sat, 1 May 2021 12:07:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8B7A4611BE for ; Sat, 1 May 2021 12:07:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231952AbhEAMIJ (ORCPT ); Sat, 1 May 2021 08:08:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46570 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231918AbhEAMIJ (ORCPT ); Sat, 1 May 2021 08:08:09 -0400 Received: from mail-lf1-x131.google.com (mail-lf1-x131.google.com [IPv6:2a00:1450:4864:20::131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 30568C06174A for ; Sat, 1 May 2021 05:07:19 -0700 (PDT) Received: by mail-lf1-x131.google.com with SMTP id c11so1095579lfi.9 for ; Sat, 01 May 2021 05:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cShhxOov7yPyGv2gqNT9J0Wvb5A03fZum4wVgMZcev0=; b=bovKm0NsrMUQ92+ShbG6eIgqrhlAYcOckDEUfVkF9aUE77zfmA0yY6m+pLbCntRryr xmy6WV+CNWATAVNw548V3+baVqI5Aw1ZD4yWFGZgZCKjp/OolvYQ+zYKPS4eWd4CqbsH RNaJmOYvOmdBRpQ8pPqsc69ddxVh6zVjS5jbgLSWXLHypgeucOjGHK2BmGdqDSlZ/hy1 IAu5Tje2Qaygt85s7veL9m5QZVblRiVtz8wcaTLabRbdUM23JMSNz0U4DKEumaHys10d N+fsdhCHPYKuN3fgTdy3cy6CHzWn1jPJs0aGmBAFw8Ps0W/7B1raJyLy4oz1y8osYOMI RQFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cShhxOov7yPyGv2gqNT9J0Wvb5A03fZum4wVgMZcev0=; b=rXPDsE7tPynWczUEZJDlcR2qntDKLjWmjPfhh7Pu7z3ZO5zsX16gRsGbOkrhV/gJcI OR1tPAf7/Qhx9SXc92lOqiVg+E4JqCTD0fUvQ3jTqZ9r9Jz+Bea/BOxrqMKGeyITeEF1 I6t7iEWcD/0CuF9Pkbr7mcIk2xSWCx1jGdiJpcm6Ys0+UhYgTbKBY8TKkrG4ckeytlTV TLNNe489Fn/T1qlGH++bPyuj/i98WhyP4lacdInbsXFVsyFapYhLS9JeFsqSl9ieOipM 1Q2fK9cx7wge6vSfJHjx3ZxtG1sfMyC+0nB5usJF6klGUbCJqxE7mQPrsrQrFOQ6/GnK PqBg== X-Gm-Message-State: AOAM532GfzbKThkTKJ1gyolnZq1JrgeDzVv23Y6KcgdWGtJ8kTR1tVPa 3svciJYDvAHGAT5PTtjXica54BI3jCSwjpt/FPDG7g== X-Google-Smtp-Source: ABdhPJyBwdw5C0bHiY+W+PETkYMvzi+/Aa+5T0VzdotioKXyHm1/7V5opQjGZkISSW+Ddx6ZdzyULKJ0smN/s3mnWKE= X-Received: by 2002:a05:6512:149:: with SMTP id m9mr6205501lfo.157.1619870837611; Sat, 01 May 2021 05:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Linus Walleij Date: Sat, 1 May 2021 14:07:06 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Doug Anderson Cc: Andrzej Hajda , Laurent Pinchart , Bjorn Andersson , Neil Armstrong , Jonas Karlman , Jernej Skrabec , Sam Ravnborg , Wolfram Sang , MSM , Rob Clark , Stanislav Lisovskiy , Stephen Boyd , Steev Klimaszewski , Maarten Lankhorst , linux-i2c , "open list:DRM PANEL DRIVERS" , Daniel Vetter , David Airlie , Thierry Reding , linux-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org Hi Doug, On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > Pushed this one patch. Rest of the series is pending adult > supervision. Overall summary: > > 1. I could probably push some of the early sn65dsi86 cleanup patches > in this series since they have Bjorn's review and are pretty much > no-ops / simple cleanups, but there's probably not tons gained for > shoving those in early. Those look good to me as well. I'd say just apply them. To me it looks like up until and including patch 18? Feel free to add my Acked-by: Linus Walleij On these. > 2. The whole concept of breaking up the patch into sub-drivers has no > official Reviewed-by tags yet. Presumably Bjorn will give those a > re-review when he has time again. It looks good to me so I sent an explicit ACK on that patch. > 3. Laurent and I had a big discussion on #dri-devel yesterday about > the EDID reading. He's not totally convinced with the idea of doing > this in the panel when the bridge could just do it by itself, but it > sounded like he might be coming around. Right now this is waiting on > Laurent to have time to get back to this. I dare not speak of this. Laurent has the long and tedious experience with panels and pretty much anything related so if Laurent is hesitant then I am hesitant too. His buy-in is absolutely required. But IIUC that is just for patch 19+20? It'd be good to apply the rest and get down the stack. Just to keep you busy and make sure you don't run out of work (haha) I noticed that the gpio_chip in this driver can use the new GPIO_REGMAP helper library with the fixes just landed in Torvald's tree. At your convenience and when you think there is too little stuff in your sn65dsi86 TODO, check out pinctrl-bcm63xx.c for an example of select GPIO_REGMAP made very simple (this works fine as long as they are bit offsets starting from 0). Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2979C43460 for ; Sat, 1 May 2021 12:07:22 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8468F61450 for ; Sat, 1 May 2021 12:07:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8468F61450 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 931846E1CD; Sat, 1 May 2021 12:07:20 +0000 (UTC) Received: from mail-lf1-x12f.google.com (mail-lf1-x12f.google.com [IPv6:2a00:1450:4864:20::12f]) by gabe.freedesktop.org (Postfix) with ESMTPS id 320276E1CD for ; Sat, 1 May 2021 12:07:19 +0000 (UTC) Received: by mail-lf1-x12f.google.com with SMTP id x20so1112281lfu.6 for ; Sat, 01 May 2021 05:07:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cShhxOov7yPyGv2gqNT9J0Wvb5A03fZum4wVgMZcev0=; b=bovKm0NsrMUQ92+ShbG6eIgqrhlAYcOckDEUfVkF9aUE77zfmA0yY6m+pLbCntRryr xmy6WV+CNWATAVNw548V3+baVqI5Aw1ZD4yWFGZgZCKjp/OolvYQ+zYKPS4eWd4CqbsH RNaJmOYvOmdBRpQ8pPqsc69ddxVh6zVjS5jbgLSWXLHypgeucOjGHK2BmGdqDSlZ/hy1 IAu5Tje2Qaygt85s7veL9m5QZVblRiVtz8wcaTLabRbdUM23JMSNz0U4DKEumaHys10d N+fsdhCHPYKuN3fgTdy3cy6CHzWn1jPJs0aGmBAFw8Ps0W/7B1raJyLy4oz1y8osYOMI RQFQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cShhxOov7yPyGv2gqNT9J0Wvb5A03fZum4wVgMZcev0=; b=ptrZ+xk4mMovV+NxZf6SYeSTIHAD9kf8JGZeVInfrrP37rKX/hWdKPVR0NSSyfdGeJ EAY6qr+XR1J4T7usyTD+h077cfRQyi+yHMA7w/Jm2zMdE8GSRULUChWygQhbsd7/ez77 XIYSxxF2Ggwz8x9n611bSaR/RBi4HG7OFn90xSASiOZFMisT00tSZQAB/DC+0JBJG9jI CUe7DalXb8JrcUQbT53cKLDGffduCc02v0CssU5Wh+CibiyQ+flg3ohevOHoHsw7PKZe FqYIUPTOPaFbtjuQOnUYhLiAah0ZS8OwIJ8mXMLO6jkgtWaIpMu5211YmAR+2TKVsMbd Bk3g== X-Gm-Message-State: AOAM531P7wIApm8IRwRGV6O1zIIw/jmFejnCdwwsqw9S+HEThJ6rzI5z wpusHB8bRJ/6GpDdkRtjzEkjTbtbfdE68D9n5RrILQ== X-Google-Smtp-Source: ABdhPJyBwdw5C0bHiY+W+PETkYMvzi+/Aa+5T0VzdotioKXyHm1/7V5opQjGZkISSW+Ddx6ZdzyULKJ0smN/s3mnWKE= X-Received: by 2002:a05:6512:149:: with SMTP id m9mr6205501lfo.157.1619870837611; Sat, 01 May 2021 05:07:17 -0700 (PDT) MIME-Version: 1.0 References: <20210423165906.2504169-1-dianders@chromium.org> <20210423095743.v5.1.I9e6af2529d6c61e5daf86a15a1211121c5223b9a@changeid> In-Reply-To: From: Linus Walleij Date: Sat, 1 May 2021 14:07:06 +0200 Message-ID: Subject: Re: [PATCH v5 01/20] drm/panel: panel-simple: Add missing pm_runtime_disable() calls To: Doug Anderson X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Clark , Stanislav Lisovskiy , Jernej Skrabec , Jonas Karlman , David Airlie , MSM , "open list:DRM PANEL DRIVERS" , Neil Armstrong , linux-kernel , Steev Klimaszewski , Bjorn Andersson , Wolfram Sang , Andrzej Hajda , Thierry Reding , Laurent Pinchart , Stephen Boyd , Sam Ravnborg , linux-i2c Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" Hi Doug, On Fri, Apr 30, 2021 at 11:04 PM Doug Anderson wrote: > Pushed this one patch. Rest of the series is pending adult > supervision. Overall summary: > > 1. I could probably push some of the early sn65dsi86 cleanup patches > in this series since they have Bjorn's review and are pretty much > no-ops / simple cleanups, but there's probably not tons gained for > shoving those in early. Those look good to me as well. I'd say just apply them. To me it looks like up until and including patch 18? Feel free to add my Acked-by: Linus Walleij On these. > 2. The whole concept of breaking up the patch into sub-drivers has no > official Reviewed-by tags yet. Presumably Bjorn will give those a > re-review when he has time again. It looks good to me so I sent an explicit ACK on that patch. > 3. Laurent and I had a big discussion on #dri-devel yesterday about > the EDID reading. He's not totally convinced with the idea of doing > this in the panel when the bridge could just do it by itself, but it > sounded like he might be coming around. Right now this is waiting on > Laurent to have time to get back to this. I dare not speak of this. Laurent has the long and tedious experience with panels and pretty much anything related so if Laurent is hesitant then I am hesitant too. His buy-in is absolutely required. But IIUC that is just for patch 19+20? It'd be good to apply the rest and get down the stack. Just to keep you busy and make sure you don't run out of work (haha) I noticed that the gpio_chip in this driver can use the new GPIO_REGMAP helper library with the fixes just landed in Torvald's tree. At your convenience and when you think there is too little stuff in your sn65dsi86 TODO, check out pinctrl-bcm63xx.c for an example of select GPIO_REGMAP made very simple (this works fine as long as they are bit offsets starting from 0). Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel