From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46CCDFA3728 for ; Wed, 16 Oct 2019 13:01:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1842720854 for ; Wed, 16 Oct 2019 13:01:40 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BAyU5dpl" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2393402AbfJPNBj (ORCPT ); Wed, 16 Oct 2019 09:01:39 -0400 Received: from mail-qt1-f193.google.com ([209.85.160.193]:45729 "EHLO mail-qt1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393401AbfJPNBj (ORCPT ); Wed, 16 Oct 2019 09:01:39 -0400 Received: by mail-qt1-f193.google.com with SMTP id c21so35867808qtj.12 for ; Wed, 16 Oct 2019 06:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnE8lBSLY3wNnqyY4G8WlYMgwsueTd/EoUksCVuD65E=; b=BAyU5dplrFadafcQV8wzsDzA1AsMPOKwhq1dJebWhm730gL3t0WiDFQHtMnfwYBf5T 4Q3eSK6Qq4ex1FD2/Q5f/ZdJRQSYJ1upnqdfq3Y9yHAx9LPaJFHmMZqahRBIUgFvjzG7 kyskQIhOvG9uaorqTV6HcCGjVmLrbZ2w962+QDCXzJ0IcaDaXG4uCWBfNqNI7CzZMpMm KfYK2f7WJ819fImO5EARWvL30f98knyldXDIOVxA13Gm0P7QnI/xQLDZmA5o0ZP+3CEZ 7FaSVGt6ptwWaA+rQepImmf1YT97mShCV2ZnEtliGHHwPrzqBbDrhpGaTFsBaPbXHvGt 4Rvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnE8lBSLY3wNnqyY4G8WlYMgwsueTd/EoUksCVuD65E=; b=KFWq9kCwydpwpMaBjvSys3HTFhc6yfhaBDNJcXMokZUwoevAfZ58MkIGYldSH8SuFK 8I/Kzy+pQ30objq/XuAzbzOtMJ4PvumAxFDpzcTKKoa837UlUBMHicsVDXup5kLzb32s vUgQHoap6CanijkHL2xG6x4x9IV039BGJzfugimQbkBfWXv/1ExDBgqLg8zqulcTwahz 5uSPizPqgnl99oyOha4oL0O9cA3irXgFtUjb1JfD1OK/y/L8pvs+tFOBZsxXwj+ZxnYx vgfco6vAgXk8r9rmYce066HIc6m9VzIPv/nCCANYlkGzqPabf99Nt+zi+g/xYQSIdU7m x0lw== X-Gm-Message-State: APjAAAWekt6kInn5ugXb2lToT+CdZ+5Y+URFUvG4hyAgpPdMIwregW0L FaM6k0dRb82yt1Yy+sX/wEo3I32RDA5mq6mx4+52ho9E X-Google-Smtp-Source: APXvYqwW5pJtOTNrnLrO03T1G9+Fcg/NuG1gN7wmIq4pJ8cxsc7jBg6TJfq5ooHjs4qjHlf1A3fmee9vr4kyD9kiJvg= X-Received: by 2002:ac8:2a38:: with SMTP id k53mr13105733qtk.387.1571230897593; Wed, 16 Oct 2019 06:01:37 -0700 (PDT) MIME-Version: 1.0 References: <20191014121910.7264-1-ard.biesheuvel@linaro.org> <20191014121910.7264-7-ard.biesheuvel@linaro.org> In-Reply-To: <20191014121910.7264-7-ard.biesheuvel@linaro.org> From: Linus Walleij Date: Wed, 16 Oct 2019 15:01:26 +0200 Message-ID: Subject: Re: [PATCH 06/25] crypto: ux500 - switch to skcipher API To: Ard Biesheuvel Cc: linux-crypto@vger.kernel.org, Herbert Xu , "David S. Miller" , Eric Biggers , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-crypto-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-crypto@vger.kernel.org On Mon, Oct 14, 2019 at 2:19 PM Ard Biesheuvel wrote: > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers of the API have > been converted long ago, some producers of the ablkcipher remain, forcing > us to keep the ablkcipher support routines alive, along with the matching > code to expose [a]blkciphers via the skcipher API. > > So switch this driver to the skcipher API, allowing us to finally drop the > blkcipher code in the near future. > > Cc: Linus Walleij > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 464E9FA372A for ; Wed, 16 Oct 2019 13:01:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 158EA21848 for ; Wed, 16 Oct 2019 13:01:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="CFh/CBX3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="BAyU5dpl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 158EA21848 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z1+q5vKXnnKjtdZURaEidK4TeqfGOtJItAMGHT0Zl3w=; b=CFh/CBX3q79ED1 BHwWI2QOWBcegkNJfGwcGmLZvLwy2A8bJKwcHfYpwC5hUI7E3zybw1l1c3IxunM3zm99qHk9JflJn DXmw2vmfOmorWC1u5xoJYNm8G7tiNk+8JRmr4EDnR94x55Piu8NJtkAME7xcfAs+wTBaHH8x+zpgO 7ovDZ867PvWnziuaImowG1acvhlZUOPqb8Ip51TFD4ARitpzdVMW15VgS7sdf9sdTWNCppJdr2nTv YHo0l34kLW0ElUS3zjzD/G+cR1oQ2BYT5CeUvyufJvQdcN0C9ZicWGfsWuEepdb2fKKleu9VSFOst jBWkjympEHPMmXPcfh1Q==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKivt-00072s-5h; Wed, 16 Oct 2019 13:01:41 +0000 Received: from mail-qt1-x844.google.com ([2607:f8b0:4864:20::844]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iKivq-00072F-Bm for linux-arm-kernel@lists.infradead.org; Wed, 16 Oct 2019 13:01:39 +0000 Received: by mail-qt1-x844.google.com with SMTP id t20so30572000qtr.10 for ; Wed, 16 Oct 2019 06:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jnE8lBSLY3wNnqyY4G8WlYMgwsueTd/EoUksCVuD65E=; b=BAyU5dplrFadafcQV8wzsDzA1AsMPOKwhq1dJebWhm730gL3t0WiDFQHtMnfwYBf5T 4Q3eSK6Qq4ex1FD2/Q5f/ZdJRQSYJ1upnqdfq3Y9yHAx9LPaJFHmMZqahRBIUgFvjzG7 kyskQIhOvG9uaorqTV6HcCGjVmLrbZ2w962+QDCXzJ0IcaDaXG4uCWBfNqNI7CzZMpMm KfYK2f7WJ819fImO5EARWvL30f98knyldXDIOVxA13Gm0P7QnI/xQLDZmA5o0ZP+3CEZ 7FaSVGt6ptwWaA+rQepImmf1YT97mShCV2ZnEtliGHHwPrzqBbDrhpGaTFsBaPbXHvGt 4Rvw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jnE8lBSLY3wNnqyY4G8WlYMgwsueTd/EoUksCVuD65E=; b=nvPl3GEGdB2/daTSdKqNIRx7fqfsOAQwCHTI42yKXOZ0C0Y2qaIPPq71AlYtBEA50C f81OXtu2xYiEwYMHpKFtkIaIczBeuz6zoaYTJ+zX++QWrdGAsQezNe5qus/I5GjhJKjA kwMWsPiyceh8OjPN/GPCDcFfzuyuoH7cq7VmII6BoqjrUQ0pn0N2t0UoLYRwS9cmT3Va Nwywcab/OgFf8sgwakPqcZP7e+Ux8pzbTc/U2C/jNKlqCx0NntMzTGgSs0eM2n4JQ8tS lRUNCwgsIG57Ul2gvzKU5nu2hNpQ39BZbtMGXUsMu4tPaSwcg4s7RF0Wk2lfUVO+pKLR tNCg== X-Gm-Message-State: APjAAAWRC55/of8D17vPizaVAQyCgeAjG6XHLewXVi5c4ZZBozI6zCvl 7z3j0PJERJebrfNux6d4aIP0ahfX8cH9mKsCVSOq5g== X-Google-Smtp-Source: APXvYqwW5pJtOTNrnLrO03T1G9+Fcg/NuG1gN7wmIq4pJ8cxsc7jBg6TJfq5ooHjs4qjHlf1A3fmee9vr4kyD9kiJvg= X-Received: by 2002:ac8:2a38:: with SMTP id k53mr13105733qtk.387.1571230897593; Wed, 16 Oct 2019 06:01:37 -0700 (PDT) MIME-Version: 1.0 References: <20191014121910.7264-1-ard.biesheuvel@linaro.org> <20191014121910.7264-7-ard.biesheuvel@linaro.org> In-Reply-To: <20191014121910.7264-7-ard.biesheuvel@linaro.org> From: Linus Walleij Date: Wed, 16 Oct 2019 15:01:26 +0200 Message-ID: Subject: Re: [PATCH 06/25] crypto: ux500 - switch to skcipher API To: Ard Biesheuvel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191016_060138_409006_E0497D7F X-CRM114-Status: GOOD ( 11.00 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "David S. Miller" , Eric Biggers , linux-crypto@vger.kernel.org, Linux ARM , Herbert Xu Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Oct 14, 2019 at 2:19 PM Ard Biesheuvel wrote: > Commit 7a7ffe65c8c5 ("crypto: skcipher - Add top-level skcipher interface") > dated 20 august 2015 introduced the new skcipher API which is supposed to > replace both blkcipher and ablkcipher. While all consumers of the API have > been converted long ago, some producers of the ablkcipher remain, forcing > us to keep the ablkcipher support routines alive, along with the matching > code to expose [a]blkciphers via the skcipher API. > > So switch this driver to the skcipher API, allowing us to finally drop the > blkcipher code in the near future. > > Cc: Linus Walleij > Signed-off-by: Ard Biesheuvel Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel