All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Johan Hovold <johan@kernel.org>
Subject: Re: [PATCH v2] gpiolib: Disallow identical line names in the same chip
Date: Thu, 7 Jan 2021 11:45:02 +0100	[thread overview]
Message-ID: <CACRpkdZVw53K26hOQMfqfC+3=wdqm8kUDPdWrz-KRj1rh9ijYQ@mail.gmail.com> (raw)
In-Reply-To: <CAMpxmJUJnhc9HrZnb=qE5fpZ9e0Xo7VP-hTjdK-LHk0w6n3cMQ@mail.gmail.com>

On Wed, Jan 6, 2021 at 11:09 AM Bartosz Golaszewski
<bgolaszewski@baylibre.com> wrote:

> I can do it alright. But in the context of user-space I think this
> doesn't really change anything. DT users still can use non-unique
> names and libgpiod still has to account for that if the API is to be
> considered correct. Is this change really useful? How does it affect
> ACPI users that already define non-unique names?

For hardware description instances the problem remains: device tree
line-names and device properties can be non-unique.

What it solves is to enforce unique line names for gpio chips with
the struct gpio_chip .names array set to some names, that each
name in this array must be unique.

This happens for example when two USB FTDI converters
with the same GPIO lines are plugged in. Each chip can have a
"TX" line but it can no longer have two "TX" lines.

Yours,
Linus Walleij

  parent reply	other threads:[~2021-01-07 10:45 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-05  8:27 [PATCH v2] gpiolib: Disallow identical line names in the same chip Linus Walleij
2021-01-05 17:29 ` Andy Shevchenko
2021-01-05 23:23   ` Linus Walleij
2021-01-06 10:09     ` Bartosz Golaszewski
2021-01-06 13:34       ` Andy Shevchenko
2021-01-06 14:25         ` Bartosz Golaszewski
2021-01-06 16:14           ` Andy Shevchenko
2021-01-07 10:03         ` R: " Flavio Suligoi
2021-01-07 10:12           ` Andy Shevchenko
2021-01-07 13:12             ` R: " Flavio Suligoi
2021-01-08 10:40         ` Flavio Suligoi
2021-01-08 15:03           ` Andy Shevchenko
2021-01-07 10:45       ` Linus Walleij [this message]
2021-01-07 13:49         ` R: " Flavio Suligoi
2021-01-07 13:55           ` Geert Uytterhoeven
2021-01-08 14:39             ` R: " Flavio Suligoi
2021-01-08 14:41               ` Geert Uytterhoeven
2021-01-08 14:43                 ` R: " Flavio Suligoi
2021-01-08 15:05               ` Andy Shevchenko
2021-01-15 14:30                 ` Bartosz Golaszewski
     [not found]                   ` <CAHp75Vd017YY8HU-Ai7jnQEJ4PEgiU4VXn-jhLBKwERmsG_5MA@mail.gmail.com>
2021-01-15 17:31                     ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdZVw53K26hOQMfqfC+3=wdqm8kUDPdWrz-KRj1rh9ijYQ@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=andy.shevchenko@gmail.com \
    --cc=bgolaszewski@baylibre.com \
    --cc=geert+renesas@glider.be \
    --cc=johan@kernel.org \
    --cc=linux-gpio@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.