From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH 05/15] gpio: kill off set_irq_flags usage Date: Wed, 10 Jun 2015 14:43:00 +0200 Message-ID: References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-6-git-send-email-robh@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1433874401-27161-6-git-send-email-robh-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rob Herring Cc: Russell King , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "arm-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , Michael Hennerich , Alexandre Courbot , Ray Jui , Stephen Warren , Thierry Reding , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , bcm-kernel-feedback-list , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Michael Hennerich > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Ray Jui > Cc: Stephen Warren > Cc: Thierry Reding > Cc: linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > Cc: bcm-kernel-feedback-list-dY08KVG/lbpWk0Htik3J/w@public.gmane.org > Cc: linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Acked-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933296AbbFJMnP (ORCPT ); Wed, 10 Jun 2015 08:43:15 -0400 Received: from mail-ob0-f176.google.com ([209.85.214.176]:36719 "EHLO mail-ob0-f176.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932859AbbFJMnC (ORCPT ); Wed, 10 Jun 2015 08:43:02 -0400 MIME-Version: 1.0 In-Reply-To: <1433874401-27161-6-git-send-email-robh@kernel.org> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-6-git-send-email-robh@kernel.org> Date: Wed, 10 Jun 2015 14:43:00 +0200 Message-ID: Subject: Re: [PATCH 05/15] gpio: kill off set_irq_flags usage From: Linus Walleij To: Rob Herring Cc: Russell King , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "arm@kernel.org" , Michael Hennerich , Alexandre Courbot , Ray Jui , Stephen Warren , Thierry Reding , "linux-gpio@vger.kernel.org" , bcm-kernel-feedback-list , "linux-tegra@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Michael Hennerich > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Ray Jui > Cc: Stephen Warren > Cc: Thierry Reding > Cc: linux-gpio@vger.kernel.org > Cc: bcm-kernel-feedback-list@broadcom.com > Cc: linux-tegra@vger.kernel.org Acked-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: linus.walleij@linaro.org (Linus Walleij) Date: Wed, 10 Jun 2015 14:43:00 +0200 Subject: [PATCH 05/15] gpio: kill off set_irq_flags usage In-Reply-To: <1433874401-27161-6-git-send-email-robh@kernel.org> References: <1433874401-27161-1-git-send-email-robh@kernel.org> <1433874401-27161-6-git-send-email-robh@kernel.org> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Tue, Jun 9, 2015 at 8:26 PM, Rob Herring wrote: > set_irq_flags is ARM specific with custom flags which have genirq > equivalents. Convert drivers to use the genirq interfaces directly, so we > can kill off set_irq_flags. The translation of flags is as follows: > > IRQF_VALID -> !IRQ_NOREQUEST > IRQF_PROBE -> !IRQ_NOPROBE > IRQF_NOAUTOEN -> IRQ_NOAUTOEN > > For IRQs managed by an irqdomain, the irqdomain core code handles clearing > and setting IRQ_NOREQUEST already, so there is no need to do this in > .map() functions and we can simply remove the set_irq_flags calls. Some > users also set IRQ_NOPROBE and this has been maintained although it is not > clear that is really needed. There appears to be a great deal of blind > copy and paste of this code. > > Signed-off-by: Rob Herring > Cc: Michael Hennerich > Cc: Linus Walleij > Cc: Alexandre Courbot > Cc: Ray Jui > Cc: Stephen Warren > Cc: Thierry Reding > Cc: linux-gpio at vger.kernel.org > Cc: bcm-kernel-feedback-list at broadcom.com > Cc: linux-tegra at vger.kernel.org Acked-by: Linus Walleij Yours, Linus Walleij