From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D0A7DC433F5 for ; Tue, 28 Sep 2021 13:47:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B9990611C0 for ; Tue, 28 Sep 2021 13:47:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241015AbhI1NtK (ORCPT ); Tue, 28 Sep 2021 09:49:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S240988AbhI1NtI (ORCPT ); Tue, 28 Sep 2021 09:49:08 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4892AC061575 for ; Tue, 28 Sep 2021 06:47:29 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id x27so8166785lfa.9 for ; Tue, 28 Sep 2021 06:47:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=XQFP1mUhXKlHXI+xEmvDrSXbeLGnD4CLmXjgYseEqEruv9KrCC6FSc8Y5Ho4LjbDOX zC6snsJNUUz1wZImn8MwvqtBxmMBxpHhjrx+sD7movv4TlZPXtvtAREC+/yRiKmX0pue ++eKN5f+0dJcVxMLuJppLKf8ZQF/8jTKUtiroQPAE26FNLy3qV5NuZ4Mfmn9YaCTMPq7 nzwGakmqi86S8+l5vHWVzyPlqaDPjAMTD04P50HoQaOwSxjmCvIFwGP8TkCDq/Iqin0z nosD+DseVrciB0VXscUsdG8/7r83wCXEdGV3qDxxotWcJfScS76Tqa9v285icJA3aBNN Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=HLF4i+6RyniOanJrYtD5k09evfmtXI/QKTKYqYMZzDODlhofKH3ZgeplDHS5wHHuL6 rRDHbFpSrJ3yf0Pw7Ak97edUHBzCs0bnQV0/gasXq418DfCfq8ZfZ6YH3qbilZApi8kX BWjEjHAq5vmSt0uB8zQIu0tTo3DtBWRbv3uTIdrtdNmRpSB6QkLdEkDYcdgGVscRY9k9 psgsEseDzAy6LHr5xszgYftkGKBxx6HhsBgGS4fnndglyKse/ETtZBzmgPz01Xnz0j/k zV9Qj3w5YFzNDUT69jlJhT4Pni3hss+pGMRw2+Mxs+LQU65Uuzv2SndFcZJrPFV9SNiD b3iA== X-Gm-Message-State: AOAM533q/hxumMDnInM9ume9BStS9NSEXv1qvn2f1H1Qks3Ku1RRC4+s Pi6O/ELJ757lODxqeMV3XpvrrEbx4tFsdZjPPlAyrQ== X-Google-Smtp-Source: ABdhPJw2Fb4WlAdBMN6qf/ANOW7XfaZ4dwR3+5V+TQbap6YMXmbnt1TkRoKkuxS6/KOggTQZ6bWvGaBx1mJ0aeF2U9k= X-Received: by 2002:a19:f249:: with SMTP id d9mr5834936lfk.229.1632836846030; Tue, 28 Sep 2021 06:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:47:14 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing > --- > v1->v2: Remove the separate line of PTR_ERR(). Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 918D1C433EF for ; Tue, 28 Sep 2021 13:47:36 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 52104611C0 for ; Tue, 28 Sep 2021 13:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 52104611C0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=iSiyCCQyl8x1vKeFeGXc7iH5PXh7MryCG70DjQOS4fw=; b=0X4MD83aIBExb8 Ntcq5YaqTfEfNxC5eKoKU9b6Hlys0kdj341ZGLAK1Ig5LAhx5QBvP1Rbdrrqj+NGeD3/lzUJFdXO3 8LUT/ICjU/qmrZrVYHPU+h5tfOZwuCNn9VSY+guEtM5bqiC7VZ8D6IMQTNym5WVhcmsNMw/bZXmZo qBjQpC2cc4Y1l3/zt4cZ5XtfDUsOePu7wyP0w5ukPP5aSzugHRZ9DtbhDQoXYSbvmDiaVaaeAVLjP WvmrGjxsLGMAyJQtU6Bu543BCqvt1tHUcCNLwA+98o1xyx2cR+22+GHITzebapiKFozwzjxZxO1tI lopyERszCZs00tbENxdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSE-007NDn-GG; Tue, 28 Sep 2021 13:47:30 +0000 Received: from mail-lf1-x12b.google.com ([2a00:1450:4864:20::12b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSB-007NCN-RD for linux-amlogic@lists.infradead.org; Tue, 28 Sep 2021 13:47:29 +0000 Received: by mail-lf1-x12b.google.com with SMTP id b20so93349752lfv.3 for ; Tue, 28 Sep 2021 06:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=XQFP1mUhXKlHXI+xEmvDrSXbeLGnD4CLmXjgYseEqEruv9KrCC6FSc8Y5Ho4LjbDOX zC6snsJNUUz1wZImn8MwvqtBxmMBxpHhjrx+sD7movv4TlZPXtvtAREC+/yRiKmX0pue ++eKN5f+0dJcVxMLuJppLKf8ZQF/8jTKUtiroQPAE26FNLy3qV5NuZ4Mfmn9YaCTMPq7 nzwGakmqi86S8+l5vHWVzyPlqaDPjAMTD04P50HoQaOwSxjmCvIFwGP8TkCDq/Iqin0z nosD+DseVrciB0VXscUsdG8/7r83wCXEdGV3qDxxotWcJfScS76Tqa9v285icJA3aBNN Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=UupHuA+KWgp+zKpgLuNkAppdL3QRUhSvqsu0bKNqbG6YXJY/WAcU1mQulnGbbWhwqW vHiivCQygxMla5RtRQXIQwST72UJzhdIdE3MOhBzE0vMKOo87ccQ7WwBg4WWPvVE/QRA 3uv0gnLTQZGxk/SVXxBLXoNi4gTI9r0uWDtzZ2VBeN2nvhHQ0OcXfLfCiHu5pE0BuS4h FtOI9cbFnwL/SigcUHOO1roJBPFuwyb4ROFPonv+2hjihBxFt0+ldaO+pGHYFhL9hYW6 SK2YflwKdAJM6CeLuaNThV5NxhZLEtlc91LCswqQQQhekZk96pe5ZTljpTyMAxhLmHND P8VQ== X-Gm-Message-State: AOAM531dk7m6V7q/OAdm6Z3mq9GfwDicAHEZdfIaikX7TXzZIOSMppS5 X3CpWKxKq7pSztImc7+R9BAc7/gHnj3BuRM0esHdlQ== X-Google-Smtp-Source: ABdhPJw2Fb4WlAdBMN6qf/ANOW7XfaZ4dwR3+5V+TQbap6YMXmbnt1TkRoKkuxS6/KOggTQZ6bWvGaBx1mJ0aeF2U9k= X-Received: by 2002:a19:f249:: with SMTP id d9mr5834936lfk.229.1632836846030; Tue, 28 Sep 2021 06:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:47:14 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_064727_908228_95996EA8 X-CRM114-Status: GOOD ( 10.54 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing > --- > v1->v2: Remove the separate line of PTR_ERR(). Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CFDC1C433EF for ; Tue, 28 Sep 2021 13:47:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 909C8611BD for ; Tue, 28 Sep 2021 13:47:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 909C8611BD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=vM/LWZMzubqjxaIK4+kwAPXf9eCl1shmtYRzyDUoNhE=; b=LA507Z1ursZ8SL jbBjXIOWKYHTJ4nHyMLsDoq2Lqe25UKNx1mKMg0+mVbGSrg8i2hKhrw1Q9AmAuj5pTpluwdpDe0sV gJjUIBumIf6d4aiUF99H0fDV5xpkpuofwh+7YsEZ+j1cjOBI+CS6fJNAzDo3x0UheY2/aj6C8db8I TC+GElzORMFeBSIq1XARJ03hjyp756p7vdtSGgVZYkWfPSdU45VXKH59N7o1sitFLwJaGvbHSZoM6 ZRJKYxU84qcGGR2CO7eSDwVyHonV9g/N7H2NEkrYLwz+uue9fgEAVg3I4uPWJxUw48wf+DBMDHnqj tkJ2zYGJcbFCXxPtvE4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSQ-007NHn-P7; Tue, 28 Sep 2021 13:47:42 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSN-007NGH-Ui for linux-rockchip@lists.infradead.org; Tue, 28 Sep 2021 13:47:41 +0000 Received: by mail-lf1-x134.google.com with SMTP id b15so91537189lfe.7 for ; Tue, 28 Sep 2021 06:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=XQFP1mUhXKlHXI+xEmvDrSXbeLGnD4CLmXjgYseEqEruv9KrCC6FSc8Y5Ho4LjbDOX zC6snsJNUUz1wZImn8MwvqtBxmMBxpHhjrx+sD7movv4TlZPXtvtAREC+/yRiKmX0pue ++eKN5f+0dJcVxMLuJppLKf8ZQF/8jTKUtiroQPAE26FNLy3qV5NuZ4Mfmn9YaCTMPq7 nzwGakmqi86S8+l5vHWVzyPlqaDPjAMTD04P50HoQaOwSxjmCvIFwGP8TkCDq/Iqin0z nosD+DseVrciB0VXscUsdG8/7r83wCXEdGV3qDxxotWcJfScS76Tqa9v285icJA3aBNN Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=eM+kb9kHcdKwUCmVHMbzmn7NRo998KQRxP1CnplCopo6172inIPrugNkDTSHR68pAO Uk31y6zI9zkxWLuYGeCVjGSh0KUN7xidJTc3sffsmasgC/xxNNkMXD0UORldRNLZB/tr eV/sAgY3Kyhaf8UumIUATXUKkN7z7X/CxnS8xWl7Pi33i9Mu06u5d4lEx/9N10752tEw UPMYLm46KfS1sC9dptQ6SWGZUXCnPWKieb6qAM9HeM/9pN2hYaHj1swHfxpIoNFUFMup ucccsu7EJ49SyujLC0qbfwYvR8RiUucnmtJpiohdkVGTT9VuglyI3ij6MCqII5u06YaW jNyw== X-Gm-Message-State: AOAM530EiI4du6J7LKHADmFl+FaoamroXsJnbubuCqEpQnIuIccae2kD +DzhwIDYaA8MBF/W4JP6GIt/sLMBNEvilW4xzxHDjA== X-Google-Smtp-Source: ABdhPJw2Fb4WlAdBMN6qf/ANOW7XfaZ4dwR3+5V+TQbap6YMXmbnt1TkRoKkuxS6/KOggTQZ6bWvGaBx1mJ0aeF2U9k= X-Received: by 2002:a19:f249:: with SMTP id d9mr5834936lfk.229.1632836846030; Tue, 28 Sep 2021 06:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:47:14 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_064740_001719_405A4336 X-CRM114-Status: GOOD ( 10.75 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing > --- > v1->v2: Remove the separate line of PTR_ERR(). Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43D72C433F5 for ; Tue, 28 Sep 2021 13:49:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 146EB611EF for ; Tue, 28 Sep 2021 13:49:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 146EB611EF Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0QJ/hM/SpQdlkWICyQFjsFtMnWrZs0MyDwNcAfj1+j4=; b=IXHf27KGJxcRSl v7qeQdJ+Rhm3GCLj+xxA9XOO+4kWZ2gd89QNWV4Qw49otC+jvhsl6XdM2Vaj82A8yO8HYF4HLn2mT 0VJiA4ecHGh93W5q2DLXHIdX5LqIJRe7D3Fb09t6EshjjiYV43OrLkQGoDpQnH8W7Stg1VD/He0sI 8QAplVh+Y1kTMgMj5DOEA0f8GBibkiEeSKJRr/HbBs3kdZsico1dfA2iniXOJSoPQVZu9GmBCqKbx d2Wom3CCwQoqdjjX1AM8oIqYCepQ/PdQIycfCSnvRsKqrFXA+xzWC9K5rMvqZO1196kruIRzwEEHl NvOz3g9ldtMdWBKENqgA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSG-007NE4-Dl; Tue, 28 Sep 2021 13:47:32 +0000 Received: from mail-lf1-x132.google.com ([2a00:1450:4864:20::132]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVDSB-007NCR-U5 for linux-arm-kernel@lists.infradead.org; Tue, 28 Sep 2021 13:47:29 +0000 Received: by mail-lf1-x132.google.com with SMTP id i4so92802430lfv.4 for ; Tue, 28 Sep 2021 06:47:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=XQFP1mUhXKlHXI+xEmvDrSXbeLGnD4CLmXjgYseEqEruv9KrCC6FSc8Y5Ho4LjbDOX zC6snsJNUUz1wZImn8MwvqtBxmMBxpHhjrx+sD7movv4TlZPXtvtAREC+/yRiKmX0pue ++eKN5f+0dJcVxMLuJppLKf8ZQF/8jTKUtiroQPAE26FNLy3qV5NuZ4Mfmn9YaCTMPq7 nzwGakmqi86S8+l5vHWVzyPlqaDPjAMTD04P50HoQaOwSxjmCvIFwGP8TkCDq/Iqin0z nosD+DseVrciB0VXscUsdG8/7r83wCXEdGV3qDxxotWcJfScS76Tqa9v285icJA3aBNN Ec1g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zwVENlJtRAi6Ax59HxxFqFtBJgRbm8ce1Id+5WhoWL8=; b=ZHqhmdZ/X0fA3L8BJZ80C6S4YTfZgUAv7hyXHYgSEX9ImACDICzhWPF9QgpVv1okf5 17RefEps0PfNc2Jdi63W5qV56EanEkScsqq9D0CMnir7RSbjp7Vh7rqXTnmzL3kyWMGJ KHMSbfvY7qgjc3EwHaEUn5jFy6PhSyUbeqSt3+JaO4eUUJDfKP2EB19szprFMAcurJZl dBu/w2GnR/QuGq/zgdobJexMqm8JIkOYmIdmiSHt+ouL723fl7tOjXMphAO96XouJnnf 6UpsTVAtmGSAgAjSm7Jn0qwWUqcfCvP9TDmeLKo5QnG4/tzYSo0BKtB/03Hhnr1ygk8D mmKA== X-Gm-Message-State: AOAM532vRMfTIv/1Bzdan+gOxw5rSsvlbJWOfpIS/eHmkfKeGbqbhyo6 AWfRSHWvGPAmaKZ0NCgTCK1J/sKT9VO3A1vEBasXmQ== X-Google-Smtp-Source: ABdhPJw2Fb4WlAdBMN6qf/ANOW7XfaZ4dwR3+5V+TQbap6YMXmbnt1TkRoKkuxS6/KOggTQZ6bWvGaBx1mJ0aeF2U9k= X-Received: by 2002:a19:f249:: with SMTP id d9mr5834936lfk.229.1632836846030; Tue, 28 Sep 2021 06:47:26 -0700 (PDT) MIME-Version: 1.0 References: <20210928013621.1245-1-caihuoqing@baidu.com> In-Reply-To: <20210928013621.1245-1-caihuoqing@baidu.com> From: Linus Walleij Date: Tue, 28 Sep 2021 15:47:14 +0200 Message-ID: Subject: Re: [PATCH v2 1/9] iio: adc: ab8500-gpadc: Make use of the helper function dev_err_probe() To: Cai Huoqing Cc: Jonathan Cameron , Lars-Peter Clausen , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Vladimir Zapolskiy , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Andy Gross , Bjorn Andersson , Heiko Stuebner , Linux ARM , linux-iio , linux-kernel , "open list:ARM/Amlogic Meson..." , MSM , "open list:ARM/Rockchip SoC..." X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210928_064727_978202_10D8F4DA X-CRM114-Status: GOOD ( 12.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Sep 28, 2021 at 3:36 AM Cai Huoqing wrote: > When possible use dev_err_probe help to properly deal with the > PROBE_DEFER error, the benefit is that DEFER issue will be logged > in the devices_deferred debugfs file. > Using dev_err_probe() can reduce code size, and the error value > gets printed. > > Signed-off-by: Cai Huoqing > --- > v1->v2: Remove the separate line of PTR_ERR(). Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel