From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28562C43217 for ; Mon, 3 Jan 2022 11:14:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229798AbiACLOL (ORCPT ); Mon, 3 Jan 2022 06:14:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52308 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230427AbiACLOK (ORCPT ); Mon, 3 Jan 2022 06:14:10 -0500 Received: from mail-oo1-xc35.google.com (mail-oo1-xc35.google.com [IPv6:2607:f8b0:4864:20::c35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2149FC061792 for ; Mon, 3 Jan 2022 03:14:10 -0800 (PST) Received: by mail-oo1-xc35.google.com with SMTP id q14-20020a056820028e00b002da9808b90fso10610152ood.7 for ; Mon, 03 Jan 2022 03:14:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7rQyh8qoFCVkTYCJoBUAa1eDCuPTeVpt8hM9QR+kGFw=; b=lKp35sPLwfzzeo99ncy7I6kAbhlSDACT627ryf53mi4HRHQzMsBGXTG9q7DgSIQ5dd du+t0EgHMYNnZCwdGxmiioX7UQGukUUf2MZlOixbz8H7j9AnAMXlY3CsU7D9T3fGCPOe urPnWA2dDAB5GbwXvo+pGBEXUXwigVxVQwGRjwWv0stsQSVtWm/6oROJiOYvMyVegSP1 q27lKF6e8DxfUnf2oVRK1FAXd0QsxsOE/XJ12oQ6APghvll7UkPqeOAviQsq37DxeA/2 ZvVI3wGDXw7g5BPCP3FTKxrfr54jzIVKXSbV0GG+++jj+QHjVJ5m4aaz4ZmjYmFLlSej cscg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7rQyh8qoFCVkTYCJoBUAa1eDCuPTeVpt8hM9QR+kGFw=; b=Jmc4IMD/iAMWgOyQxuk8LpzRbdgi4ZqV4JrjEV7a2N3YxP3vk5/rLhkIAwvvdvoUBc qlJScGEhVwwvz32TZPYLAYNiNOYk2E94fQWlaAdStpPYWll8S0doJ5c9H/nyBXD/ks73 nm2mWCym8VUcvQDR7whvQCzUbfp4ry0v52uYwraY3H7sRd/uyCd4AxYTzidhVlZQsjlV a6wd2seeQUzFNB3450xce/HWHokPD7QNNCqGPFozyUkoj4a4WFeJbTqdbHpo1pd9zqkA HjyHRkn7L8At9Yf6pzg964eSpLbimz53yUNI0rPJh7IkZW2QfWmwHiuutAvKOyfiBuLm TyZQ== X-Gm-Message-State: AOAM532U6h50UccQBLZzvVjY/zWwTCjUdJ8GVMmUBQCaNsXO+gf2Lpgv PWOuhOkAGRk9/arbSLiqdY65l/IIXhEstHIsFgo7UA== X-Google-Smtp-Source: ABdhPJxdQREDfbU4atMQgwtR/EJliSw5ut9txpzh8stIkU2N5ZJ8E4DugcU627Y8rFUiy4W9qw5htr1PorlsLDd/rLk= X-Received: by 2002:a4a:e155:: with SMTP id p21mr28047376oot.84.1641208449094; Mon, 03 Jan 2022 03:14:09 -0800 (PST) MIME-Version: 1.0 References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-8-marcan@marcan.st> <46c09b62-d50f-fd2e-3eb4-ed4b643eef4a@marcan.st> In-Reply-To: <46c09b62-d50f-fd2e-3eb4-ed4b643eef4a@marcan.st> From: Linus Walleij Date: Mon, 3 Jan 2022 12:13:56 +0100 Message-ID: Subject: Re: [PATCH 07/34] brcmfmac: pcie: Read Apple OTP information To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Mon, Jan 3, 2022 at 6:52 AM Hector Martin wrote: > On 2022/01/02 14:38, Linus Walleij wrote: > > On Sun, Dec 26, 2021 at 4:37 PM Hector Martin wrote: > > > >> On Apple platforms, the One Time Programmable ROM in the Broadcom chips > >> contains information about the specific board design (module, vendor, > >> version) that is required to select the correct NVRAM file. Parse this > >> OTP ROM and extract the required strings. > >> > >> Note that the user OTP offset/size is per-chip. This patch does not add > >> any chips yet. > >> > >> Signed-off-by: Hector Martin > > > > Overall looks fine! > > > >> + const char *chip_params; > >> + const char *module_params; > > > > This variable name "module_params" is a bit confusing since loadable > > kernel modules have params... > > > > Can we think of another name and just put a comment that this > > refers to the WiFi module building block? > > > > Sometimes people talk about SoM:s (system-on-modules), so > > maybe som_params or brcm_som_params? > > > > Yours, > > Linus Walleij > > > > How about board_params, since we're already calling those things boards > elsewhere in the driver? That could refer to the board of a standalone > module, or an integrated board, which should cover all cases. Fair enough, go for board_params! Yours, Linus Walleij