From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 752C6C4338F for ; Wed, 11 Aug 2021 13:29:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5433F60724 for ; Wed, 11 Aug 2021 13:29:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231459AbhHKNaM (ORCPT ); Wed, 11 Aug 2021 09:30:12 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43088 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230479AbhHKNaL (ORCPT ); Wed, 11 Aug 2021 09:30:11 -0400 Received: from mail-lj1-x229.google.com (mail-lj1-x229.google.com [IPv6:2a00:1450:4864:20::229]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1A62BC061765 for ; Wed, 11 Aug 2021 06:29:48 -0700 (PDT) Received: by mail-lj1-x229.google.com with SMTP id n6so4568162ljp.9 for ; Wed, 11 Aug 2021 06:29:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+X0yTtKHNC1QHiC4TdwRsI4TRqekknXSqUNI6kHT6+s=; b=rTvOhlGAR1MHxp0c1gldy8giEP85iSPRRdinf6tH+tLYQ86Fl8DyUM01b1LBZMwK8E mCjkgQmMoDyfeqmK3/ZPFrKfGLd8p+rU+1V/BMwYe9g+T1exM9WHea8yPcBvc4gkXduT AKakVfoO4XmhlGRzghQfpr8+dS2Z1WAQsafYgVPb3YIqwFCOyc18MVM2EPeeoocyk/xb nICuC1x6PMJGytElpyBqP3ITl9sO8QjDCaC3cH1Z/sJfchPwZyVqv9wx+h4PBGQdcumy ukoUvmWp2hWd5LV8XZaxCxzKML078/pO21e3vXJe82K7RWh8TNQp9GS93eUYy3PuGMUX Co8g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+X0yTtKHNC1QHiC4TdwRsI4TRqekknXSqUNI6kHT6+s=; b=AyQ3SF4Ym9JD9m1r5hMoHt4/ix284dHJHaDgfMaURljxd2P4zjRHU0oW/gfZPkg0LC /bEwOPE+yGuRrz+vx4UjTlAJUGQIZliCm6lcw1D+zIc0h+Bbew00ZZDsGr05yeC7fyud sIymmiOyXRnvUIoxwT+3Jri+1LKjCy48rS5LmYSPmmrDZdqyy8njJ7iqgPtsNERG8egZ mgLfISmnVqeXn56xIdXhs1XY7gznhM1RxgNtcQg8EUb4JkQlxZl7P9W/MuAbIlVZpCMf BXwr83KlV6AjVJmKkH1MKjn6gWl/TLSs7j3EHiZBrkYbP/8jCaIJaJqy8sjJOV9jOkfE xxsQ== X-Gm-Message-State: AOAM5337g1hTXhzwfWyGpX+jLGUkREPXwA/vbjlOc2eGQ2faa919SdLp zC6Fn4geSf57WFlMdkwTQfKBS/RjiDrNNVkOWRws+w== X-Google-Smtp-Source: ABdhPJwoljr3xOO+hMnf7G8n6BLUxTzr+3BexgpppvcpXg5N9o1tS91z4t/AWOEriSw8g9JycXkWLnzsm8guLA7TPYk= X-Received: by 2002:a05:651c:1318:: with SMTP id u24mr23397688lja.200.1628688586450; Wed, 11 Aug 2021 06:29:46 -0700 (PDT) MIME-Version: 1.0 References: <20210810131356.1655069-1-vladimir.oltean@nxp.com> In-Reply-To: <20210810131356.1655069-1-vladimir.oltean@nxp.com> From: Linus Walleij Date: Wed, 11 Aug 2021 15:29:35 +0200 Message-ID: Subject: Re: [PATCH v2 net-next 0/4] DSA tagger helpers To: Vladimir Oltean Cc: netdev , Jakub Kicinski , "David S. Miller" , Andrew Lunn , Florian Fainelli , Vivien Didelot , Vladimir Oltean , DENG Qingfang , John Crispin , Sean Wang , Landen Chao Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Tue, Aug 10, 2021 at 3:14 PM Vladimir Oltean wrote: > The goal of this series is to minimize the use of memmove and skb->data > in the DSA tagging protocol drivers. Unfiltered access to this level of > information is not very friendly to drive-by contributors, and sometimes > is also not the easiest to review. > > For starters, I have converted the most common form of DSA tagging > protocols: the DSA headers which are placed where the EtherType is. > > The helper functions introduced by this series are: > - dsa_alloc_etype_header > - dsa_strip_etype_header > - dsa_etype_header_pos_rx > - dsa_etype_header_pos_tx > > This series is just a resend as non-RFC of v1. The series: Reviewed-by: Linus Walleij Yours, Linus Walleij