From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 240C5C433F5 for ; Tue, 4 Oct 2022 07:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229578AbiJDHKP (ORCPT ); Tue, 4 Oct 2022 03:10:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53534 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229517AbiJDHKN (ORCPT ); Tue, 4 Oct 2022 03:10:13 -0400 Received: from mail-ed1-x531.google.com (mail-ed1-x531.google.com [IPv6:2a00:1450:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 71D2C16594 for ; Tue, 4 Oct 2022 00:10:12 -0700 (PDT) Received: by mail-ed1-x531.google.com with SMTP id m3so17574564eda.12 for ; Tue, 04 Oct 2022 00:10:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=jAEhfX51bk79HNZmAskhx8y8O249VqSQLorGUrCt9VI=; b=A1auwzx0uLK8UKHFdIApRlLeNu3gD+H4KIUo7baJve+uy+94IrQBWpymUVmcMcs52z doE1PqANnuZNcCQ4dHVf6WQOMFD5n/MlN8FPTXq/km0h+FSiwnBGYelG0iwAe3rjC9wB 63OP6WbW63KTMSHzzWzVNbVAMpo6LXZFNlMvff0torOxIOJvOrhZ0YQJmH90vzqOmdgO ycV8i2AP9amN/nr5RjWwabltRy9yn91i93oqrk9aIL6Ncxwrhxef+ewXKQbb5lUItFTk cPWPrnQoVO0R4sugC8SKvKdxO4USMCmwvS2IpXxU9Cf2fC5iHCrwvRXVSo9ZIVi3NN/O AXjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=jAEhfX51bk79HNZmAskhx8y8O249VqSQLorGUrCt9VI=; b=Ic5iV1UR2Oe8FWCn0NRMQEw5nVolMiEafBFNvo2qx+x3UvIa2BHM1HViiBmZi+y/La a1t352bCV8WciS1ttCnEN2Czytk9Tt8YfUBp1Y+1xsnIdVwaKBzfXgSEyXKktRbmq7Jv 8bDo9G4LP877TEP4+zs+uSfHCSnIEH/Eu+q9UcHItzRSdWrDKYAq0nFVpfw9wrgjtBYR Fln1vJfznUfm0Umyc+sanIgzZTGbpvInHeESNooAXgqeyHgtSw3aagt2k5riadcJ1k8u lMcpF+GBZg9WLYZ6hIv4ruGZ/rzPZYlQ2HDUjosFjApeTsIWR06nv0G+aa/YUEBPY+Nu xXTg== X-Gm-Message-State: ACrzQf2W+Mjaw1Wh2n8FFk4wj+5+3rojIrQidyNmD1K7tsDP+AJxOPiD 0CRmEYXQwjcUWF0PI2zO7LafWOjIem/wMoAyxENq2ZSz/zY= X-Google-Smtp-Source: AMsMyM6hss1UiKoLSMTg9gp6lkoG0Lz+pagUMg5EYZh5zarPq1XB0z9E+IGEdLm6G/ePxgVs85xrcvhlyXib21DwNuw= X-Received: by 2002:aa7:cd4f:0:b0:458:6077:c3ac with SMTP id v15-20020aa7cd4f000000b004586077c3acmr18719031edw.32.1664867411023; Tue, 04 Oct 2022 00:10:11 -0700 (PDT) MIME-Version: 1.0 References: <20220917024634.1021861-1-yangyingliang@huawei.com> In-Reply-To: <20220917024634.1021861-1-yangyingliang@huawei.com> From: Linus Walleij Date: Tue, 4 Oct 2022 09:09:59 +0200 Message-ID: Subject: Re: [PATCH -next v2 1/2] pinctrl: ocelot: add missing destroy_workqueue() in error path in ocelot_pinctrl_probe() To: Yang Yingliang , Horatiu Vultur Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, p.zabel@pengutronix.de Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Sat, Sep 17, 2022 at 4:39 AM Yang Yingliang wrote: > Add the missing destroy_workqueue() before return from ocelot_pinctrl_probe() > in error path. > > Fixes: c297561bc98a ("pinctrl: ocelot: Fix interrupt controller") > Signed-off-by: Yang Yingliang > --- > v2: > move alloc_ordered_workqueue() after ocelot_pinctrl_register(). Horatiu does this v2 look like you want it? Reviewed-by? Yours, Linus Walleij