All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Grygorii Strashko <grygorii.strashko@ti.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Chris Gorman <chrisjohgorman@gmail.com>
Subject: Re: [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically
Date: Mon, 9 Oct 2017 21:57:58 +0200	[thread overview]
Message-ID: <CACRpkdZe6uKqWo6hg4ROjiv4YUWyW0Upy4s6UCMH4ri3v3PF5g@mail.gmail.com> (raw)
In-Reply-To: <aabd3920-7170-3883-58a8-695d15664150@ti.com>

On Mon, Oct 9, 2017 at 8:10 PM, Grygorii Strashko
<grygorii.strashko@ti.com> wrote:

> At the moment it was merged there were no user of irq_base except gpio-mockup.c.

OK I feel calmer.

> And actually there are shouldn't as calling irq_create_mapping() in cycle
> will not guarantee sequential Linux IRQ numbers allocation.

Yeah. I always felt that was bad practice.

But we should really kill off that irq_base member from gpio_chip. It looks
dangerous to have arond.

Yours,
Linus Walleij

  reply	other threads:[~2017-10-09 19:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-21 16:49 [RFT PATCH v2] gpiolib: allow gpio irqchip to map irqs dynamically Grygorii Strashko
2017-07-21 16:49 ` Grygorii Strashko
2017-08-01  7:52 ` Linus Walleij
2017-08-01  8:03   ` Jerome Brunet
2017-08-01 18:27     ` Grygorii Strashko
2017-09-15  8:26       ` Jerome Brunet
2017-09-21 11:41         ` Linus Walleij
2017-10-05 10:59           ` Marc Zyngier
2017-08-01  9:53   ` Bartosz Golaszewski
2017-09-28  8:33 ` Mika Westerberg
2017-09-28 14:02   ` Grygorii Strashko
2017-09-28 14:02     ` Grygorii Strashko
2017-09-28 14:26     ` Mika Westerberg
2017-10-08  0:27   ` Linus Walleij
2017-10-09 18:10     ` Grygorii Strashko
2017-10-09 19:57       ` Linus Walleij [this message]
2017-10-09 22:17         ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkdZe6uKqWo6hg4ROjiv4YUWyW0Upy4s6UCMH4ri3v3PF5g@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=chrisjohgorman@gmail.com \
    --cc=grygorii.strashko@ti.com \
    --cc=jbrunet@baylibre.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mika.westerberg@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.