From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38F7CC433EF for ; Sun, 19 Sep 2021 19:33:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 19BE960F36 for ; Sun, 19 Sep 2021 19:33:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231721AbhISTfJ (ORCPT ); Sun, 19 Sep 2021 15:35:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231633AbhISTfI (ORCPT ); Sun, 19 Sep 2021 15:35:08 -0400 Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3DD7DC06175F for ; Sun, 19 Sep 2021 12:33:42 -0700 (PDT) Received: by mail-lf1-x133.google.com with SMTP id u8so6524431lff.9 for ; Sun, 19 Sep 2021 12:33:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=QttFeThvsBKoZD/JJSZUGcnMxxYovmSAcPaoFut8GAFLHLvS3IsTDF2HdKr15LPN9G dQm8BvfUECw8XeDSv0m1SrsY5DNjsXO5PhGldlbFPGCmZzLQf5f4vh/pFDbjSFvStSof bsHKoK1XDB+jm11SUX3KQZcdBcwrIoJ9zJT7u7lZPKBBvscShFCJI06s8Nc+Cbx5aPk8 FLEsvge3r+dLL5c8eRyGYCib3lpmVuGEyJOQApoo1BXqM0ORTQDvz1f9o1dc6g3fwHqJ sn8PMwx45/tPsdybUcEWbNcsQsIJx3OV8yTmV/E9eKunE7RJcgj2CWzrCIKxFp+jpbCh 0Qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=BA8KXdMFX8ystFAEgOAX7bLy5Ylel24RtZpWvPqGNX3JilnJ1/viRuZZX0GvZQGele K9YNZPvpJOIp8YE1ZXgejkJMZ9t5qtnpDeUsuTxEM5rJYls0vaEi/shth6eeV2A89HoG xSyu3x/v0Sl8FxAJnHd8QRSUQvsIy/ntvvI6zw3yjxlprFyK7vAvjS+sHlr0IM+Wg3bX neguk4udBhynJfFY6w7vDywAQJ6bLOlmPEsBKW82Fq+VgDLEZrsXwcATewNImjvK5DZk NGc6/FTsg2/+GxHTSxzooUo3APSThIsAfw1T0fhX/8a5JHzssneMbXXl1K2nv65UD7CU owsg== X-Gm-Message-State: AOAM530TefDpKwmbg0eC3Q259bWofr4xAr82+Gkmhhw4RBAeXVo/B2sQ 5Hsg+TIMxEDgrwf+CoAdKWbhRqvKQANr9+i7IUvuYQ== X-Google-Smtp-Source: ABdhPJzzLzWh+7RmTbVSRRZX4HMrJdrIe97VWJWO+B8mpVmZZvCUE6yjBm+7MlNH7sV61wIx/Rt//VfW14RHiA0ZsuQ= X-Received: by 2002:a05:6512:10cb:: with SMTP id k11mr6357275lfg.72.1632080020480; Sun, 19 Sep 2021 12:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-5-zhiyong.tao@mediatek.com> <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> In-Reply-To: <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> From: Linus Walleij Date: Sun, 19 Sep 2021 21:33:29 +0200 Message-ID: Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 To: "zhiyong.tao" Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao wrote: > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote: > > > > > + if (!found) { > > > > > + dev_err(hw->dev, "Not support rsel value %d Ohm > > > > > for > > > > > pin = %d (%s)\n", > > > > > + arg, desc->number, desc->name); > > > > > + return -EOPNOTSUPP; > > > > > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be > > > > network > > > > related. > > > > > > > > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP is > > > not > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch. > > > > The context surrounding this warning seems to be that ENOTSUPP is > > hard > > for userspace to understand. AFAIK the return code here does not get > > passed to userspace? And the pinctrl core does check for EINVAL or > > ENOTSUPP, so I think this is a valid use case. > > > > Linus? > > > > Hi Linus, > > Do you have some suggestion for the warning issue? Ignore the warning. We use this code in the pinctrl subsystem. The pinctrl subsystem has no userspace API so that is certainly not a problem. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3300EC433EF for ; Sun, 19 Sep 2021 19:34:13 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E545760F6B for ; Sun, 19 Sep 2021 19:34:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E545760F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p68LdQljCiHEDZHwJY8QQ8+jLrwC2UnN4SxVd4DYnmY=; b=g3apwfwQwHn41T 75WD0UATYIkK4dKKJ5Sc3sunAqOJp4Ghukfw55hi3Z/3Cqmz/WPLeW3BxgTz8b3v3bD53Y0fcEM8x n2g39kBjw3E5fMiLvw2WVQQRmkRGeaoSFFER8Y2jXoB17TzUml1mFQVjBe+PV70GnPLnn58oKNrXP zM1T5JdlByUvaxn6JQBG9k6WKukFCNj1BNx1+nGsKs4yg/dYUQfo3aqn2YHDvU/zUGRBTmxUtSDtE vixnmaI5iwTbsIskH8b9Vwnmr7CnMQ+KCV/V03fnAAcwGdLsfXWNT1QEmq3SPa54gq8uJUHUGhCYw rQ9/Otpf1e4pGIX2ozEA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS2Zc-0006YU-DP; Sun, 19 Sep 2021 19:34:00 +0000 Received: from mail-lf1-x134.google.com ([2a00:1450:4864:20::134]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS2ZQ-0006Ww-CG for linux-mediatek@lists.infradead.org; Sun, 19 Sep 2021 19:33:49 +0000 Received: by mail-lf1-x134.google.com with SMTP id x27so57900312lfu.5 for ; Sun, 19 Sep 2021 12:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=QttFeThvsBKoZD/JJSZUGcnMxxYovmSAcPaoFut8GAFLHLvS3IsTDF2HdKr15LPN9G dQm8BvfUECw8XeDSv0m1SrsY5DNjsXO5PhGldlbFPGCmZzLQf5f4vh/pFDbjSFvStSof bsHKoK1XDB+jm11SUX3KQZcdBcwrIoJ9zJT7u7lZPKBBvscShFCJI06s8Nc+Cbx5aPk8 FLEsvge3r+dLL5c8eRyGYCib3lpmVuGEyJOQApoo1BXqM0ORTQDvz1f9o1dc6g3fwHqJ sn8PMwx45/tPsdybUcEWbNcsQsIJx3OV8yTmV/E9eKunE7RJcgj2CWzrCIKxFp+jpbCh 0Qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=Z5f2yJVGyUpahbXanN1DemaAamGzuA3EZsHDGZdHlQlfwA2BBDvfS07lu1DSMtdTov ZjCl3qyqXOzYYqokODpPeeK9B87HWyWUaeaPhUCntcH9opjCVXa6gj4uKk9/efTsmyaa s0te0LhwY3NbJJ4inYp+Q8RJzUs9WsmmstOqBJtD7Xhf0XCb/mqI6IAmVYt9gIgHzNtA cbENFa3GxoHF90hWD4A6xbHDr+JEjV/fKLwnNBk13mHnCaVX3o+EG33Lo+P9+1tXUqEC dTYadSrtWeKTjpJx3zqJfsAgYM2MlsaP/xuaalBdUSTupkzNMuEtsV3e7NNaAu9mDflw XW3Q== X-Gm-Message-State: AOAM530nCDVpJgAfgIafU5xx0ce6OhGXOvRDZYodwbI58FT2tPHSgyx8 9+xc6yY4lrIMCODsPnnPTVhUVtQUCrBZKl/yuEkKwg== X-Google-Smtp-Source: ABdhPJzzLzWh+7RmTbVSRRZX4HMrJdrIe97VWJWO+B8mpVmZZvCUE6yjBm+7MlNH7sV61wIx/Rt//VfW14RHiA0ZsuQ= X-Received: by 2002:a05:6512:10cb:: with SMTP id k11mr6357275lfg.72.1632080020480; Sun, 19 Sep 2021 12:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-5-zhiyong.tao@mediatek.com> <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> In-Reply-To: <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> From: Linus Walleij Date: Sun, 19 Sep 2021 21:33:29 +0200 Message-ID: Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 To: "zhiyong.tao" Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_123348_488732_B4A3F310 X-CRM114-Status: GOOD ( 22.90 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao wrote: > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote: > > > > > + if (!found) { > > > > > + dev_err(hw->dev, "Not support rsel value %d Ohm > > > > > for > > > > > pin = %d (%s)\n", > > > > > + arg, desc->number, desc->name); > > > > > + return -EOPNOTSUPP; > > > > > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be > > > > network > > > > related. > > > > > > > > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP is > > > not > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch. > > > > The context surrounding this warning seems to be that ENOTSUPP is > > hard > > for userspace to understand. AFAIK the return code here does not get > > passed to userspace? And the pinctrl core does check for EINVAL or > > ENOTSUPP, so I think this is a valid use case. > > > > Linus? > > > > Hi Linus, > > Do you have some suggestion for the warning issue? Ignore the warning. We use this code in the pinctrl subsystem. The pinctrl subsystem has no userspace API so that is certainly not a problem. Yours, Linus Walleij _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87510C433F5 for ; Sun, 19 Sep 2021 19:36:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5096360F6B for ; Sun, 19 Sep 2021 19:36:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5096360F6B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4mf4AiGt2kmxZCjxh3NomVBjavy/9fRDy7bDgTxmYDE=; b=3z+YFLmDyPagQc 6+4QFFlmSJ6+9hr7X+XEXWoxTE/tlWLYclqzJ9f7LgRE7dsElvkk+oznmdy80hc9Sqk0CQlXpeNJk cnHOdnlFTmIK74AYNHZCjIAxJxMgSnH8F4fHld1dbQO9UUv/67PYW05eVuGZ8S8gL6jWS7zZNgfaR J9JBfyCauSCLzb3LHPAq5fQ6Z1ZaRvGuu57OxHXB9urn6DXKZjoQsh10SiwE2TVj6/V87flUmEeP+ QyILXb4dpbmULFDIIMwsD8xd5v2i0vqL4TuM2uOhiyauCAyXjerSuQaEsr/9HLIUhCOGmRh78aPaq rGaMARa/qsMorms4PRYg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS2ZT-0006Xv-Ib; Sun, 19 Sep 2021 19:33:51 +0000 Received: from mail-lf1-x12e.google.com ([2a00:1450:4864:20::12e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mS2ZQ-0006Wx-CB for linux-arm-kernel@lists.infradead.org; Sun, 19 Sep 2021 19:33:49 +0000 Received: by mail-lf1-x12e.google.com with SMTP id e15so19493592lfr.10 for ; Sun, 19 Sep 2021 12:33:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=QttFeThvsBKoZD/JJSZUGcnMxxYovmSAcPaoFut8GAFLHLvS3IsTDF2HdKr15LPN9G dQm8BvfUECw8XeDSv0m1SrsY5DNjsXO5PhGldlbFPGCmZzLQf5f4vh/pFDbjSFvStSof bsHKoK1XDB+jm11SUX3KQZcdBcwrIoJ9zJT7u7lZPKBBvscShFCJI06s8Nc+Cbx5aPk8 FLEsvge3r+dLL5c8eRyGYCib3lpmVuGEyJOQApoo1BXqM0ORTQDvz1f9o1dc6g3fwHqJ sn8PMwx45/tPsdybUcEWbNcsQsIJx3OV8yTmV/E9eKunE7RJcgj2CWzrCIKxFp+jpbCh 0Qnw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rwG0cyjmLoqo6KWJPkoebUUL/eGcFniLZjCwbXyHXbY=; b=lOOrE3KBng6idEMNlbA2QbOJ26ZZvNbNlDH0CFwKwKCJRJC+a7UIobj4DxbYliVX9R 9ZKYEVOyOzBWjFWbILCFmQGDw/bwiBGc8Po0gcao7/hxz1CLj6BoNaY+Uwu0pGEdDeSG 3+4ZVWpRL1zigKo2w+3ZMR42C5folE8CcCEMDIpH592+pUyjzrvUNf243dNNmIDZrmBk S6C+lfHtFcmMBP+/L7FqeCqSqvvioUVyFtTeZfX392kBgyDKEVxWuDFrdLAFx6jcTBNG gWW03DWuqepRYoP60LM0Xu6Ld5KghKnVtg5+/BH5001tR6kjF2Phie3WtNa9TCDxRGFF Mfhw== X-Gm-Message-State: AOAM531PeetYXAiLd7pUhdMwLK2XKze4FabEqROfPOoxVO0UHc9LEFF5 KP828EeaWHRorX9lfA+98G2xprL46xZbtrGqCazSqw== X-Google-Smtp-Source: ABdhPJzzLzWh+7RmTbVSRRZX4HMrJdrIe97VWJWO+B8mpVmZZvCUE6yjBm+7MlNH7sV61wIx/Rt//VfW14RHiA0ZsuQ= X-Received: by 2002:a05:6512:10cb:: with SMTP id k11mr6357275lfg.72.1632080020480; Sun, 19 Sep 2021 12:33:40 -0700 (PDT) MIME-Version: 1.0 References: <20210830003603.31864-1-zhiyong.tao@mediatek.com> <20210830003603.31864-5-zhiyong.tao@mediatek.com> <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> In-Reply-To: <74a3a96745e93c5a2392b8a39822c872fd468466.camel@mediatek.com> From: Linus Walleij Date: Sun, 19 Sep 2021 21:33:29 +0200 Message-ID: Subject: Re: [PATCH v11 4/4] pinctrl: mediatek: add rsel setting on MT8195 To: "zhiyong.tao" Cc: Chen-Yu Tsai , Rob Herring , Mark Rutland , Matthias Brugger , Sean Wang , srv_heupstream , hui.liu@mediatek.com, Eddie Huang , Light Hsieh , Biao Huang , Hongzhou Yang , Sean Wang , Seiya Wang , Devicetree List , LKML , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , "moderated list:ARM/Mediatek SoC support" , "open list:GPIO SUBSYSTEM" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210919_123348_488821_7A5B6364 X-CRM114-Status: GOOD ( 24.21 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Sep 16, 2021 at 11:31 AM zhiyong.tao wrote: > On Mon, 2021-09-06 at 18:09 +0800, Chen-Yu Tsai wrote: > > > > > + if (!found) { > > > > > + dev_err(hw->dev, "Not support rsel value %d Ohm > > > > > for > > > > > pin = %d (%s)\n", > > > > > + arg, desc->number, desc->name); > > > > > + return -EOPNOTSUPP; > > > > > > > > I believe ENOTSUPP is the correct one. EOPNOTSUPP seems to be > > > > network > > > > related. > > > > > > > > > > if we change it as "ENOTSUPP", it will report warning"ENOTSUPP is > > > not > > > SUSV4 error code, prefer EOPNOTSUP" when checking patch. > > > > The context surrounding this warning seems to be that ENOTSUPP is > > hard > > for userspace to understand. AFAIK the return code here does not get > > passed to userspace? And the pinctrl core does check for EINVAL or > > ENOTSUPP, so I think this is a valid use case. > > > > Linus? > > > > Hi Linus, > > Do you have some suggestion for the warning issue? Ignore the warning. We use this code in the pinctrl subsystem. The pinctrl subsystem has no userspace API so that is certainly not a problem. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel