From: Linus Walleij <linus.walleij@linaro.org>
To: Ulf Hansson <ulf.hansson@stericsson.com>
Cc: linux-mmc@vger.kernel.org, Chris Ball <cjb@laptop.org>,
Adrian Hunter <adrian.hunter@intel.com>,
Per Forlin <per.forlin@stericsson.com>,
Johan Rudholm <johan.rudholm@stericsson.com>,
Lee Jones <lee.jones@linaro.org>
Subject: Re: [PATCH] mmc: core: Force a "detect" to handle non-properly removed cards
Date: Wed, 4 Jan 2012 10:40:51 +0100 [thread overview]
Message-ID: <CACRpkdZmiaOGah00UBmhWEcbhc7=xFrc3p0VFB=tFmpo5hEmGA@mail.gmail.com> (raw)
In-Reply-To: <1325586798-16276-1-git-send-email-ulf.hansson@stericsson.com>
On Tue, Jan 3, 2012 at 11:33 AM, Ulf Hansson <ulf.hansson@stericsson.com> wrote:
> Removing a card "slowly" can trigger a GPIO irq to be raised far
> before the card is actually removed. This means the scheduled
> detect work will not find out that the card were removed and thus
> the card and the block device will not be unregistered.
>
> Let the mmc_detect_card_removed function trigger a new detect
> work immediately when it discovers that a card has been removed.
> This will solve the described issue above. Moreover we make sure
> the detect work is executed as soon as possible, since there is
> no reason for waiting for a "delayed" detect to happen.
>
> Signed-off-by: Ulf Hansson <ulf.hansson@stericsson.com>
This looks way more solid than the simple variable.
The old detect_change variable does not seem to be
protected by any lock either.
Acked-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-01-04 9:40 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-03 10:33 [PATCH] mmc: core: Force a "detect" to handle non-properly removed cards Ulf Hansson
2012-01-04 9:40 ` Linus Walleij [this message]
2012-01-04 21:26 ` Adrian Hunter
2012-01-09 11:02 ` Ulf Hansson
2012-01-09 12:07 ` Adrian Hunter
2012-01-09 13:14 ` Ulf Hansson
2012-01-09 13:53 ` Adrian Hunter
2012-01-09 14:27 ` Ulf Hansson
2012-01-10 9:22 ` Adrian Hunter
2012-01-10 10:59 ` Ulf Hansson
2012-01-10 12:10 ` Adrian Hunter
2012-01-13 10:04 ` Ulf Hansson
2012-01-13 10:43 ` Adrian Hunter
2012-01-13 11:31 ` Ulf Hansson
2012-01-13 12:08 ` Adrian Hunter
2012-01-13 13:14 ` Ulf Hansson
2012-01-13 13:43 ` Adrian Hunter
2012-01-13 14:35 ` Ulf Hansson
2012-01-16 7:45 ` Adrian Hunter
2012-01-16 11:09 ` Ulf Hansson
2012-01-10 9:33 ` Adrian Hunter
2012-01-10 11:03 ` Ulf Hansson
2012-01-10 12:21 ` Adrian Hunter
2012-01-09 14:34 ` Ulf Hansson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZmiaOGah00UBmhWEcbhc7=xFrc3p0VFB=tFmpo5hEmGA@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=johan.rudholm@stericsson.com \
--cc=lee.jones@linaro.org \
--cc=linux-mmc@vger.kernel.org \
--cc=per.forlin@stericsson.com \
--cc=ulf.hansson@stericsson.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.