From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH] gpio: Fix OF build problem on UM Date: Fri, 19 Aug 2016 14:53:12 +0200 Message-ID: References: <1471334801-2814-1-git-send-email-linus.walleij@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: Received: from mail-oi0-f44.google.com ([209.85.218.44]:35317 "EHLO mail-oi0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752088AbcHSMxN (ORCPT ); Fri, 19 Aug 2016 08:53:13 -0400 Received: by mail-oi0-f44.google.com with SMTP id 4so61973473oih.2 for ; Fri, 19 Aug 2016 05:53:13 -0700 (PDT) In-Reply-To: Sender: linux-gpio-owner@vger.kernel.org List-Id: linux-gpio@vger.kernel.org To: Geert Uytterhoeven Cc: "linux-gpio@vger.kernel.org" , Alexandre Courbot , stable On Fri, Aug 19, 2016 at 11:16 AM, Geert Uytterhoeven wrote: > On Fri, Aug 19, 2016 at 10:53 AM, Linus Walleij > wrote: >> On Wed, Aug 17, 2016 at 11:03 AM, Geert Uytterhoeven >> wrote: >>> On Tue, Aug 16, 2016 at 10:06 AM, Linus Walleij >>> wrote: >>>> The UserMode (UM) Linux build was failing in gpiolib-of as it requires >>>> ioremap()/iounmap() to exist, which is absent from UM. The non-existence >>>> of IO memory is negatively defined as CONFIG_NO_IOMEM so put a reverse >>>> dependency on !NO_IOMEM for OF_GPIO to fix the build. >>>> >>>> Cc: stable@vger.kernel.org >>>> Reported-by: kbuild test robot >>>> Signed-off-by: Linus Walleij >>>> --- >>>> drivers/gpio/Kconfig | 1 + >>>> 1 file changed, 1 insertion(+) >>>> >>>> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig >>>> index 98dd47a30fc7..a6026f2fe7f5 100644 >>>> --- a/drivers/gpio/Kconfig >>>> +++ b/drivers/gpio/Kconfig >>>> @@ -50,6 +50,7 @@ config GPIO_DEVRES >>>> config OF_GPIO >>>> def_bool y >>>> depends on OF >>>> + depends on !NO_IOMEM >>> >>> depends on HAS_IOMEM? >> >> Apparently not, and that is the scary thing. >> >> HAS_IOMEM depends on !NO_IOMEM indeed but >> it also selects GENERIC_IO, and AFAICT there are >> some configs out there in the intersection between, >> that have IOMEM but are not using GENERIC_IO, >> tell me if I'm wrong :/ > > lib/Kconfig: > > config HAS_IOMEM > bool > depends on !NO_IOMEM > select GENERIC_IO > default y > > Hence if NO_IOMEM is not set, HAS_IOMEM and GENERIC_IO are always set. > > UML selects GENERIC_IO, but not HAS_IOMEM (it sets NO_IOMEM). Ah you're right. OK sent a new version! Yours, Linus Walleij