From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D618C433E1 for ; Thu, 25 Mar 2021 09:36:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E586361A2A for ; Thu, 25 Mar 2021 09:36:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229617AbhCYJgB (ORCPT ); Thu, 25 Mar 2021 05:36:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43698 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230045AbhCYJfw (ORCPT ); Thu, 25 Mar 2021 05:35:52 -0400 Received: from mail-lj1-x22b.google.com (mail-lj1-x22b.google.com [IPv6:2a00:1450:4864:20::22b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9E8EFC061760 for ; Thu, 25 Mar 2021 02:35:51 -0700 (PDT) Received: by mail-lj1-x22b.google.com with SMTP id s17so2259783ljc.5 for ; Thu, 25 Mar 2021 02:35:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=lnKGY/6ZO5EZRmW+zz0mJjR5jOE8EDHSLr7ZWUE9PkY=; b=QCf02xfZoRY77Lzb4pRtECrjKjsrjfypt4uTlhSrnB+Qv7fpYU/0fMZeNOywk9Fbe6 7VBOsYKrEA7QWamzz0x58Td2jGLzLlEsZgHRQUYpYTRSFtgjgU9RROJCT7AZv1pqaedE uF4oEA/VakeAxNrMcBF7X+gA86K5eUTRt3hmrNk2Fii00HIJMuPfSMTIYzYN9uJ4zZRy cR0SgYb95NKk4EMcKKs1+t0BTuLAq63PsVbxyWkocMMqexrsBJYz/vHnYtruySV26pAL su6GUXDWQKvYpzVwq3ZnZ1Fr3TY700ZKm1Wj2MHWsXe0xg3t2taf22ocn9NZ94X6ocuJ I5/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=lnKGY/6ZO5EZRmW+zz0mJjR5jOE8EDHSLr7ZWUE9PkY=; b=nuByBGPWs13nJGA8yt2dGZovgFAQ6lPTKIZcVrQCMSvfhwC6SQTNB7tog4KdBtRdAW /497Sq9n5vs6s+RnNoKv+vteMb3IfYxyVeVyMI7ZuP+V3Y7S/ceJq3R/YAePRAshe+7N VWVbAZATzg4Co0k07+rbEBsiCFIbMUXiw6ATHihtQPvu/VcpjT964uKIUOZdTop+qKuO +vum7xPBKX07XVOUXoP2IkEsuimZ+Pa9VnsEyxYRJv3jTdOX2Ue0llHy5vGDR/GvECHJ kWfNlpcE+yrdnUVqzcxeMgUM7IzxrZ1+uyo/kSQWoiCSFl5XTIlwBzXiNVvRr5IYtgBu Cf1w== X-Gm-Message-State: AOAM530p5Qxh23TsSNA/H3XEmq8NtQ9+muWCy4bg05Ke4zsg/1JN+Bka cMmGNrQzUeqpC9WqdWFxpE97it6zibi5Xijnlx968w== X-Google-Smtp-Source: ABdhPJwprC4cA46dk09VgjsQHeEIOFT5FCcA1k5f8SACsFUHb8+TjiwhQT0lP/fa7ZoYuHTMNWyOV/tAFrWco3l1i4I= X-Received: by 2002:a2e:9004:: with SMTP id h4mr5090269ljg.326.1616664949901; Thu, 25 Mar 2021 02:35:49 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Linus Walleij Date: Thu, 25 Mar 2021 10:35:39 +0100 Message-ID: Subject: Re: [PATCH v4 09/16] gpio: support ROHM BD71815 GPOs To: Matti Vaittinen Cc: Matti Vaittinen , Lee Jones , Rob Herring , Bartosz Golaszewski , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , "linux-kernel@vger.kernel.org" , linux-power@fi.rohmeurope.com, "open list:GPIO SUBSYSTEM" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Wed, Mar 24, 2021 at 8:29 AM Matti Vaittinen wrote: > Support GPO(s) found from ROHM BD71815 power management IC. The IC has two > GPO pins but only one is properly documented in data-sheet. The driver > exposes by default only the documented GPO. The second GPO is connected to > E5 pin and is marked as GND in data-sheet. Control for this undocumented > pin can be enabled using a special DT property. > > This driver is derived from work by Peter Yang > although not so much of original is left. > > Signed-off-by: Matti Vaittinen > --- > Changes since v3: > - No changes This looks OK to me: Acked-by: Linus Walleij It could potentially (like the other Rohm GPIO MFD PMIC drivers) make some use of the gpio regmap library, but we have some pending changes for that so look into it after the next merge window. I.e. for your TODO: look at the GPIO_REGMAP helper. Yours, Linus Walleij