From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 873D6CCA479 for ; Tue, 28 Jun 2022 12:39:15 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345264AbiF1MjO (ORCPT ); Tue, 28 Jun 2022 08:39:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1344722AbiF1MjN (ORCPT ); Tue, 28 Jun 2022 08:39:13 -0400 Received: from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com [IPv6:2607:f8b0:4864:20::b32]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2DB32ED64 for ; Tue, 28 Jun 2022 05:39:12 -0700 (PDT) Received: by mail-yb1-xb32.google.com with SMTP id l11so21921500ybu.13 for ; Tue, 28 Jun 2022 05:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MTpYKqpj1Ke2nAmzrM6LJJrYdhJ2JyjS8LNVvYtovMY=; b=LZ4njZtM/bVQo60epTjPQUxLOP5aP70PbLAod6eYk4b+5m4+pvXIbgAw+6FM9oQXWp fYbFM9x4zHrfsatqy64G8NP4VYffdEpd0F3fFz4czouhH2J4zKCdHcXHuv+9REqitFIl ca7OMcQZj49s03y1/vdx6QPl2Q7IFvSfIvXKuqgY6g0//qEb0odvsb+fcq2xGEBRdPHa K8pIeoNQV0Yspl5/H3nb9n4QBna/oTSysJY3EQIP2f0cqOpRcM8nckemGnWPb8PAqcie BfwS1L2wRN7/1rUbgtJVwCY8tzQGGaJmaGr5Yz+M4KlMjmskNpt5BkcQEBZDeSWSgeNU eO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MTpYKqpj1Ke2nAmzrM6LJJrYdhJ2JyjS8LNVvYtovMY=; b=G/HBe40A4mkrlMyJ7ex9HK4Aw/iOX4BCaS6qSWac3cmsPBELQ3YfLKzaLkjc+vXiam WUb8REtrccwlzSm7FLzZtzCMoh6flZs9PDfMkJJnA9SASS2PGRD+RY1Um+n9s5ttZ6Hd H4JA2MbiKaMDkNU62WPzdAHzq/qH2bud3re/c42pl6rj1uy/4FKzbIZ4X9eoT8uJD7Qv iAGygO1Oo6zu6GK2rY1QrBU1Eqsr2Kw8o7ZFUkbFqRCFu6ubL4tyazN62f5VJJD6fH06 ZrBvNEmVrqhP+yzs6A3oq53L4aYBofh92GT5dBtLItyCXJDFE+RW9Gxr1t4BHDCn0V7U DqFQ== X-Gm-Message-State: AJIora/DpP7zTxU9L2yjcM12ao8bks3ajC9I/6RP2Fxg+NXXReqKsjvK 76BXITVJ2dGWIj7+k+Xlazo1upXMy+b3jaWmzT4YhR1zOVQ= X-Google-Smtp-Source: AGRyM1vap6g56eXS4/X+EknzSt9CwmskqIiDkdBJiGLfUDZZWgN3Fs7uzox9wQbgYLZTCOLAW51Xy7ZFUvOkyb3jtBg= X-Received: by 2002:a05:6902:152:b0:66c:e116:6a7 with SMTP id p18-20020a056902015200b0066ce11606a7mr9347506ybh.533.1656419951745; Tue, 28 Jun 2022 05:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20220620165053.74170-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20220620165053.74170-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Tue, 28 Jun 2022 14:39:00 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] pinctrl: bcm: Convert drivers to use struct pingroup and PINCTRL_PINGROUP() To: Andy Shevchenko , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Jonas Gorski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , Broadcom internal kernel review list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Mon, Jun 20, 2022 at 6:50 PM Andy Shevchenko wrote: > The pin control header provides struct pingroup and PINCTRL_PINGROUP() ma= cro. > Utilize them instead of open coded variants in the driver. > > Signed-off-by: Andy Shevchenko This looks very tasty. Can we get a test or ACK from one of the BCM people? (=C3=81lvaro/Jonas) Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0A96FC433EF for ; Tue, 28 Jun 2022 12:40:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ntWXp4eSqRQTWgY9y/dQAlMFruPHlUbVuMblmjFpD/s=; b=D8oWXdOhUUxYe0 sgS2pRPg2JRS898/7Zq/ZtsZEI9NdyRQpvncHxJb9SD4Te4263mYOXLohE5Dyw52f5rgDCDvsgKTf UzwRa2//2dYpRLsG9fvbuY4UwZOkV05NfAlN6Br2NNjc6HxbsHMpVJZC8hZ+sgWLXwp3juaY/arzr HMmFeZ4W32lH8dGshVZx2caF1emwpI1JBIFkyU+IaNEz9nMjtXtvCWuwfRdLT6csjg84R5PDdEaCV XN9nKafa6WQlu3USU8fvGAW+iFzBmIF3EA8f4MLYp1Odo7uHTR8J/zR0j/gHt+mg4IBaySGPXGpbQ 61sjg2cjExIry7FvLkNw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6AUv-006CLO-SC; Tue, 28 Jun 2022 12:39:17 +0000 Received: from mail-yb1-xb30.google.com ([2607:f8b0:4864:20::b30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1o6AUs-006CJl-L3 for linux-arm-kernel@lists.infradead.org; Tue, 28 Jun 2022 12:39:15 +0000 Received: by mail-yb1-xb30.google.com with SMTP id i7so21923062ybe.11 for ; Tue, 28 Jun 2022 05:39:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=MTpYKqpj1Ke2nAmzrM6LJJrYdhJ2JyjS8LNVvYtovMY=; b=LZ4njZtM/bVQo60epTjPQUxLOP5aP70PbLAod6eYk4b+5m4+pvXIbgAw+6FM9oQXWp fYbFM9x4zHrfsatqy64G8NP4VYffdEpd0F3fFz4czouhH2J4zKCdHcXHuv+9REqitFIl ca7OMcQZj49s03y1/vdx6QPl2Q7IFvSfIvXKuqgY6g0//qEb0odvsb+fcq2xGEBRdPHa K8pIeoNQV0Yspl5/H3nb9n4QBna/oTSysJY3EQIP2f0cqOpRcM8nckemGnWPb8PAqcie BfwS1L2wRN7/1rUbgtJVwCY8tzQGGaJmaGr5Yz+M4KlMjmskNpt5BkcQEBZDeSWSgeNU eO/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=MTpYKqpj1Ke2nAmzrM6LJJrYdhJ2JyjS8LNVvYtovMY=; b=5Ho2F7shi0lPAd+d3ukucyB3/vGjir3D0oklIcO7RXrde9prpSlQkijtpUyea0JYVs Rzl29+8vICWuyeWugc/yBXAMfg9VlTjinW8VhMhHvg+EoFD9iSR12MHoRLwj2Y9+ehvo raz0tNryeIWElxlEqRmtu43U+MvJa8DidYqprz7OU4kqqVXeVSXPb/obsd3k/7qd/2m6 JEMKvUy1FTmEuxZ+sb3dsANvlY1sznAAVRO0WMHpj4KUxlg+9YiAlcuAx44roRQ0k1tS 45/JFj0wr/xXTqMufYmMnRefn7RTPkuDBobUGXMPZB29dw1mHTS8buqxcD03PfvewjM6 LgcA== X-Gm-Message-State: AJIora+nSxFMRqtf1zSjlXRSTZqK0eClGSop+Ef08OsUnSbXef8M927U ONcWDVIE/4uqI7IJESP2ZE7pzHjEkZ8TMq+QnGYrFA== X-Google-Smtp-Source: AGRyM1vap6g56eXS4/X+EknzSt9CwmskqIiDkdBJiGLfUDZZWgN3Fs7uzox9wQbgYLZTCOLAW51Xy7ZFUvOkyb3jtBg= X-Received: by 2002:a05:6902:152:b0:66c:e116:6a7 with SMTP id p18-20020a056902015200b0066ce11606a7mr9347506ybh.533.1656419951745; Tue, 28 Jun 2022 05:39:11 -0700 (PDT) MIME-Version: 1.0 References: <20220620165053.74170-1-andriy.shevchenko@linux.intel.com> In-Reply-To: <20220620165053.74170-1-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Tue, 28 Jun 2022 14:39:00 +0200 Message-ID: Subject: Re: [PATCH v1 1/1] pinctrl: bcm: Convert drivers to use struct pingroup and PINCTRL_PINGROUP() To: Andy Shevchenko , =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= , Jonas Gorski Cc: linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Florian Fainelli , Broadcom internal kernel review list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220628_053914_788474_A1D01004 X-CRM114-Status: GOOD ( 10.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gTW9uLCBKdW4gMjAsIDIwMjIgYXQgNjo1MCBQTSBBbmR5IFNoZXZjaGVua28KPGFuZHJpeS5z aGV2Y2hlbmtvQGxpbnV4LmludGVsLmNvbT4gd3JvdGU6Cgo+IFRoZSBwaW4gY29udHJvbCBoZWFk ZXIgcHJvdmlkZXMgc3RydWN0IHBpbmdyb3VwIGFuZCBQSU5DVFJMX1BJTkdST1VQKCkgbWFjcm8u Cj4gVXRpbGl6ZSB0aGVtIGluc3RlYWQgb2Ygb3BlbiBjb2RlZCB2YXJpYW50cyBpbiB0aGUgZHJp dmVyLgo+Cj4gU2lnbmVkLW9mZi1ieTogQW5keSBTaGV2Y2hlbmtvIDxhbmRyaXkuc2hldmNoZW5r b0BsaW51eC5pbnRlbC5jb20+CgpUaGlzIGxvb2tzIHZlcnkgdGFzdHkuIENhbiB3ZSBnZXQgYSB0 ZXN0IG9yIEFDSyBmcm9tIG9uZSBvZiB0aGUgQkNNCnBlb3BsZT8gKMOBbHZhcm8vSm9uYXMpCgpZ b3VycywKTGludXMgV2FsbGVpagoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5l bEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4v bGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=