From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C165AC433EF for ; Sun, 1 May 2022 21:45:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1352165AbiEAVtE (ORCPT ); Sun, 1 May 2022 17:49:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41816 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1357515AbiEAVsr (ORCPT ); Sun, 1 May 2022 17:48:47 -0400 Received: from mail-yb1-xb36.google.com (mail-yb1-xb36.google.com [IPv6:2607:f8b0:4864:20::b36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0033A21B1 for ; Sun, 1 May 2022 14:45:18 -0700 (PDT) Received: by mail-yb1-xb36.google.com with SMTP id m128so23343701ybm.5 for ; Sun, 01 May 2022 14:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=jIUUFw/Dk0bJvSpV2KhChXMwtNlLYqsYYK4oY1ZrIaM5CwokwxvKI2nY/2x/UYhhSZ cnYvPcNR4I1+2mQEXOx+fTBIepxbMOgfBDYzGHDeV47Jl9VtWIb/nS+yTlzYid021q5y 4rk1aenFHUTcFpOe8yZyA6PrfG7AdYTLzyJZCxoXrUBdmiOH7kD+EpptUWvO22jzMcIN xSCS+MFyhpSsWhXxvfUnHSHIueURSlmIpP3ceYNATHQiGd7mRdyumFBzg7HidVpGXR/K HmLBNFjobzv+Lfi/mc0Jdu1mADUOwm6Q+P8Sv4LOYfSplf9TRRKfiG/zS7FqqwYnszNe 9g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=dbZ5gZiiadEvXY+BfAjq1FOEESeeQ+iIlta0xdFS6unoqdU6DrbxJ7/a9l8tfeEnSu BomXMiWUN7Fr+XmET/FkbprThn4y/dXFbE+4GTWrNE28bm3ixjYVICafWC5J2NFParK9 jW4C9uewkx5tdfr3NBpKGVy9MQwhesAXvDClor3H8bxjs633+WezmDn+PEP0c2Yge7zt gPKHtu0TKsbuYsPcYOsbRY76jDA0rCsmIWZ5Iku5fHXqHNPgzu3VycT7DEI7gl8K4e8+ HnRf20SE4zlfmmAMnDEh+WRRgPU2r84KhdGtbBADug/fFDTYoYdIR8r9btXpUz1E6odT Wc5g== X-Gm-Message-State: AOAM532gXqkp1FmsjK6v3P8hQEBZnAXzZsvgOnlQf1m38uH/Lq0xqDME 1Keb51/z7RzX8A/OrQZdGcI2SOUur7CWRTtLwWr3og== X-Google-Smtp-Source: ABdhPJz9eJE7cneK+kxH13EYMup9tW/2JAXx6cXKgLkzm/eVQ61nD3w0biIeuzEawWWGZ8vTkmgdM3jCm2iwQFey2JY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8658475ybh.369.1651441518148; Sun, 01 May 2022 14:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-22-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-22-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:45:06 +0200 Message-ID: Subject: Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-leds@vger.kernel.org On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 84639C433EF for ; Sun, 1 May 2022 21:45:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C9CD010E33C; Sun, 1 May 2022 21:45:19 +0000 (UTC) Received: from mail-yb1-xb30.google.com (mail-yb1-xb30.google.com [IPv6:2607:f8b0:4864:20::b30]) by gabe.freedesktop.org (Postfix) with ESMTPS id F204B10E33C for ; Sun, 1 May 2022 21:45:18 +0000 (UTC) Received: by mail-yb1-xb30.google.com with SMTP id e12so23266854ybc.11 for ; Sun, 01 May 2022 14:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=jIUUFw/Dk0bJvSpV2KhChXMwtNlLYqsYYK4oY1ZrIaM5CwokwxvKI2nY/2x/UYhhSZ cnYvPcNR4I1+2mQEXOx+fTBIepxbMOgfBDYzGHDeV47Jl9VtWIb/nS+yTlzYid021q5y 4rk1aenFHUTcFpOe8yZyA6PrfG7AdYTLzyJZCxoXrUBdmiOH7kD+EpptUWvO22jzMcIN xSCS+MFyhpSsWhXxvfUnHSHIueURSlmIpP3ceYNATHQiGd7mRdyumFBzg7HidVpGXR/K HmLBNFjobzv+Lfi/mc0Jdu1mADUOwm6Q+P8Sv4LOYfSplf9TRRKfiG/zS7FqqwYnszNe 9g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=rwz/EjzhqkeN3CePpfpF41C68Xm/XmXgn/VEsu2ljR+WpzcejfdlaeP1IUNbJzEqur xI+YA/q6JF1Q7tQT4DZmecl0ZlwYye4SmRvuhxyut5rz+LnBP4pnLXu6P0E9E7KLWF/X 3jx6vdvvOq2PdKWGbBiKwq/2e3ZUbHX+fNbq7Bdh1MBnpmOLKZZ5muejV2wTGmqawyj1 22WcPgdd2PnvHk+iQxtU1tIzT/phhPVVmUppp9v1s+9CByMHREGx1HEygjnQ+aBdssFP Yn2KdTaSfLFSILeYc+mke5OB2z0XKNqwMxS/HWanbpgRqUHZIr4jSXgZBiDzt4vV0qSs HX5w== X-Gm-Message-State: AOAM530LQAldydGuuXDxzhM9LLnXnZsjEOjs9WGxmnKdNbmWFiI4KiVI kfZnivJUMeJ4U47nEGPz3psk9BGbclRqp8yYzk5XIA== X-Google-Smtp-Source: ABdhPJz9eJE7cneK+kxH13EYMup9tW/2JAXx6cXKgLkzm/eVQ61nD3w0biIeuzEawWWGZ8vTkmgdM3jCm2iwQFey2JY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8658475ybh.369.1651441518148; Sun, 01 May 2022 14:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-22-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-22-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:45:06 +0200 Message-ID: Subject: Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio To: Arnd Bergmann Content-Type: text/plain; charset="UTF-8" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Viresh Kumar , Sergey Lapin , linux-fbdev@vger.kernel.org, Dominik Brodowski , linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-mtd@lists.infradead.org, Tomas Cech , robert.jarzmik@free.fr, linux-clk@vger.kernel.org, linux-leds@vger.kernel.org, linux-rtc@vger.kernel.org, Helge Deller , Marek Vasut , Paul Parsons , Michael Turquette , Arnd Bergmann , linux-pm@vger.kernel.org, linux-input@vger.kernel.org, Haojian Zhuang , Lubomir Rintel , Mark Brown , dri-devel@lists.freedesktop.org, linux-arm-kernel@lists.infradead.org, Thomas Bogendoerfer , Stephen Boyd , patches@opensource.cirrus.com, Dmitry Torokhov , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, Daniel Mack Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D4E5AC4167B for ; Sun, 1 May 2022 21:45:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=p5EgZiAxCFT/XOOjptYXrjdX0HM6yu8jld/6lAShMk8=; b=E6KXFnhzDgVRIb Aiio5YLEU2dOh4Cu0/wIcUUKcZ46Mj3T//TbpEm8Cx6zoMSgblnL05mGdIeF4UAi9E1db4Q0ZZMn5 u3RVfMxQA6sWTncEoH4U+5JTRKdZiB3eB8+WItCGCLvJK0ARERZtVmhs7Lze7uazYZcfhAsMWyPSe 9JGQ8cvFlRD4T0d0gCMi1HP7f/4cXM9mw4N4EUNWipzcSlIb3q4cKqgxdq991kHY8dZ0biM+80OdW j12c9CDW4LQRZaXoCFuktXsPe4VnpU0CZu8vAPWQ00OvbireXaiyyDH5+cldDKOjyX9+eyx7OeGH6 /mIQJG1mAlOiOQ5knL9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHNi-00GxmY-Bc; Sun, 01 May 2022 21:45:30 +0000 Received: from mail-yb1-xb2d.google.com ([2607:f8b0:4864:20::b2d]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHNX-00Gxjg-2q for linux-mtd@lists.infradead.org; Sun, 01 May 2022 21:45:20 +0000 Received: by mail-yb1-xb2d.google.com with SMTP id e12so23266853ybc.11 for ; Sun, 01 May 2022 14:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=jIUUFw/Dk0bJvSpV2KhChXMwtNlLYqsYYK4oY1ZrIaM5CwokwxvKI2nY/2x/UYhhSZ cnYvPcNR4I1+2mQEXOx+fTBIepxbMOgfBDYzGHDeV47Jl9VtWIb/nS+yTlzYid021q5y 4rk1aenFHUTcFpOe8yZyA6PrfG7AdYTLzyJZCxoXrUBdmiOH7kD+EpptUWvO22jzMcIN xSCS+MFyhpSsWhXxvfUnHSHIueURSlmIpP3ceYNATHQiGd7mRdyumFBzg7HidVpGXR/K HmLBNFjobzv+Lfi/mc0Jdu1mADUOwm6Q+P8Sv4LOYfSplf9TRRKfiG/zS7FqqwYnszNe 9g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=48kd4gR6wYzH32aB86HKV1EwEJ3hoa5zAftDUlWrv6YAXQPZpi7PBANigoBJb8WcOC mhpNe8e6hKZv+GKUDQ5Tiwd4gaztwFKhzSBdyPKrmfuNcOhA2uNOOWFIZyxsWsNPihpR NZXHZgL+mOL1v2UaiGHKyxk7miCpWFzE5GVebWK2deBYCb8a9XZjv9a1+06JJITrL1kJ 9jWBL/mK375q//BLTdfpDSYiHLjQTIUP4StfChDJ0vuUXAIYQGnHTutN1+gl2BcVYqCk 6nufIVQzb2e9RJu3V/zCrm03Vc/djgmboT6bSd/XSEiFIzqtTf6CtKDWMo+6SFItobRm R3Jw== X-Gm-Message-State: AOAM530eus6hEOfudgYIfw2tMOoUk1cp4R9TuNd55hNqbJ1nxdcjC3UW IgInsJHQ+S/j/4peTvcPQJ8PHQvID8ksll4vanFgeQ== X-Google-Smtp-Source: ABdhPJz9eJE7cneK+kxH13EYMup9tW/2JAXx6cXKgLkzm/eVQ61nD3w0biIeuzEawWWGZ8vTkmgdM3jCm2iwQFey2JY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8658475ybh.369.1651441518148; Sun, 01 May 2022 14:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-22-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-22-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:45:06 +0200 Message-ID: Subject: Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220501_144519_214670_C406D02F X-CRM114-Status: GOOD ( 14.58 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij Yours, Linus Walleij ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AFAD0C433EF for ; Sun, 1 May 2022 21:46:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6eW5/kbKG10JHFzdNfXtcWfEHtMnGiMJczoI5Pnjkf8=; b=OdHv2ovDFSwPNO ocescGsT++2+NtoCCGYI96G+5Huw2BuJQDmmyR4qwN7kyiAXl5Bwghr8npYxvZtKIziRx8kvX/Dp2 K9ylYthSA6gg5YIChzXLsuTS4YdD2m3yq8p/fH6vY3LaEKhYCaOoCb3uk9frCrHDsYFarFD6JZHQz pUk1fISbY6hblIGv80Jw2Bl3HLUxQ9XkEBKexrSJ7GDthbYG2Nq4UyKAGif0tx2MdeX/As38zgKq8 OOhwsunY94upZoaqDK0odM57i/bW9pgDu+Z67ev4KSSTt/BLhdWF8QcWIRWzUu1Bkdwxwrmvfd3yz SHCsZ6CkBu5BBK4yAXOw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHNa-00Gxkj-08; Sun, 01 May 2022 21:45:22 +0000 Received: from mail-yb1-xb2c.google.com ([2607:f8b0:4864:20::b2c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nlHNX-00Gxjf-2q for linux-arm-kernel@lists.infradead.org; Sun, 01 May 2022 21:45:20 +0000 Received: by mail-yb1-xb2c.google.com with SMTP id e12so23266852ybc.11 for ; Sun, 01 May 2022 14:45:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=jIUUFw/Dk0bJvSpV2KhChXMwtNlLYqsYYK4oY1ZrIaM5CwokwxvKI2nY/2x/UYhhSZ cnYvPcNR4I1+2mQEXOx+fTBIepxbMOgfBDYzGHDeV47Jl9VtWIb/nS+yTlzYid021q5y 4rk1aenFHUTcFpOe8yZyA6PrfG7AdYTLzyJZCxoXrUBdmiOH7kD+EpptUWvO22jzMcIN xSCS+MFyhpSsWhXxvfUnHSHIueURSlmIpP3ceYNATHQiGd7mRdyumFBzg7HidVpGXR/K HmLBNFjobzv+Lfi/mc0Jdu1mADUOwm6Q+P8Sv4LOYfSplf9TRRKfiG/zS7FqqwYnszNe 9g7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2Zs9ZXFuA5R/0ymMTjHB7/FZWKOdSvop8pXLfIOyulA=; b=nfa57h9nb4CGNHM51C40sBAVSjAfsRw7MBusP/S+7ncd3gQdau7BqrjTTdGzi7y19Z 1f1JIuuxRNaoWe3Nqf2kZPvN68Juppm77P8SQFbowQ7XvygAYCo9Jnx1oD9AY6Kv1G9V ZQm7nfYtK6Q/40FaSBppO+yHetWQkjy6QtUYR1pj2ZpyEc3He3WEG7uimI7DjhRwf3YR /NnjI82CMOEKYrIDFuqGTGTXXLQTGlIfAmUafNipXa291De4xhdzgaxULD/C3lMr+JE1 xOfZq56zpLXHtMGwSTlyDlwLbpY1FmoPy9FNr2wtJc09lPz866nAnY07lDnPitWfYlZI J6KQ== X-Gm-Message-State: AOAM530kOFURztWY/I2NjOlT9TgznWYvyZ9Nf1vM9VkRTDvFZcEDe2ja IjEr8xqockp52akhs4o9ScEgayb/yV9UKnIE9hUNkA== X-Google-Smtp-Source: ABdhPJz9eJE7cneK+kxH13EYMup9tW/2JAXx6cXKgLkzm/eVQ61nD3w0biIeuzEawWWGZ8vTkmgdM3jCm2iwQFey2JY= X-Received: by 2002:a25:e684:0:b0:645:d429:78e9 with SMTP id d126-20020a25e684000000b00645d42978e9mr8658475ybh.369.1651441518148; Sun, 01 May 2022 14:45:18 -0700 (PDT) MIME-Version: 1.0 References: <20220419163810.2118169-1-arnd@kernel.org> <20220419163810.2118169-22-arnd@kernel.org> In-Reply-To: <20220419163810.2118169-22-arnd@kernel.org> From: Linus Walleij Date: Sun, 1 May 2022 23:45:06 +0200 Message-ID: Subject: Re: [PATCH 21/48] ARM: pxa: eseries: use gpio lookup for audio To: Arnd Bergmann Cc: robert.jarzmik@free.fr, linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Daniel Mack , Haojian Zhuang , Marek Vasut , Philipp Zabel , Lubomir Rintel , Paul Parsons , Tomas Cech , Sergey Lapin , Thomas Bogendoerfer , Michael Turquette , Stephen Boyd , "Rafael J. Wysocki" , Viresh Kumar , Dmitry Torokhov , Ulf Hansson , Dominik Brodowski , Helge Deller , Mark Brown , linux-kernel@vger.kernel.org, linux-mips@vger.kernel.org, linux-ide@vger.kernel.org, linux-clk@vger.kernel.org, linux-pm@vger.kernel.org, linux-input@vger.kernel.org, patches@opensource.cirrus.com, linux-leds@vger.kernel.org, linux-mmc@vger.kernel.org, linux-mtd@lists.infradead.org, linux-rtc@vger.kernel.org, linux-usb@vger.kernel.org, linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, alsa-devel@alsa-project.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220501_144519_214671_6F2741C8 X-CRM114-Status: GOOD ( 15.68 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, Apr 19, 2022 at 6:41 PM Arnd Bergmann wrote: > From: Arnd Bergmann > > The three eseries machines have very similar drivers for audio, all > using the mach/eseries-gpio.h header for finding the gpio numbers. > > Change these to use gpio descriptors to avoid the header file > dependency. > > I convert the _OFF gpio numbers into GPIO_ACTIVE_LOW ones for > consistency here. > > Acked-by: Mark Brown > Acked-by: Robert Jarzmik > Reviewed-by: Linus Walleij > Cc: alsa-devel@alsa-project.org > Signed-off-by: Arnd Bergmann Nice use of active low. Maybe I would simply have dropped the _OFF suffix on these GPIO lines as it can be confusing now that their active level is encoded but no big deal. Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel