From: Linus Walleij <linus.walleij@linaro.org>
To: Abel Vesa <abel.vesa@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Subject: Re: [PATCH v2 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property
Date: Thu, 24 Nov 2022 14:11:32 +0100 [thread overview]
Message-ID: <CACRpkdZtkHCkfUAcezSJvmei=HOezK6oyx+4C5kBrEtU+vAB-g@mail.gmail.com> (raw)
In-Reply-To: <20221123152001.694546-3-abel.vesa@linaro.org>
On Wed, Nov 23, 2022 at 4:20 PM Abel Vesa <abel.vesa@linaro.org> wrote:
> From: Neil Armstrong <neil.armstrong@linaro.org>
>
> Document the new i2c_pull property introduced for SM8550 setting
> an I2C specific pull mode on I2C able pins.
>
> Signed-off-by: Neil Armstrong <neil.armstrong@linaro.org>
> Signed-off-by: Abel Vesa <abel.vesa@linaro.org>
(...)
> + qcom,i2c-pull:
> + type: boolean
> + description: enable bias pull feature designed for I2C on pin
But what is this?
I2C buses are usually just plain old bias-high-impedance, high-z
or open drain, wire-or or whatever you want to call it.
But now there is some special i2c mode, huh?
The description is pretty much "it is what it is"... can we have
some explanation about what this means electrically speaking
and why you cannot use bias-high-impedance?
Yours,
Linus Walleij
next prev parent reply other threads:[~2022-11-24 13:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-23 15:19 [PATCH v2 0/4] pinctrl: qcom: Add support for SM8550 Abel Vesa
2022-11-23 15:19 ` [PATCH v2 1/4] dt-bindings: pinctrl: qcom: Add SM8550 pinctrl Abel Vesa
2022-11-24 9:57 ` Krzysztof Kozlowski
2022-11-23 15:19 ` [PATCH v2 2/4] dt-bindings: pinctrl: qcom,tlmm-common: document i2c pull property Abel Vesa
2022-11-24 9:58 ` Krzysztof Kozlowski
2022-11-24 13:11 ` Linus Walleij [this message]
2022-11-24 13:24 ` Neil Armstrong
2022-11-25 9:47 ` Linus Walleij
2022-11-25 12:40 ` neil.armstrong
2022-11-26 21:53 ` Linus Walleij
2022-11-29 8:15 ` Neil Armstrong
2022-12-15 20:49 ` Bjorn Andersson
2022-11-23 15:20 ` [PATCH v2 3/4] pinctrl: qcom: add support for i2c specific pull feature Abel Vesa
2022-11-23 15:20 ` [PATCH v2 4/4] pinctrl: qcom: Add SM8550 pinctrl driver Abel Vesa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkdZtkHCkfUAcezSJvmei=HOezK6oyx+4C5kBrEtU+vAB-g@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=abel.vesa@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.