From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC Date: Thu, 10 Dec 2015 18:34:35 +0100 Message-ID: References: <1447869580-10416-1-git-send-email-afd@ti.com> <1447869580-10416-6-git-send-email-afd@ti.com> <565DF7BD.6010204@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <565DF7BD.6010204-l0cyMroinI0@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alexandre Courbot , Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , "devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-gpio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-gpio@vger.kernel.org On Tue, Dec 1, 2015 at 8:40 PM, Andrew F. Davis wrote: > On 11/30/2015 02:26 AM, Linus Walleij wrote: >> >> On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis wrote: >> >>> This patch adds support for the TPS65912 PMIC GPIOs. >>> >>> TPS65912 has five configurable GPIOs that can be used for several >>> purposes. >>> >>> Signed-off-by: Andrew F. Davis >>> Reviewed-by: Linus Walleij >> >> >> (...) >>> >>> + gpio->tps = dev_get_drvdata(pdev->dev.parent); >>> + gpio->gpio_chip = template_chip; >>> + gpio->gpio_chip.dev = tps->dev; >> >> >> This is now renamed .parent in linux-next. It needs to be changed if the >> code should compile after merge. >> > > Are you able to make this change when you pick this up or would you > like me to resend this? I guess all these need to be applied together? It's probably best if Lee apply all and provide them on an immutable branch, and I will apply fixes on top after pulling that in. I recently did exactly that with an AC97 driver from ALSA SoC. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755256AbbLJRet (ORCPT ); Thu, 10 Dec 2015 12:34:49 -0500 Received: from mail-ob0-f180.google.com ([209.85.214.180]:35461 "EHLO mail-ob0-f180.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755201AbbLJRef (ORCPT ); Thu, 10 Dec 2015 12:34:35 -0500 MIME-Version: 1.0 In-Reply-To: <565DF7BD.6010204@ti.com> References: <1447869580-10416-1-git-send-email-afd@ti.com> <1447869580-10416-6-git-send-email-afd@ti.com> <565DF7BD.6010204@ti.com> Date: Thu, 10 Dec 2015 18:34:35 +0100 Message-ID: Subject: Re: [PATCH v7 5/5] gpio: tps65912: Add GPIO driver for the TPS65912 PMIC From: Linus Walleij To: "Andrew F. Davis" Cc: Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala , Alexandre Courbot , Samuel Ortiz , Lee Jones , Liam Girdwood , Mark Brown , "devicetree@vger.kernel.org" , "linux-gpio@vger.kernel.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Dec 1, 2015 at 8:40 PM, Andrew F. Davis wrote: > On 11/30/2015 02:26 AM, Linus Walleij wrote: >> >> On Wed, Nov 18, 2015 at 6:59 PM, Andrew F. Davis wrote: >> >>> This patch adds support for the TPS65912 PMIC GPIOs. >>> >>> TPS65912 has five configurable GPIOs that can be used for several >>> purposes. >>> >>> Signed-off-by: Andrew F. Davis >>> Reviewed-by: Linus Walleij >> >> >> (...) >>> >>> + gpio->tps = dev_get_drvdata(pdev->dev.parent); >>> + gpio->gpio_chip = template_chip; >>> + gpio->gpio_chip.dev = tps->dev; >> >> >> This is now renamed .parent in linux-next. It needs to be changed if the >> code should compile after merge. >> > > Are you able to make this change when you pick this up or would you > like me to resend this? I guess all these need to be applied together? It's probably best if Lee apply all and provide them on an immutable branch, and I will apply fixes on top after pulling that in. I recently did exactly that with an AC97 driver from ALSA SoC. Yours, Linus Walleij