From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 616E0C433E0 for ; Mon, 18 Jan 2021 18:18:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 2F8FB22CA1 for ; Mon, 18 Jan 2021 18:18:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404985AbhARSSz (ORCPT ); Mon, 18 Jan 2021 13:18:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34134 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2393205AbhARPIq (ORCPT ); Mon, 18 Jan 2021 10:08:46 -0500 Received: from mail-lf1-x134.google.com (mail-lf1-x134.google.com [IPv6:2a00:1450:4864:20::134]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ABB6AC061573 for ; Mon, 18 Jan 2021 07:08:05 -0800 (PST) Received: by mail-lf1-x134.google.com with SMTP id x20so24504502lfe.12 for ; Mon, 18 Jan 2021 07:08:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=4zCbYZ+Ii0gKy8gsGpTa3Tuf0KUwV6cf+cE8scSt5cg=; b=wYSz9xSmMnsBS+V0YJP4pd1Ravw+EYjYEB08XGS56yApQ2IYJvD2sEwdFI+vexMhMx uJ17aQAcKnq2x/1mTMX/8bp/ml/rWmkuCyT5v4oudmlwEslbqnKayeyHnOyPFnNaUrov cNPNcgolDxtDvRgmNEYzNtnWHrBCWzOFmkvNIPCsGHPzAveFtYqMZZuXBcQNxS1t5e5O jYthnOJOqahDdcYP8FtVAn+tIUSVwM/kA46L1fBNxs0vPUNSxAhCDx99OITNQCiqsEtq VuFTDr7ifX1SA1apalWkLZWM6PCRGP2w6BkleLoPHMI4vCOd5f3tMnSCXBcveSEU5I5V 9Wcg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=4zCbYZ+Ii0gKy8gsGpTa3Tuf0KUwV6cf+cE8scSt5cg=; b=ry4scWeAsmcI17HN4irZsZfXyYu5SAN7haK3WT6uBgDXLDETe2CK2S8xpzYGQAVrmC oy31xSSXGJ/FNjhziddFXH2TEfb4Fx78oq7hDFR3MLEKYMiV+V7GbwViBdLOXGEpEsw9 XMmanRUDT3diIRQHWVj0fj2KfnXV8Gh4JTrBWWgTmisEEetSqXo9zGmTfSBO/gNErUDW /dQRe9R6T9f8N96nu728+eJdNkclTeDUro+JbBNU10wnndOw418i9HJ3uoA2/KGC2YAm SyrLCntxN3iOnamhZPfLL3HqGUrgoq/dUgcQQhI7/9WPNrgDyyD/6DHQnmQoqoWnnXc9 AtBQ== X-Gm-Message-State: AOAM533hhG3DToBJE+4QFnrBiSnKXZzU1Jcd9bBsPqfraah/cUhx9Inv GkOwegPwm34Ar/1zREma6kcrDOW2KGFbxUi2U5gVBg== X-Google-Smtp-Source: ABdhPJzamPmOphzkJBTICVbQQSRmXx8ElaLTJzGCDoClFhiaQeqWsgvskwMSNhP8AGZVgGPD1UXeY3mPErNxHf1Ui+0= X-Received: by 2002:a19:6557:: with SMTP id c23mr10847407lfj.157.1610982484247; Mon, 18 Jan 2021 07:08:04 -0800 (PST) MIME-Version: 1.0 References: <20210114191601.v7.1.I3ad184e3423d8e479bc3e86f5b393abb1704a1d1@changeid> In-Reply-To: <20210114191601.v7.1.I3ad184e3423d8e479bc3e86f5b393abb1704a1d1@changeid> From: Linus Walleij Date: Mon, 18 Jan 2021 16:07:53 +0100 Message-ID: Subject: Re: [PATCH v7 1/4] pinctrl: qcom: Allow SoCs to specify a GPIO function that's not 0 To: Douglas Anderson Cc: Marc Zyngier , Thomas Gleixner , Jason Cooper , Stephen Boyd , Neeraj Upadhyay , MSM , "open list:GPIO SUBSYSTEM" , Bjorn Andersson , Rajendra Nayak , Srinivas Ramana , Maulik Shah , Andy Gross , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Fri, Jan 15, 2021 at 4:16 AM Douglas Anderson wrote: > There's currently a comment in the code saying function 0 is GPIO. > Instead of hardcoding it, let's add a member where an SoC can specify > it. No known SoCs use a number other than 0, but this just makes the > code clearer. NOTE: no SoC code needs to be updated since we can rely > on zero-initialization. > > Signed-off-by: Douglas Anderson > Reviewed-by: Stephen Boyd > Reviewed-by: Maulik Shah > Tested-by: Maulik Shah > Reviewed-by: Bjorn Andersson Patches applied for fixes! Yours, Linus Walleij