All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Joachim Eastwood <manabian@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH 1/3] pinctrl: core: create unlocked version of pinctrl_find_gpio_range_from_pin
Date: Thu, 25 Feb 2016 15:55:30 +0100	[thread overview]
Message-ID: <CACRpkda0Hu+A9C8yNEYx-vxvKvvM+xhpu_N2QWwT7K+WYOhOFQ@mail.gmail.com> (raw)
In-Reply-To: <CAGhQ9Vy6wLctan9-O-FOL6E2_HUhFcHcu+qbx_Ye3ai37w0esg@mail.gmail.com>

On Thu, Feb 25, 2016 at 12:19 PM, Joachim  Eastwood <manabian@gmail.com> wrote:

>> Or rather, pinctrl_fund_gpio_range_from_pin_locked(),
>> indicating that you're already holding the necessary lock
>> when calling the function. Now I'm even confusing myself,
>> sorry :(
>
> Shouldn't the function name indicate what the function does with the lock?
>
> pinctrl_fund_gpio_range_from_pin_unlocked() would indicate to me that
> it does not acquire a lock and it is your responsibility as a caller
> to ensure that the correct lock is held before calling.

OK hm maybe you're right, grep the kernel for precedents.

Yours,
Linus Walleij

  reply	other threads:[~2016-02-25 14:55 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-20 22:51 [PATCH 0/3] pinctrl: lpc18xx: support pint setup Joachim Eastwood
2016-02-20 22:51 ` [PATCH 1/3] pinctrl: core: create unlocked version of pinctrl_find_gpio_range_from_pin Joachim Eastwood
2016-02-25  9:21   ` Linus Walleij
2016-02-25  9:23     ` Linus Walleij
2016-02-25 11:19       ` Joachim Eastwood
2016-02-25 14:55         ` Linus Walleij [this message]
2016-02-25 15:15           ` Joachim Eastwood
2016-02-25 15:23             ` Linus Walleij
2016-02-20 22:51 ` [PATCH 2/3] pinctrl: lpc18xx: add nxp,gpio-pin-interrupt property Joachim Eastwood
     [not found] ` <1456008716-6236-1-git-send-email-manabian-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2016-02-20 22:51   ` [PATCH 3/3] pinctrl: lpc1850-scu: document nxp,gpio-pin-interrupt Joachim Eastwood
2016-02-22 19:11     ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACRpkda0Hu+A9C8yNEYx-vxvKvvM+xhpu_N2QWwT7K+WYOhOFQ@mail.gmail.com \
    --to=linus.walleij@linaro.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=manabian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.