From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-f174.google.com ([209.85.223.174]:41434 "EHLO mail-io0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934133AbeCBH7q (ORCPT ); Fri, 2 Mar 2018 02:59:46 -0500 Received: by mail-io0-f174.google.com with SMTP id q24so9872016ioh.8 for ; Thu, 01 Mar 2018 23:59:45 -0800 (PST) MIME-Version: 1.0 In-Reply-To: <20180227125700.6527-5-ville.syrjala@linux.intel.com> References: <20180227125700.6527-1-ville.syrjala@linux.intel.com> <20180227125700.6527-5-ville.syrjala@linux.intel.com> From: Linus Walleij Date: Fri, 2 Mar 2018 08:59:45 +0100 Message-ID: Subject: Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts To: Ville Syrjala Cc: "open list:DRM PANEL DRIVERS" , intel-gfx , Keith Packard , Daniel Vetter , Hans de Goede , Shashank Sharma , Stefan Agner , Thierry Reding , Boris Brezillon , Philipp Zabel , Laurent Pinchart , Manfred Schlaegl , Marek Vasut , Archit Taneja , Andrzej Hajda , Alison Wang , Eric Anholt , Linux-Renesas , Maxime Ripard Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: On Tue, Feb 27, 2018 at 1:56 PM, Ville Syrjala wrote: > From: Ville Syrj=C3=A4l=C3=A4 > > Currently we have a mix of static and dynamic information stored in > the display info structure. That makes it rather difficult to repopulate > the dynamic parts when a new EDID appears. Let's make life easier by > splitting the structure up into static and dynamic parts. > > The static part will consist of subpixel_order, panel_orientation, > and bus_formats. > > Actually I'm not sure where bus_formats & co. fit in all this. For some > drivers those seem to be static, even though they might fill them out > from .get_modes(). For other drivers this stuff even gets frobbed at > runtime, making it more some kind of a bastard encoder/connector state. > I'll just stick it into the static side so that the behaviour doesn't > change when I start clear out the entire dynamic state with memset(). > > Cc: Keith Packard > Cc: Daniel Vetter > Cc: Hans de Goede > Cc: Shashank Sharma > Cc: Stefan Agner > Cc: Thierry Reding > Cc: Boris Brezillon > Cc: Philipp Zabel > Cc: Laurent Pinchart > Cc: Manfred Schlaegl > Cc: Marek Vasut > Cc: Archit Taneja > Cc: Andrzej Hajda > Cc: Alison Wang > Cc: Eric Anholt > Cc: Linus Walleij > Cc: linux-renesas-soc@vger.kernel.org > Cc: Maxime Ripard > Signed-off-by: Ville Syrj=C3=A4l=C3=A4 Acked-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 From: Linus Walleij Subject: Re: [RFC][PATCH 04/11] drm: Split the display info into static and dynamic parts Date: Fri, 2 Mar 2018 08:59:45 +0100 Message-ID: References: <20180227125700.6527-1-ville.syrjala@linux.intel.com> <20180227125700.6527-5-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-io0-x22e.google.com (mail-io0-x22e.google.com [IPv6:2607:f8b0:4001:c06::22e]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3C9326ED89 for ; Fri, 2 Mar 2018 07:59:46 +0000 (UTC) Received: by mail-io0-x22e.google.com with SMTP id g21so9875779ioj.5 for ; Thu, 01 Mar 2018 23:59:46 -0800 (PST) In-Reply-To: <20180227125700.6527-5-ville.syrjala@linux.intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Ville Syrjala Cc: Marek Vasut , Linux-Renesas , Keith Packard , Laurent Pinchart , Boris Brezillon , Daniel Vetter , intel-gfx , Alison Wang , "open list:DRM PANEL DRIVERS" , Hans de Goede , Thierry Reding , Maxime Ripard List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBGZWIgMjcsIDIwMTggYXQgMTo1NiBQTSwgVmlsbGUgU3lyamFsYQo8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+IHdyb3RlOgoKPiBGcm9tOiBWaWxsZSBTeXJqw6Rsw6QgPHZp bGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+Cj4gQ3VycmVudGx5IHdlIGhhdmUgYSBtaXgg b2Ygc3RhdGljIGFuZCBkeW5hbWljIGluZm9ybWF0aW9uIHN0b3JlZCBpbgo+IHRoZSBkaXNwbGF5 IGluZm8gc3RydWN0dXJlLiBUaGF0IG1ha2VzIGl0IHJhdGhlciBkaWZmaWN1bHQgdG8gcmVwb3B1 bGF0ZQo+IHRoZSBkeW5hbWljIHBhcnRzIHdoZW4gYSBuZXcgRURJRCBhcHBlYXJzLiBMZXQncyBt YWtlIGxpZmUgZWFzaWVyIGJ5Cj4gc3BsaXR0aW5nIHRoZSBzdHJ1Y3R1cmUgdXAgaW50byBzdGF0 aWMgYW5kIGR5bmFtaWMgcGFydHMuCj4KPiBUaGUgc3RhdGljIHBhcnQgd2lsbCBjb25zaXN0IG9m IHN1YnBpeGVsX29yZGVyLCBwYW5lbF9vcmllbnRhdGlvbiwKPiBhbmQgYnVzX2Zvcm1hdHMuCj4K PiBBY3R1YWxseSBJJ20gbm90IHN1cmUgd2hlcmUgYnVzX2Zvcm1hdHMgJiBjby4gZml0IGluIGFs bCB0aGlzLiBGb3Igc29tZQo+IGRyaXZlcnMgdGhvc2Ugc2VlbSB0byBiZSBzdGF0aWMsIGV2ZW4g dGhvdWdoIHRoZXkgbWlnaHQgZmlsbCB0aGVtIG91dAo+IGZyb20gLmdldF9tb2RlcygpLiBGb3Ig b3RoZXIgZHJpdmVycyB0aGlzIHN0dWZmIGV2ZW4gZ2V0cyBmcm9iYmVkIGF0Cj4gcnVudGltZSwg bWFraW5nIGl0IG1vcmUgc29tZSBraW5kIG9mIGEgYmFzdGFyZCBlbmNvZGVyL2Nvbm5lY3RvciBz dGF0ZS4KPiBJJ2xsIGp1c3Qgc3RpY2sgaXQgaW50byB0aGUgc3RhdGljIHNpZGUgc28gdGhhdCB0 aGUgYmVoYXZpb3VyIGRvZXNuJ3QKPiBjaGFuZ2Ugd2hlbiBJIHN0YXJ0IGNsZWFyIG91dCB0aGUg ZW50aXJlIGR5bmFtaWMgc3RhdGUgd2l0aCBtZW1zZXQoKS4KPgo+IENjOiBLZWl0aCBQYWNrYXJk IDxrZWl0aHBAa2VpdGhwLmNvbT4KPiBDYzogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBm ZndsbC5jaD4KPiBDYzogSGFucyBkZSBHb2VkZSA8aGRlZ29lZGVAcmVkaGF0LmNvbT4KPiBDYzog U2hhc2hhbmsgU2hhcm1hIDxzaGFzaGFuay5zaGFybWFAaW50ZWwuY29tPgo+IENjOiBTdGVmYW4g QWduZXIgPHN0ZWZhbkBhZ25lci5jaD4KPiBDYzogVGhpZXJyeSBSZWRpbmcgPHRoaWVycnkucmVk aW5nQGdtYWlsLmNvbT4KPiBDYzogQm9yaXMgQnJlemlsbG9uIDxib3Jpcy5icmV6aWxsb25AYm9v dGxpbi5jb20+Cj4gQ2M6IFBoaWxpcHAgWmFiZWwgPHAuemFiZWxAcGVuZ3V0cm9uaXguZGU+Cj4g Q2M6IExhdXJlbnQgUGluY2hhcnQgPGxhdXJlbnQucGluY2hhcnRAaWRlYXNvbmJvYXJkLmNvbT4K PiBDYzogTWFuZnJlZCBTY2hsYWVnbCA8bWFuZnJlZC5zY2hsYWVnbEBnbXguYXQ+Cj4gQ2M6IE1h cmVrIFZhc3V0IDxtYXJleEBkZW54LmRlPgo+IENjOiBBcmNoaXQgVGFuZWphIDxhcmNoaXR0QGNv ZGVhdXJvcmEub3JnPgo+IENjOiBBbmRyemVqIEhhamRhIDxhLmhhamRhQHNhbXN1bmcuY29tPgo+ IENjOiBBbGlzb24gV2FuZyA8YWxpc29uLndhbmdAZnJlZXNjYWxlLmNvbT4KPiBDYzogRXJpYyBB bmhvbHQgPGVyaWNAYW5ob2x0Lm5ldD4KPiBDYzogTGludXMgV2FsbGVpaiA8bGludXMud2FsbGVp akBsaW5hcm8ub3JnPgo+IENjOiBsaW51eC1yZW5lc2FzLXNvY0B2Z2VyLmtlcm5lbC5vcmcKPiBD YzogTWF4aW1lIFJpcGFyZCA8bWF4aW1lLnJpcGFyZEBib290bGluLmNvbT4KPiBTaWduZWQtb2Zm LWJ5OiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgoKQWNr ZWQtYnk6IExpbnVzIFdhbGxlaWogPGxpbnVzLndhbGxlaWpAbGluYXJvLm9yZz4KCllvdXJzLApM aW51cyBXYWxsZWlqCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fCmRyaS1kZXZlbCBtYWlsaW5nIGxpc3QKZHJpLWRldmVsQGxpc3RzLmZyZWVkZXNrdG9wLm9y ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2RyaS1kZXZl bAo=