From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0DFEFC6FD1D for ; Thu, 23 Mar 2023 08:19:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229953AbjCWITB (ORCPT ); Thu, 23 Mar 2023 04:19:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45228 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229729AbjCWITA (ORCPT ); Thu, 23 Mar 2023 04:19:00 -0400 Received: from mail-yb1-xb35.google.com (mail-yb1-xb35.google.com [IPv6:2607:f8b0:4864:20::b35]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 015D52F7AA for ; Thu, 23 Mar 2023 01:18:59 -0700 (PDT) Received: by mail-yb1-xb35.google.com with SMTP id p204so12733997ybc.12 for ; Thu, 23 Mar 2023 01:18:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1679559539; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Vkv5VdVcKoH0lEtU7ovkoGNklSMRmsrrWrNv42U6G7c=; b=Cc/yPVEY4QAUF/ywhzOPmHsUxVasaxgi5unp7BcQpz7kFgSFSOsOc6stK+M67F0EMs Mcp0CSBvGnuUHIwrPlRXKJXBWahsOncIq2vZ62c/2dJedabv/HL0SEOrKzFhh6GKCQMg iwmZlmx4B14vLsSraUmgiVjXItf5QhKpl9qTGkyUfEqLWfejnCCp+lW8egZVssfmhQCi R1a/rP+NYKbcoUJ7BA72vrkkc+Iak69iNjix/ATGO85qcFszNaYcl2CorBqs8BaUoH/U MpvmGhF+DaBvLjKbaxw1HwRg3OWh3tFIdZ+E2Yuh4Vryx6Hg8d29Z+n2XEwUk9h5cdJ0 HH4g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1679559539; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Vkv5VdVcKoH0lEtU7ovkoGNklSMRmsrrWrNv42U6G7c=; b=fz3BvwBqflGg54stQDEYH83HUcTkznAY8yNc7CF5BXoJHs27Fs3DVwskgP61CjXL9h r17Tbj904vWYeqZvd3d3oMukWKIwEzBMv474FFoIEyZniV7maHmd8tI/acRpru9gbPOg b1MrMuD/qdwswlY5KQd54Bf6BhUtBogdTeMIOtn4uYdobtfwV91h/SaQkxBYEt9c1SHY qjuvRG7Rw15xMXM831XvMuX1CCvY84Peh/WcGupvGqyPV1vSo7WDftXQG3fGLSE7xH82 EV0bzytoNDKSpIKzOvYJH9sxvyXnMl2l1sM6iJl9qpKVMGIOqgKezY3IddS+s6C9Y139 ex0g== X-Gm-Message-State: AAQBX9dIcsrWNwZsIjKISBRY9fAmoVCTSgBr5IWuihq0AqodqmZwmhsF Ucxg6T1R5XbPLPE6dG6J+y8ZMgj59yLDNAls6Phoww== X-Google-Smtp-Source: AKy350ZLjXimPRHI6+yc14ua1fcJNf6TG9LroRTyO0u5TDtff6repGmXTQ0oSPcWRJp5dKk1DBj5utR/QLM4AQPxnF8= X-Received: by 2002:a25:8712:0:b0:b74:3236:2fac with SMTP id a18-20020a258712000000b00b7432362facmr1730213ybl.4.1679559539253; Thu, 23 Mar 2023 01:18:59 -0700 (PDT) MIME-Version: 1.0 References: <20230321135412.73240-1-andriy.shevchenko@linux.intel.com> <20230321135412.73240-2-andriy.shevchenko@linux.intel.com> In-Reply-To: <20230321135412.73240-2-andriy.shevchenko@linux.intel.com> From: Linus Walleij Date: Thu, 23 Mar 2023 09:18:48 +0100 Message-ID: Subject: Re: [PATCH v1 2/2] gpiolib: Check array_info for NULL only once in gpiod_get_array() To: Andy Shevchenko Cc: Bartosz Golaszewski , linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Bartosz Golaszewski Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Tue, Mar 21, 2023 at 2:53=E2=80=AFPM Andy Shevchenko wrote: > gpiod_get_array() has a long if-else-if branching where each of them > tests for the same variable to be not NULL. Instead, check for NULL > before even going to that flow. > > Signed-off-by: Andy Shevchenko It's way more readable like this. Reviewed-by: Linus Walleij Yours, Linus Walleij