From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io1-f65.google.com ([209.85.166.65]:39252 "EHLO mail-io1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726973AbeIJL6f (ORCPT ); Mon, 10 Sep 2018 07:58:35 -0400 Received: by mail-io1-f65.google.com with SMTP id l7-v6so6175094iok.6 for ; Mon, 10 Sep 2018 00:06:02 -0700 (PDT) MIME-Version: 1.0 References: <20180905132618.31274-1-vincent.whitchurch@axis.com> In-Reply-To: From: Linus Walleij Date: Mon, 10 Sep 2018 09:05:50 +0200 Message-ID: Subject: Re: [PATCH 1/2] gpio: mockup: Allow probing from device tree Content-Type: text/plain; charset="UTF-8" Sender: devicetree-owner@vger.kernel.org To: Bartosz Golaszewski Cc: vincent.whitchurch@axis.com, "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Rabin Vincent List-ID: On Thu, Sep 6, 2018 at 6:29 PM Bartosz Golaszewski wrote: > 2018-09-05 15:26 GMT+02:00 Vincent Whitchurch : > > + ret = of_property_read_u32(node, "nr-gpios", &nr_gpios); > > In addition to what Linus already said: I think this is a good moment > to get rid of the platform data structure and instead use device > properties, what do you think? If you're thinking of fwnode that will not work with static platform devices (such as add with board files or other random platform_device_register() etc) The fwnode concept only works with DT and ACPI. Yours, Linus Walleij