From: Linus Walleij <linus.walleij@linaro.org>
To: cgel.zte@gmail.com
Cc: Damien.Horsley@imgtec.com, abrestic@chromium.org,
ezequiel.garcia@imgtec.com, govindraj.raja@imgtec.com,
linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org,
lv.ruyi@zte.com.cn, Zeal Robot <zealci@zte.com.cn>
Subject: Re: [PATCH v2] pinctrl: fix error check return value of irq_of_parse_and_map()
Date: Sun, 24 Apr 2022 16:25:07 +0200 [thread overview]
Message-ID: <CACRpkda4Q7M0KNnSx3OP45mdEg2YQiw2bk1JGiHgy8PSuK9adw@mail.gmail.com> (raw)
In-Reply-To: <20220424031430.3170759-1-lv.ruyi@zte.com.cn>
On Sun, Apr 24, 2022 at 5:14 AM <cgel.zte@gmail.com> wrote:
> From: Lv Ruyi <lv.ruyi@zte.com.cn>
>
> The irq_of_parse_and_map() function returns 0 on failure, and does not
> return an negative value.
>
> Fixes: cefc03e5995e ("pinctrl: Add Pistachio SoC pin control driver")
> Reported-by: Zeal Robot <zealci@zte.com.cn>
> Signed-off-by: Lv Ruyi <lv.ruyi@zte.com.cn>
> ---
> v2: don't print irq, and return -EINVAL rather than 0
Patch applied for fixes (changed the subject a bit).
Thanks!
Linus Walleij
prev parent reply other threads:[~2022-04-24 14:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 8:52 [PATCH] pinctrl: fix error check return value of irq_of_parse_and_map() cgel.zte
2022-04-24 3:14 ` [PATCH v2] " cgel.zte
2022-04-24 14:25 ` Linus Walleij [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACRpkda4Q7M0KNnSx3OP45mdEg2YQiw2bk1JGiHgy8PSuK9adw@mail.gmail.com \
--to=linus.walleij@linaro.org \
--cc=Damien.Horsley@imgtec.com \
--cc=abrestic@chromium.org \
--cc=cgel.zte@gmail.com \
--cc=ezequiel.garcia@imgtec.com \
--cc=govindraj.raja@imgtec.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lv.ruyi@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.