From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 24060C433DF for ; Thu, 14 May 2020 08:24:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06D0120675 for ; Thu, 14 May 2020 08:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iIm3W3vx" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726184AbgENIYm (ORCPT ); Thu, 14 May 2020 04:24:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1725935AbgENIYl (ORCPT ); Thu, 14 May 2020 04:24:41 -0400 Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5E5F1C061A0C for ; Thu, 14 May 2020 01:24:41 -0700 (PDT) Received: by mail-lj1-x244.google.com with SMTP id a21so2482186ljj.11 for ; Thu, 14 May 2020 01:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=iIm3W3vxPyvQT8hBr8kR8u+6yVBH0h6bfGPXKdobARfet5qpx6e2NJwbGUoVD4BTiz kvpn1tyKA+LwVUJc8z8fF1ZwXlCreaNrldq4vaEDBNH9cKFjh4tAUHQkvEkgZrv38eDN o2gz3Js+ZsuW3daffpbxtnkSsvbVGjH/1ch+B53s3SDAzYlJpVIgVSGq9BIdUF43U3J3 PYEdm9THYdzNqhqnu0YtajA3OhEFK2moz2+zytOAdmmOqgbfZNV8YpRwBfYf+FcYfKP1 slXNCbKogiAPZuvMbATklfcba8DSvlZ/NhggKTK4KlzEC8fEhJbI/SNZCFcSB3u8yrD/ oIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=UQ9reeEHXY1w4DQEW4rkf/HYRPO/a1HS4t5rID6RKgN1FFdpfEo2kAecexUZSZTUzS qQhX1zlafUv8WaGZkbNJysCDVnVqWM6/CmcPbA2jATINCztUROPV/GoPSKuxiDK921DX lUYzdj3z4ox3KO4bGgGzp/YWTAylxnz04wTJ2hxbStsszAa/FdHW4v8aVj5bwVZcTcjn ao0Syx4e9CH4ARSs5sbpUUjE7VdukDwB71DWKC3ZWoYhaWvXUBMDHASXSrMjxdGRa4UH GyDg4kukORu+7xgBnHNEIl+e1Mdfd2tMzUYEcpV8ncrMICPIWmxBm0gUEbSpXW0z94Rp zNYQ== X-Gm-Message-State: AOAM532Cwly5v0gLRrvl/h5azsv+DEl4n/736UCuws0fIGKdm2QfLqLR QO28JUFu9TmIYEw4gheHH3GIbZloNBiku/jxcVm68A== X-Google-Smtp-Source: ABdhPJzbR0lONsL+LHNQ562bI+zZx3vzCrNYamk5GJI5zjbv9WVScZ7rOiUe3C6sarzGNmAWB4jF6RMUNqx0dbXgSxU= X-Received: by 2002:a2e:8805:: with SMTP id x5mr2073815ljh.223.1589444679816; Thu, 14 May 2020 01:24:39 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Thu, 14 May 2020 10:24:28 +0200 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: dillon.minfei@gmail.com Cc: Rob Herring , Maxime Coquelin , Alexandre TORGUE , "thierry.reding@gmail.com" , Sam Ravnborg , Dave Airlie , Daniel Vetter , Michael Turquette , Stephen Boyd , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-stm32@st-md-mailman.stormreply.com, Linux ARM , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-clk Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2020 at 9:04 AM wrote: > From: dillon min > > Enable the ltdc & ili9341 on stm32429-disco board. > > Signed-off-by: dillon min This mostly looks good but... > +&spi5 { > + status = "okay"; > + pinctrl-0 = <&spi5_pins>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > + dmas = <&dma2 3 2 0x400 0x0>, > + <&dma2 4 2 0x400 0x0>; > + dma-names = "rx", "tx"; These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where &spi5 is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6BA93C433E0 for ; Thu, 14 May 2020 08:24:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 329DE206BE for ; Thu, 14 May 2020 08:24:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="E/Eu4x3F"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iIm3W3vx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 329DE206BE Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mxQO0gIbXwx59oqGHnUHdvKCRLS/LHBC6s3e9GxKGsw=; b=E/Eu4x3FBjdXdx 4Vff+neFGxQQAcOOav139RUV/pBRtirP0MStDcn0u1n35gg7CY5EE0QwYi4VBwZ1f+aw5Oh+999ft GitBenf5K3geo8/r6Cq+FCtJIu0GanaBlQHx8uHIgtyTwVNJKMzQAUrNoPFZIVyTr7nmyFV1ONt9K DzoSX/bckTrDMV3ETHoMmhhCKXvAV/KhNcHEVxbeaRuljFNLcIgyAeNnoBJhcpz5M/9tRxxoeK3oF BJjQkFAOH1EJNjIpDaBy7+NarnpHvvecI/a4ssvpfUnH6JgleiIOUn7hNWvTfOtAvneDu8Rk4wGPw bBRggR8YV/+XCCIQnxKg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ9Aa-0006Lc-2Y; Thu, 14 May 2020 08:24:44 +0000 Received: from mail-lj1-x244.google.com ([2a00:1450:4864:20::244]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jZ9AX-0006LD-9y for linux-arm-kernel@lists.infradead.org; Thu, 14 May 2020 08:24:42 +0000 Received: by mail-lj1-x244.google.com with SMTP id b6so2568866ljj.1 for ; Thu, 14 May 2020 01:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=iIm3W3vxPyvQT8hBr8kR8u+6yVBH0h6bfGPXKdobARfet5qpx6e2NJwbGUoVD4BTiz kvpn1tyKA+LwVUJc8z8fF1ZwXlCreaNrldq4vaEDBNH9cKFjh4tAUHQkvEkgZrv38eDN o2gz3Js+ZsuW3daffpbxtnkSsvbVGjH/1ch+B53s3SDAzYlJpVIgVSGq9BIdUF43U3J3 PYEdm9THYdzNqhqnu0YtajA3OhEFK2moz2+zytOAdmmOqgbfZNV8YpRwBfYf+FcYfKP1 slXNCbKogiAPZuvMbATklfcba8DSvlZ/NhggKTK4KlzEC8fEhJbI/SNZCFcSB3u8yrD/ oIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=lyBj7Ep6MMsVAi86LXHvaJ0rSNg7AYxo3AZnbMCfBpiu2ixXKyqWq+rjRs719SgrMS N2v6GV5CfjAoXNyAjzyfBu2ZbIgoYphdhsp+Ry0rDpziYB2F/ohqBWdUfq+oxallMPwH 8gOSgPqzkf+9edBhRx6Q2lANHXEQP6aR/4keSQpBjSvcQSKT4bWK2WZDqYEUq0nuD2cn x8UV7pQATs7oYXZuxabTBtM4Vr8y0HqSNZYwNF+5mmL/vuqyuf+uFZBOG4Jtwmt4wEuM VfaLNC5gk2tJ/43F9Ac2zfryJig6iJm/BzbCpdPeq9VutcSlSIICSpEyV3MYmp+AgPdw Nwbw== X-Gm-Message-State: AOAM5306+xpEys5zCs9gRHSrU0ccpkRK42kBfa6DiNKuo+T5oWMk4avo +9f9MfkRrdeivgS3c9ypZJJhfawEWEM6zsr/NuWNnjZhOEc= X-Google-Smtp-Source: ABdhPJzbR0lONsL+LHNQ562bI+zZx3vzCrNYamk5GJI5zjbv9WVScZ7rOiUe3C6sarzGNmAWB4jF6RMUNqx0dbXgSxU= X-Received: by 2002:a2e:8805:: with SMTP id x5mr2073815ljh.223.1589444679816; Thu, 14 May 2020 01:24:39 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Thu, 14 May 2020 10:24:28 +0200 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: dillon.minfei@gmail.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200514_012441_345654_96508184 X-CRM114-Status: GOOD ( 12.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Alexandre TORGUE , Dave Airlie , Michael Turquette , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-clk , Stephen Boyd , Rob Herring , "thierry.reding@gmail.com" , Maxime Coquelin , Daniel Vetter , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, May 12, 2020 at 9:04 AM wrote: > From: dillon min > > Enable the ltdc & ili9341 on stm32429-disco board. > > Signed-off-by: dillon min This mostly looks good but... > +&spi5 { > + status = "okay"; > + pinctrl-0 = <&spi5_pins>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > + dmas = <&dma2 3 2 0x400 0x0>, > + <&dma2 4 2 0x400 0x0>; > + dma-names = "rx", "tx"; These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where &spi5 is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 00044C433E1 for ; Thu, 14 May 2020 08:24:43 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CEBC120675 for ; Thu, 14 May 2020 08:24:43 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="iIm3W3vx" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CEBC120675 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id CC5976E2F9; Thu, 14 May 2020 08:24:42 +0000 (UTC) Received: from mail-lj1-x244.google.com (mail-lj1-x244.google.com [IPv6:2a00:1450:4864:20::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6E8296E2EA for ; Thu, 14 May 2020 08:24:41 +0000 (UTC) Received: by mail-lj1-x244.google.com with SMTP id f18so2478415lja.13 for ; Thu, 14 May 2020 01:24:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=iIm3W3vxPyvQT8hBr8kR8u+6yVBH0h6bfGPXKdobARfet5qpx6e2NJwbGUoVD4BTiz kvpn1tyKA+LwVUJc8z8fF1ZwXlCreaNrldq4vaEDBNH9cKFjh4tAUHQkvEkgZrv38eDN o2gz3Js+ZsuW3daffpbxtnkSsvbVGjH/1ch+B53s3SDAzYlJpVIgVSGq9BIdUF43U3J3 PYEdm9THYdzNqhqnu0YtajA3OhEFK2moz2+zytOAdmmOqgbfZNV8YpRwBfYf+FcYfKP1 slXNCbKogiAPZuvMbATklfcba8DSvlZ/NhggKTK4KlzEC8fEhJbI/SNZCFcSB3u8yrD/ oIKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Jkb8BxKnl71QcTSlAQifB2QDBHTd1utKf7Tuku0XIK4=; b=EhDaVwuxEB5248EUPDVaLdD33n0x1dB8VqZ0KePlr3IePqcUWG9x0RO51wfxud2z92 177wzJAVDyu1q6xaZc3dtyE5hHg8nPflGPeJ+Cs9omUNteXfdvoddMklmRY0/67AkxY5 gy9MSt4uAeucWATJTedhwl6N7M2MqEe2bw5qvQolmBt56pc9u9fa0vTGZfmrvFRaLDP9 WFA3CqdV1aSieEw/b07DLlRoTDlzmi0eCObTQubJq6QTy6a4B7+LgTdU/OJfv3BCF3cd iuOSQzA7Sjzn7gt5R1DDEYrXdSxvjhhNTZCEr347laJ4bNMyICx0A5+Y649XfHC9aqdD K26Q== X-Gm-Message-State: AOAM530TLIaVX0UxaSUGA11/ksTiX4hW5gObj4sNSL2zXZ/vVZahMuRj SFNBuyxZaoVfKnzWfUe/qyghpppB5HG6mbD2AvbTWg== X-Google-Smtp-Source: ABdhPJzbR0lONsL+LHNQ562bI+zZx3vzCrNYamk5GJI5zjbv9WVScZ7rOiUe3C6sarzGNmAWB4jF6RMUNqx0dbXgSxU= X-Received: by 2002:a2e:8805:: with SMTP id x5mr2073815ljh.223.1589444679816; Thu, 14 May 2020 01:24:39 -0700 (PDT) MIME-Version: 1.0 References: <1589267017-17294-1-git-send-email-dillon.minfei@gmail.com> <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> In-Reply-To: <1589267017-17294-4-git-send-email-dillon.minfei@gmail.com> From: Linus Walleij Date: Thu, 14 May 2020 10:24:28 +0200 Message-ID: Subject: Re: [PATCH v3 3/5] ARM: dts: stm32: enable ltdc binding with ili9341 on stm32429-disco board To: dillon.minfei@gmail.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Alexandre TORGUE , Dave Airlie , Michael Turquette , "linux-kernel@vger.kernel.org" , "open list:DRM PANEL DRIVERS" , linux-clk , Stephen Boyd , Rob Herring , "thierry.reding@gmail.com" , Maxime Coquelin , Sam Ravnborg , linux-stm32@st-md-mailman.stormreply.com, Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, May 12, 2020 at 9:04 AM wrote: > From: dillon min > > Enable the ltdc & ili9341 on stm32429-disco board. > > Signed-off-by: dillon min This mostly looks good but... > +&spi5 { > + status = "okay"; > + pinctrl-0 = <&spi5_pins>; > + pinctrl-names = "default"; > + #address-cells = <1>; > + #size-cells = <0>; > + cs-gpios = <&gpioc 2 GPIO_ACTIVE_LOW>; > + dmas = <&dma2 3 2 0x400 0x0>, > + <&dma2 4 2 0x400 0x0>; > + dma-names = "rx", "tx"; These DMA assignments seem to be SoC things and should rather be in the DTS(I) file where &spi5 is defined, right? stm32f429.dtsi I suppose? It is likely the same no matter which device is using spi5. Yours, Linus Walleij _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel