From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A83DC4361B for ; Sat, 5 Dec 2020 23:02:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6AABC23121 for ; Sat, 5 Dec 2020 23:02:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727026AbgLEXCb (ORCPT ); Sat, 5 Dec 2020 18:02:31 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55738 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726023AbgLEXCa (ORCPT ); Sat, 5 Dec 2020 18:02:30 -0500 Received: from mail-lj1-x243.google.com (mail-lj1-x243.google.com [IPv6:2a00:1450:4864:20::243]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D8B6C0613CF for ; Sat, 5 Dec 2020 15:01:44 -0800 (PST) Received: by mail-lj1-x243.google.com with SMTP id t22so10881886ljk.0 for ; Sat, 05 Dec 2020 15:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XCSFQKcvlFjkvLCpcBuUUtC1CDOf71V8SqchdVnabE4=; b=Zg823BvS2desl9AuzFGxccRF6I1+rDCSbCAg0dMS3yYYBcDdSiUrTdZRltaYtobKYV pM2hVbsdl991GGaQz6VM18Nvri8NDwPXpysns07Piqi5VB0wZGn68+ZiXN9OuNvuGV0W 1kKaZhQA7Kugk4TrHxBwxJPMqz4Pg3n/D61rrnw9eDczzBZ7/FJuzlF0fiAaCOY9OJVR xo+4zlm88h+ebljPJzS+lBfBKrdwGonz5xyTzB+LHd5ouviPApjhlP4tiXEAaEw93Quw 74PWLAUEgsLbkKB6tzUMloWKUZZcjA+cDkt0ZaWsxlpRkEoh7lWxcvcY01rEhfqQMUja D5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XCSFQKcvlFjkvLCpcBuUUtC1CDOf71V8SqchdVnabE4=; b=hXcPuf5A1ti63ANSn/w/OwI9S5UBh0M7OC6m+r/v22/8OOsfwPA5Z/E85qiios3ASf CA5OcJ2vMHTRkKXHgLDj604rSVrgrbVUfiYvkBFV7qgtJroFiaq6bSjyEGVKDomUjzME pT6l9uloHuqt2ZcigPHlaAKRS0fvuTRXlE/AdfsUJ8UYYLQDv12R8whNaRrS1HNB5Cm7 wq4IbMD30nz9aIrGOKRfWi+P33WpgHSGO9UTS3ptjIaXiqtng04Nk0yqGkVfhxMqXCEr YjBST9PdQDt1l+N2IKtC54/Ca66reLvK1B9bKISpxA/iyetD6tS4T7Oha2FRUwVr+KoY c4gQ== X-Gm-Message-State: AOAM532VXGe/ffwpNxT5EgWH6SfvXTi9ZoEBcwU5YRJk6eSID1DDyFTo qHW+g6cl/JnwVvKTzTyaLp7Mx79blUOL6FbnuxYyeA== X-Google-Smtp-Source: ABdhPJynyKDo2PXUU2VopTAfxDCvs+UnAN5Rm8GKFqYK8TEgnkXG0hfZ5PVsr0IlUZ50Nxnlm1KyV77sUyQFQ5Kq5yo= X-Received: by 2002:a05:651c:c2:: with SMTP id 2mr5761217ljr.104.1607209302955; Sat, 05 Dec 2020 15:01:42 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202150205.20150-5-muhammad.husaini.zulkifli@intel.com> In-Reply-To: From: Linus Walleij Date: Sun, 6 Dec 2020 00:01:32 +0100 Message-ID: Subject: Re: [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: "Zulkifli, Muhammad Husaini" Cc: Ulf Hansson , "Hunter, Adrian" , Michal Simek , linux-mmc , Linux ARM , "linux-kernel@vger.kernel.org" , "Shevchenko, Andriy" , "Raja Subramanian, Lakshmi Bai" , "Wan Mohamad, Wan Ahmad Zainie" , Mark Gross Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 3, 2020 at 8:10 AM Zulkifli, Muhammad Husaini wrote: > >Yeah it has to be called from somewhere, if you want an abstraction to make > >the driver neutral to any machine, then use a selector regulator. It can be > >placed anywhere in the kernel as long as you can reference it. > > Sorry. I am not really aware of selector regulator. Can you point me to any references > for this? It is part of the regulator subsystem and the standard framework there to handle regulators with an enumerable number of specific voltage levels. > IMHO, we do not need to overengineered it to add custom selector > regulator just to suit this Keem Bay HW design. That can be said about a lot of things we model with vqmmc. Using standard abstractions makes things easier for maintainers. We mostly design abstractions for maintenance not for the simplest way to set bits in registers. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83FF5C433FE for ; Sat, 5 Dec 2020 23:03:40 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 38CEC22E03 for ; Sat, 5 Dec 2020 23:03:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 38CEC22E03 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LSHj7k/Rx2wfpR1/ceH9EiyZY04PblSTXoFH0zplodA=; b=KXywcpDIxfnO9zwZXoGANPm/3 guP+nX8/nRzWUR2pTw3cfQzVjhaZKq9f0hMN18mrHOO19rzZA093mr1n4smSW+GNUlcCzMinK7ze/ 0GmYHYR3FXjCpHQca/deTU1V9dagE8N4Lieprt0cxPO/w66eS7Pbdt3j0XWcYIBv3BKdcqzhh9syK ZWZU/ofh7U1RO2ZguFgoyxcyU7AkVFSwtAv0oX0qD++PPlGhuQx9w2rVRcUESCt3UPj0+NHNVs9Y8 JQaqBJhDmNNg4SaCXHK7ABQ46XwlLvvlqV81SLLsFBdGrjjgyWkKJX6AbVtaeNA87A81riPrmlq4r mJNlDHPFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1klgYm-0000mt-Md; Sat, 05 Dec 2020 23:01:48 +0000 Received: from mail-lj1-x243.google.com ([2a00:1450:4864:20::243]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1klgYi-0000mZ-QY for linux-arm-kernel@lists.infradead.org; Sat, 05 Dec 2020 23:01:46 +0000 Received: by mail-lj1-x243.google.com with SMTP id s9so10807569ljo.11 for ; Sat, 05 Dec 2020 15:01:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=XCSFQKcvlFjkvLCpcBuUUtC1CDOf71V8SqchdVnabE4=; b=Zg823BvS2desl9AuzFGxccRF6I1+rDCSbCAg0dMS3yYYBcDdSiUrTdZRltaYtobKYV pM2hVbsdl991GGaQz6VM18Nvri8NDwPXpysns07Piqi5VB0wZGn68+ZiXN9OuNvuGV0W 1kKaZhQA7Kugk4TrHxBwxJPMqz4Pg3n/D61rrnw9eDczzBZ7/FJuzlF0fiAaCOY9OJVR xo+4zlm88h+ebljPJzS+lBfBKrdwGonz5xyTzB+LHd5ouviPApjhlP4tiXEAaEw93Quw 74PWLAUEgsLbkKB6tzUMloWKUZZcjA+cDkt0ZaWsxlpRkEoh7lWxcvcY01rEhfqQMUja D5Gg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=XCSFQKcvlFjkvLCpcBuUUtC1CDOf71V8SqchdVnabE4=; b=LB0WQ8qIlrIM/sOPzcBXjNggODfKZU2edk/8vmaWHSgfVwOS6Z3VsuTEG+ltsPuhGo 2FsPMZpkNySZcq0ViYcFg4CPNb90/X1VtrQPgbbuR0ewtXddgVBHcO8twfBWBW6aKXp8 iz2EtaIh3UWkOPPSDhAKEfoemiau1Tw1n1gxKJdYM55BBJwObgP6vrj6NRhuL8EuDzNp vxsmlAlQwdfEo6npBkpwhQ3PJO1dfsOdZuOiYD+lXO99weDW+rNpjUVOqyc5xfbS00JB yaSEyvamRQSicautjJ4NxF6L6SS1GA78bvq/9qGdRnn/yqS+ywy4X/sF5hCYDYDruFti Bz1A== X-Gm-Message-State: AOAM532RM/9DW8WF+9eJTyFEj3pQLbu21IYMpEJvhWGnsuEiL7cgCSNh E/xH2E4y4BtuT397Nb/2vugCPR9uHDoXVvjoten3fA== X-Google-Smtp-Source: ABdhPJynyKDo2PXUU2VopTAfxDCvs+UnAN5Rm8GKFqYK8TEgnkXG0hfZ5PVsr0IlUZ50Nxnlm1KyV77sUyQFQ5Kq5yo= X-Received: by 2002:a05:651c:c2:: with SMTP id 2mr5761217ljr.104.1607209302955; Sat, 05 Dec 2020 15:01:42 -0800 (PST) MIME-Version: 1.0 References: <20201202150205.20150-1-muhammad.husaini.zulkifli@intel.com> <20201202150205.20150-5-muhammad.husaini.zulkifli@intel.com> In-Reply-To: From: Linus Walleij Date: Sun, 6 Dec 2020 00:01:32 +0100 Message-ID: Subject: Re: [PATCH v6 4/4] mmc: sdhci-of-arasan: Enable UHS-1 support for Keem Bay SOC To: "Zulkifli, Muhammad Husaini" X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201205_180145_271879_665BDE05 X-CRM114-Status: GOOD ( 12.69 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ulf Hansson , Mark Gross , "Shevchenko, Andriy" , "Raja Subramanian, Lakshmi Bai" , linux-mmc , "linux-kernel@vger.kernel.org" , "Hunter, Adrian" , "Wan Mohamad, Wan Ahmad Zainie" , Michal Simek , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Dec 3, 2020 at 8:10 AM Zulkifli, Muhammad Husaini wrote: > >Yeah it has to be called from somewhere, if you want an abstraction to make > >the driver neutral to any machine, then use a selector regulator. It can be > >placed anywhere in the kernel as long as you can reference it. > > Sorry. I am not really aware of selector regulator. Can you point me to any references > for this? It is part of the regulator subsystem and the standard framework there to handle regulators with an enumerable number of specific voltage levels. > IMHO, we do not need to overengineered it to add custom selector > regulator just to suit this Keem Bay HW design. That can be said about a lot of things we model with vqmmc. Using standard abstractions makes things easier for maintainers. We mostly design abstractions for maintenance not for the simplest way to set bits in registers. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel