From: Linus Walleij <linus.walleij@linaro.org>
To: Loic Poulain <loic.poulain@linaro.org>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
michal.koziel@emlogic.no
Subject: Re: [PATCH] gpio: mxc: Fix disabled interrupt wake-up support
Date: Thu, 17 Jun 2021 16:36:15 +0200 [thread overview]
Message-ID: <CACRpkda=6-VkRtrBzxkzWYzcRWEYEcYUy15ALuRv6GFb=oCyZg@mail.gmail.com> (raw)
In-Reply-To: <1623938053-790-1-git-send-email-loic.poulain@linaro.org>
On Thu, Jun 17, 2021 at 3:44 PM Loic Poulain <loic.poulain@linaro.org> wrote:
> A disabled/masked interrupt marked as wakeup source must be re-enable
> and unmasked in order to be able to wake-up the host. That can be done
> by flaging the irqchip with IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND.
>
> Note: It 'sometimes' works without that change, but only thanks to the
> lazy generic interrupt disabling (keeping interrupt unmasked).
>
> Reported-by: Michal Koziel <michal.koziel@emlogic.no>
> Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Looks correct:
Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-06-17 14:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-17 13:54 [PATCH] gpio: mxc: Fix disabled interrupt wake-up support Loic Poulain
2021-06-17 14:36 ` Linus Walleij [this message]
2021-06-21 18:44 ` Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda=6-VkRtrBzxkzWYzcRWEYEcYUy15ALuRv6GFb=oCyZg@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=bgolaszewski@baylibre.com \
--cc=linux-gpio@vger.kernel.org \
--cc=loic.poulain@linaro.org \
--cc=michal.koziel@emlogic.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.