From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3BFE7C433F5 for ; Tue, 24 May 2022 07:25:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235196AbiEXHZa (ORCPT ); Tue, 24 May 2022 03:25:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:32946 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234375AbiEXHZ0 (ORCPT ); Tue, 24 May 2022 03:25:26 -0400 Received: from mail-yb1-xb29.google.com (mail-yb1-xb29.google.com [IPv6:2607:f8b0:4864:20::b29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id C8C5E97282 for ; Tue, 24 May 2022 00:25:23 -0700 (PDT) Received: by mail-yb1-xb29.google.com with SMTP id o80so29434792ybg.1 for ; Tue, 24 May 2022 00:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=wPGM+6wvYQzYXBkWVp8pdxQXBtD/ig4S7bFkR4MsUl8/n209nSMc2p6HwXgKOnXj+D ThJnMq7NlzkZjYSoPm6Ifd0zBwYm8MEKfW8EggZbOhp/7M2n537sCmgt+NBdXyiSh7ac nVg+WInShACQygT+fCQYlmxe/blylLO/9gZkSURSBULrET0L0I264rZ6jQPVnWjZ7qcO eRXcqloMgDKLgCMsSFWqaHyHnh9iQp4hf0fPLWEysE6pkKLR/Wc2h5Tsphxth3s7H32/ 8d7upo29RQfEk3Li2JWGMDUFPK/nuTrqZ4VKQBEVOoxqIxlekxO6gkYTUy4+7n0tGoQi H9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=4nD9zNdM7kgb2PjNuLkoYc6/N8OHxr/FhtQhsnaNCHAbjCraA7FcgWCQGmMjXCLSOq 5OCUqZ3vDKsDkLNxctv3R45IQROHt8f5AuAC932utG+JYjTUUyju+lCtm1bHEl3HAOSd tD/w5avygR1XtBmleqatxElqCj58nGEtf78dVbbUXoZDJc1ACvrybQC2lRCJEYRZ9lLn NaGapBX4LjSoAWJpkv+594JB60Af+M4GYvTa9Lq58Y518zpAgPNIck5J/QzpL03DfIs3 MVCND9boCO9cldXLei14yVsPmpABkT9jAbxvJOBc8dD+mrnyemvWgbKZcN3g7AwNxj+w 8NKQ== X-Gm-Message-State: AOAM531T5ivciHM04L+fBuMFjZEu1CFBd+P/yLkyHdYu/8rLLCWFv/Xk mvb2YVeIxXt2T25n2UQfDDYdGoLW9zlxVSC+GS6A4A== X-Google-Smtp-Source: ABdhPJwFN5Fdjz70SrDy11N5VCDZyj5xhzGfdjsLgg+5DDgCd8lOElEQAznjGeYKxpSKIfJZw74EpUQ29Ud03jgE/Gc= X-Received: by 2002:a5b:691:0:b0:64d:ab44:f12e with SMTP id j17-20020a5b0691000000b0064dab44f12emr24771949ybq.533.1653377123012; Tue, 24 May 2022 00:25:23 -0700 (PDT) MIME-Version: 1.0 References: <20220523140205.48625-1-linmq006@gmail.com> In-Reply-To: <20220523140205.48625-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 24 May 2022 09:25:11 +0200 Message-ID: Subject: Re: [PATCH] mtd: maps: Fix refcount leak in of_flash_probe_versatile To: Miaoqian Lin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2022 at 4:02 PM Miaoqian Lin wrote: > of_find_matching_node_and_match() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1748FC433F5 for ; Tue, 24 May 2022 07:25:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=THdCpPOFgxvstw6/f3MKbyF60diYggt1D6RFoTh3K14=; b=l+VtExLLtgdGFG sfLoh43wTjHPSqKXeWG0IjR0IA6eVMl003mLsAIlHXupARySUwS1OJFnN7XKA0A3kcZl8abtX58Dy ey42QVfesQRlyYOM1+vtSd6pG8w3oHChHb/SWVxtvTYe64rD76Pv3JOACTjZDibw2Sh72kxPRDN5S dOnveWxC3WxOcuZfDXIabnpR7gaHR9YbsYGmdSL08PkaPyYhnnznnmkAD3okupZyzY503IVwLJD4a OVDlC96LydFm3aTe88VmuppQWeI0ct8hK0bmrM+tSessfNTe0tyCAUBOxL/eAeutMOQqo1pa64Wym ZFdg8pTBPKDFUeGuMAVA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOvA-0074Jq-DU; Tue, 24 May 2022 07:25:36 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOuz-0074HL-0K for linux-mtd@lists.infradead.org; Tue, 24 May 2022 07:25:26 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id t26so29384108ybt.3 for ; Tue, 24 May 2022 00:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=wPGM+6wvYQzYXBkWVp8pdxQXBtD/ig4S7bFkR4MsUl8/n209nSMc2p6HwXgKOnXj+D ThJnMq7NlzkZjYSoPm6Ifd0zBwYm8MEKfW8EggZbOhp/7M2n537sCmgt+NBdXyiSh7ac nVg+WInShACQygT+fCQYlmxe/blylLO/9gZkSURSBULrET0L0I264rZ6jQPVnWjZ7qcO eRXcqloMgDKLgCMsSFWqaHyHnh9iQp4hf0fPLWEysE6pkKLR/Wc2h5Tsphxth3s7H32/ 8d7upo29RQfEk3Li2JWGMDUFPK/nuTrqZ4VKQBEVOoxqIxlekxO6gkYTUy4+7n0tGoQi H9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=Zm2x4n5xdH4mHmR6x4zuM9zqkDr1NS+MqcFbwdmXdTm5afkMxJTrhCEO6TTtaN02dc xHzEXsEq0BwW7ormS1pSHYxLY51LNPZmR2uEs1sH6u6rvQ0z52mCf5n/wscz0JzLFF+4 fEMWHo9rf95CFGybniIgOg5dJZrqUYiEC+g36GRKEvrCMV8qvD42oVIlVk0qrRq0mptP p91hSfOVvzA25AVYkHH6oUyz/qlktS5HuUQHelMiM3tafUcucdrCc6VALrJKiexoCcnI XYUMJ0tkPzSNLHe3arxwPHEimwshfqTXDUmAMr69m4i1Ps/UyIz96heAqOAzaWk1S4D+ GAHw== X-Gm-Message-State: AOAM531Ik0SPJwb5ecoyC24Nth+N+l238E/u/90nTy6I1Rqi4IQE06mu DrN80JoHaNzvw1IEQzu3/G5bLzTMbftN6ZrlrT/qOA== X-Google-Smtp-Source: ABdhPJwFN5Fdjz70SrDy11N5VCDZyj5xhzGfdjsLgg+5DDgCd8lOElEQAznjGeYKxpSKIfJZw74EpUQ29Ud03jgE/Gc= X-Received: by 2002:a5b:691:0:b0:64d:ab44:f12e with SMTP id j17-20020a5b0691000000b0064dab44f12emr24771949ybq.533.1653377123012; Tue, 24 May 2022 00:25:23 -0700 (PDT) MIME-Version: 1.0 References: <20220523140205.48625-1-linmq006@gmail.com> In-Reply-To: <20220523140205.48625-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 24 May 2022 09:25:11 +0200 Message-ID: Subject: Re: [PATCH] mtd: maps: Fix refcount leak in of_flash_probe_versatile To: Miaoqian Lin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_002525_110647_3013FF68 X-CRM114-Status: GOOD ( 10.27 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org On Mon, May 23, 2022 at 4:02 PM Miaoqian Lin wrote: > of_find_matching_node_and_match() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij ______________________________________________________ Linux MTD discussion mailing list http://lists.infradead.org/mailman/listinfo/linux-mtd/ From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8D534C433F5 for ; Tue, 24 May 2022 07:26:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=8SWyMOMiWUkWC+LTaoyunKXN1Ba8OG+mnpBym/JAyus=; b=LMvDpavBPcuBXH 5LPoODXwhU3hyKn/ehrwU3IJEguMcWakjxC4b/sM2ineRawm+kFYwjz4rIcB1vljkyDZ/Py6zRtvB toYQNmJxNGYwFJ91iqAunNBuhGP3yYjxPeyvd8/JKLStju0HnmYrOirRVe2gdcBp1Ft/rjcDrxTco 8GjpCRxTA2MEwEqYNv+ry44YKeOKNCYO0X/Dq3n8OUxn+Z5afmcpsqze40r6Iht+m7nLTUWw1rvzb 2XPswVItCzXzLmWt2Khkadtelz9uJQSXCUBTYCzZ14Yc/cybzye7K9WkeSPjnz1dUGaRHCJbVKWux 5UXS6ltKx89KeR25zbtw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOv2-0074IO-Bi; Tue, 24 May 2022 07:25:28 +0000 Received: from mail-yb1-xb2a.google.com ([2607:f8b0:4864:20::b2a]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1ntOuz-0074HK-0K for linux-arm-kernel@lists.infradead.org; Tue, 24 May 2022 07:25:26 +0000 Received: by mail-yb1-xb2a.google.com with SMTP id o80so29434799ybg.1 for ; Tue, 24 May 2022 00:25:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=wPGM+6wvYQzYXBkWVp8pdxQXBtD/ig4S7bFkR4MsUl8/n209nSMc2p6HwXgKOnXj+D ThJnMq7NlzkZjYSoPm6Ifd0zBwYm8MEKfW8EggZbOhp/7M2n537sCmgt+NBdXyiSh7ac nVg+WInShACQygT+fCQYlmxe/blylLO/9gZkSURSBULrET0L0I264rZ6jQPVnWjZ7qcO eRXcqloMgDKLgCMsSFWqaHyHnh9iQp4hf0fPLWEysE6pkKLR/Wc2h5Tsphxth3s7H32/ 8d7upo29RQfEk3Li2JWGMDUFPK/nuTrqZ4VKQBEVOoxqIxlekxO6gkYTUy4+7n0tGoQi H9Qg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xZCIrkeqp0UwfkI67/iqYr1O2x3qcCrd77cFyqemvpY=; b=8GwUxpuup7nuZq0OcAFzh7n6SHYOn1vCriLW1YcOOutkByOYsiGK+/pc+kExhX07UX m99FEqCUa42NrvXjq40ArlHUdfIQR78+Ge0VuGjty6Ac1JHuWtBrJWU83QPwHlHb4El9 0T3zArBfVylEyzbh430n8kBLGIOkYAZaHnZZZvVZNiaU4Wpulkow/RfOGek7konbDnMC DuRSMSXIBkw2lVtFiZ8gbTX8XgPjylZDuuhOD23HCUkqMXjN3nINB5mafoLb8Q3uuzfr wPk3HZmiq8pS2fmN7+PAp5vNL8fiMa9M4XojyN38phrdyw5VoNi443o5RFqcDUQu6+zE iWqw== X-Gm-Message-State: AOAM530X8DVBn7ba2vWF3SUIGCcGd7WY+TQOMArVPlNUJr1ax4DdB3Sy anzmtiYPX1LvMx0tolU8mFMMyRg4IvM49OZeKSnkrw== X-Google-Smtp-Source: ABdhPJwFN5Fdjz70SrDy11N5VCDZyj5xhzGfdjsLgg+5DDgCd8lOElEQAznjGeYKxpSKIfJZw74EpUQ29Ud03jgE/Gc= X-Received: by 2002:a5b:691:0:b0:64d:ab44:f12e with SMTP id j17-20020a5b0691000000b0064dab44f12emr24771949ybq.533.1653377123012; Tue, 24 May 2022 00:25:23 -0700 (PDT) MIME-Version: 1.0 References: <20220523140205.48625-1-linmq006@gmail.com> In-Reply-To: <20220523140205.48625-1-linmq006@gmail.com> From: Linus Walleij Date: Tue, 24 May 2022 09:25:11 +0200 Message-ID: Subject: Re: [PATCH] mtd: maps: Fix refcount leak in of_flash_probe_versatile To: Miaoqian Lin Cc: Miquel Raynal , Richard Weinberger , Vignesh Raghavendra , linux-arm-kernel@lists.infradead.org, linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220524_002525_110580_BB9D2F8A X-CRM114-Status: GOOD ( 11.02 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, May 23, 2022 at 4:02 PM Miaoqian Lin wrote: > of_find_matching_node_and_match() returns a node pointer with refcount > incremented, we should use of_node_put() on it when not need anymore. > Add missing of_node_put() to avoid refcount leak. > > Fixes: b0afd44bc192 ("mtd: physmap_of: add a hook for Versatile write protection") > Signed-off-by: Miaoqian Lin Reviewed-by: Linus Walleij Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel