From: Linus Walleij <linus.walleij@linaro.org>
To: Jagan Teki <jagan@amarulasolutions.com>
Cc: Chun-Kuang Hu <chunkuang.hu@kernel.org>,
dri-devel@lists.freedesktop.org,
Neil Armstrong <narmstrong@baylibre.com>,
Robert Foss <robert.foss@linaro.org>,
Yannick Fertre <yannick.fertre@foss.st.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Michael Nazzareno Trimarchi <michael@amarulasolutions.com>,
Sam Ravnborg <sam@ravnborg.org>,
linux-stm32@st-md-mailman.stormreply.com,
linux-amarula@amarulasolutions.com
Subject: Re: [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge
Date: Sat, 11 Dec 2021 01:35:32 +0100 [thread overview]
Message-ID: <CACRpkda=yAk9kQ20ey+am7xjuVDvgDcup6B5vxb3WeuzMiy+kQ@mail.gmail.com> (raw)
In-Reply-To: <CACRpkdb4JGCNyjncqgh8=3wWi4BRCqGNuLyTBRzLiVLK38UzqA@mail.gmail.com>
On Sat, Dec 11, 2021 at 1:07 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Fri, Dec 10, 2021 at 6:49 PM Jagan Teki <jagan@amarulasolutions.com> wrote:
> > - dev_info(dev, "connected to panel\n");
> > - d->panel = panel;
>
> How does this assignment happen after your patch?
> I'm using that...
>
> devm_drm_of_get_bridge() needs some more argument right?
Actually it is only used in unbind right below:
if (d->panel)
drm_panel_bridge_remove(d->bridge_out);
If it is not needed at all after your patch (because devm removes
the bridge) then also delete this code, and delete the
struct drm_panel *panel from struct mcde_dsi at the top
and possibly also drop the header #include <drm/drm_panel.h>
entirely.
Yours,
Linus Walleij
next prev parent reply other threads:[~2021-12-11 0:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-10 17:48 [PATCH 1/3] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi Jagan Teki
2021-12-10 17:48 ` [PATCH 2/3] Revert "drm/bridge: dw-mipi-dsi: Find the possible DSI devices" Jagan Teki
2021-12-10 17:48 ` [PATCH 3/3] drm: bridge: Switch to devm_drm_of_get_bridge Jagan Teki
2021-12-11 0:07 ` Linus Walleij
2021-12-11 0:35 ` Linus Walleij [this message]
2021-12-11 6:29 ` Jagan Teki
2022-02-24 9:27 ` Jagan Teki
2021-12-10 18:13 ` [PATCH 1/3] drm: bridge: nwl-dsi: Drop panel_bridge from nwl_dsi Guido Günther
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACRpkda=yAk9kQ20ey+am7xjuVDvgDcup6B5vxb3WeuzMiy+kQ@mail.gmail.com' \
--to=linus.walleij@linaro.org \
--cc=andrzej.hajda@intel.com \
--cc=chunkuang.hu@kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jagan@amarulasolutions.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-amarula@amarulasolutions.com \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=michael@amarulasolutions.com \
--cc=narmstrong@baylibre.com \
--cc=robert.foss@linaro.org \
--cc=sam@ravnborg.org \
--cc=yannick.fertre@foss.st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.