From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.9 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3C235CA9EC3 for ; Tue, 29 Oct 2019 14:58:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 125A520874 for ; Tue, 29 Oct 2019 14:58:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oaXpskJC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389820AbfJ2O6b (ORCPT ); Tue, 29 Oct 2019 10:58:31 -0400 Received: from mail-vs1-f65.google.com ([209.85.217.65]:38520 "EHLO mail-vs1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389800AbfJ2O6b (ORCPT ); Tue, 29 Oct 2019 10:58:31 -0400 Received: by mail-vs1-f65.google.com with SMTP id b123so8926841vsb.5 for ; Tue, 29 Oct 2019 07:58:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=oaXpskJCNt4XXGtwMjTYcVHqnsYcgfy+b60L4FecmVgfx2bvqI3yhshilu7EhsJGED HVdSB0Mv5TcTKihKo/g4eEfeVwotJc2pI/ADqKHZEUoEExQ8N64ZUrSpvrgw7sbAwcUo G8C1XTdibyo5hC2gTMCccdjPP6Z7mxoeFR5bZbqRMZsoVWGGmDx8HQchm2K6hW0QYpRv HRjGUXBFVueW3Q+RJJFP0NnoifQLM3IFNuHcGmbETxhTmNvuBTS6uCiEZGdBLtOEo9uU 6qxbkxwqypztHkWqNz0CPNUGK4ythXELpQL7YDWxZ7XSIYBgmIgmz8a8hl717594vq9q f0Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=hCX/8yIG+LKOzy166E6ruxiZLq3jPeWum3t0FJ51s2rJVNgVfObav49LJSD+lagbvR s7yAfKI9UqdtpyK86c7kqmhg8HM//xrvdIxqn90fiZAX3CD4odTs6sXcTz3mQSmvWU1l CdAG3Iccf1WomaLCZcub+t0wjBquG8RFk3SMCCqS265PyCdESK7bam7QYyRhElmQqpRI GZePUar3zdxtoifGcIPDIIbpUHDsXPCqqCwogu8UhYV3pNi8WWa6YJ8MmzyW99LZHmRU HL+r3btiGdpghVQEAKgQjDGl0mTZHMVzIsh5nfqhkcMcP/dZvHgZRDXdtrf0ZOLk775m tprw== X-Gm-Message-State: APjAAAUt7fsPcO5q7hyqlAhrZ/gNdrEHj/oKsupAUm9FnSB/nOr13Q83 Z9wzxmy3ToICBTiRR/29XootESfNCeydlFv+kIePcg== X-Google-Smtp-Source: APXvYqzaI791KOXBIBsCJiL8FxnvMrHuQCjh4l15hmm8Lf0ZRw6g5PMTkXCt8PXFzSZIcrNtpyFpJt2Gtasg9XBc6NE= X-Received: by 2002:a67:7944:: with SMTP id u65mr2109606vsc.10.1572361109404; Tue, 29 Oct 2019 07:58:29 -0700 (PDT) MIME-Version: 1.0 References: <20191024202703.8017-1-chris.packham@alliedtelesis.co.nz> <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> From: Linus Walleij Date: Tue, 29 Oct 2019 15:58:17 +0100 Message-ID: Subject: Re: [PATCH v4 2/2] gpio: Add xgs-iproc driver To: Chris Packham Cc: Bartosz Golaszewski , Rob Herring , Mark Rutland , Ray Jui , Scott Branden , bcm-kernel-feedback-list , "open list:GPIO SUBSYSTEM" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Linux ARM , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-gpio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Oct 24, 2019 at 10:27 PM Chris Packham wrote: > This driver supports the Chip Common A GPIO controller present on a > number of Broadcom switch ASICs with integrated SoCs. The controller is > similar to the pinctrl-nsp-gpio and pinctrl-iproc-gpio blocks but > different enough that a separate driver is required. > > This has been ported from Broadcom's XLDK 5.0.3 retaining only the CCA > support (pinctrl-iproc-gpio covers CCB). > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v4: > - rename the config option to GPIO_BCM_XGS_IPROC and place alphabetically > - sort #includes alphabetically Patch applied, great work on this patch, it's very lean and clean now! Got a minor thing I wanna look at, will send a patch on top if I find it useful. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A759ECA9EAE for ; Tue, 29 Oct 2019 14:58:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 77F1F20874 for ; Tue, 29 Oct 2019 14:58:37 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="DmT0uqh3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="oaXpskJC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 77F1F20874 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=d1UPJC5U2eiIgKhwXAIE9NBUMTdvn0R33rRm6Sf3tvE=; b=DmT0uqh3KlW4ew BufFA3qRZcK3rlgrNfF/EbHm+pbmCflPBZK1j8EPIeDHGWYt+LIUcCnjLUZw6VPvXBXJvGtyksJyv 2PuYpMGls0T3dVSSyT5AMD4JmP1iMEbdEk8/3gkMLCxPoWS+1CNyrAZ6884eaP/iZ33UbvF2HPrET b+dn4yRUUVSH6pdTbevuB0PFdUcuC1l4i6nJVDn+AwxZ0eksnKGxijzkrlW7wUEsIA6xil8y3i1qv 91nhYwzqhtuX4TjH60K0hwNJ2yt0E7KzNI5coOi75cstbNq7Ow2iRhHrZ730iZPhDwlM7l2RQg6tI No9ZECPpPvY6JkUQ9Zmw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPSx7-0006l7-K4; Tue, 29 Oct 2019 14:58:33 +0000 Received: from mail-vs1-xe41.google.com ([2607:f8b0:4864:20::e41]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iPSx4-0006k9-Ab for linux-arm-kernel@lists.infradead.org; Tue, 29 Oct 2019 14:58:31 +0000 Received: by mail-vs1-xe41.google.com with SMTP id y129so8927793vsc.6 for ; Tue, 29 Oct 2019 07:58:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=oaXpskJCNt4XXGtwMjTYcVHqnsYcgfy+b60L4FecmVgfx2bvqI3yhshilu7EhsJGED HVdSB0Mv5TcTKihKo/g4eEfeVwotJc2pI/ADqKHZEUoEExQ8N64ZUrSpvrgw7sbAwcUo G8C1XTdibyo5hC2gTMCccdjPP6Z7mxoeFR5bZbqRMZsoVWGGmDx8HQchm2K6hW0QYpRv HRjGUXBFVueW3Q+RJJFP0NnoifQLM3IFNuHcGmbETxhTmNvuBTS6uCiEZGdBLtOEo9uU 6qxbkxwqypztHkWqNz0CPNUGK4ythXELpQL7YDWxZ7XSIYBgmIgmz8a8hl717594vq9q f0Kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xjB+ZpmO3twByAPR+4L+mHm+DrtDlohe88jo1dKnnjc=; b=dPDM+9sy9nw5HFU9MwFJBDViDJilGpUmO/v+t0Ldyph/cYsb7unuzmLK9Ih5Tsoqzs /W7ab11F+kB9YOamWHPDmNJ01Y2C5En0A2GfNnDWc89yFCK7w2p1PcWSxyeH2STnZn7p Ms9Ou8TG5Zf+00Z76+lf/2ZsgFEbSG8d5eM2qiB797lYs/9EqzrWlgPMu5BOyjGkEeR1 +2RaZbVarNFH+vyd0uo6fNJg+bCnv0x7e5VfSn2XbLVIlQ/DlLAsqfz2gJ46ZTxOEpFi X2mIVqwSPj+mb9THt8eM4gnnDs7DbTvzREAQNONhHvSsUIYtyT4o9AWUgAi1KIsEH8G3 2p6A== X-Gm-Message-State: APjAAAVqKVJL4D/75fyinSMHIy3a5vC/iTmIVWhwGCpi1xsmhb+2/FDi wMfgFqPdfBIm+ItM7CudgaAkGv8C9t0LZtbphEr8fw== X-Google-Smtp-Source: APXvYqzaI791KOXBIBsCJiL8FxnvMrHuQCjh4l15hmm8Lf0ZRw6g5PMTkXCt8PXFzSZIcrNtpyFpJt2Gtasg9XBc6NE= X-Received: by 2002:a67:7944:: with SMTP id u65mr2109606vsc.10.1572361109404; Tue, 29 Oct 2019 07:58:29 -0700 (PDT) MIME-Version: 1.0 References: <20191024202703.8017-1-chris.packham@alliedtelesis.co.nz> <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> In-Reply-To: <20191024202703.8017-3-chris.packham@alliedtelesis.co.nz> From: Linus Walleij Date: Tue, 29 Oct 2019 15:58:17 +0100 Message-ID: Subject: Re: [PATCH v4 2/2] gpio: Add xgs-iproc driver To: Chris Packham X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191029_075830_373939_F97FD54C X-CRM114-Status: GOOD ( 15.29 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Scott Branden , "open list:GPIO SUBSYSTEM" , Ray Jui , "linux-kernel@vger.kernel.org" , Bartosz Golaszewski , Rob Herring , bcm-kernel-feedback-list , Linux ARM Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 24, 2019 at 10:27 PM Chris Packham wrote: > This driver supports the Chip Common A GPIO controller present on a > number of Broadcom switch ASICs with integrated SoCs. The controller is > similar to the pinctrl-nsp-gpio and pinctrl-iproc-gpio blocks but > different enough that a separate driver is required. > > This has been ported from Broadcom's XLDK 5.0.3 retaining only the CCA > support (pinctrl-iproc-gpio covers CCB). > > Signed-off-by: Chris Packham > --- > > Notes: > Changes in v4: > - rename the config option to GPIO_BCM_XGS_IPROC and place alphabetically > - sort #includes alphabetically Patch applied, great work on this patch, it's very lean and clean now! Got a minor thing I wanna look at, will send a patch on top if I find it useful. Yours, Linus Walleij _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel