Re: [PATCH] gpio: brcmstb: Do not use gc->pin2mask()

From: Linus Walleij <linus.walleij@linaro.org>
To: Gregory Fong <gregory.0xf0@gmail.com>
Cc: "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Doug Berger <opendmb@gmail.com>
Subject: Re: [PATCH] gpio: brcmstb: Do not use gc->pin2mask()
Date: Fri, 20 Oct 2017 18:39:47 +0200	[thread overview]
Message-ID: <CACRpkdaHx+=B=0xigumJieOOm99O=vuDQ-ZxFKjh7DGLxtjBtA@mail.gmail.com> (raw)
In-Reply-To: <CADtm3G71v3J9V==bAJBr-xxR2c3iWL32eh0dSg7o2v2C0oAQ2w@mail.gmail.com>

On Fri, Oct 20, 2017 at 5:51 PM, Gregory Fong <gregory.0xf0@gmail.com> wrote:
> Hi Linus,
>
> On Fri, Oct 20, 2017 at 6:48 AM, Linus Walleij <linus.walleij@linaro.org> wrote:
>> The pin2mask() accessor only shuffles BIT ORDER in big endian systems,
>> i.e. the bitstuffing is swizzled big endian so "bit 0" is bit 7 or
>> bit 15 or bit 31 or so.
>>
>> The brcmstb only uses big endian BYTE ORDER which will be taken car of
>> by the ->write_reg() callback.
>>
>> Just use BIT(offset) to assign the bit.
>
> I believe the patches that Doug is putting together already take care
> of this, would you be OK with it being handled in there instead?

I would prefer that those changes base on top of this instead.

I need to get rid of ->pin2mask() for other GPIO improvements in
the core, like supporting .get_multiple() in gpio-mmio.

I can apply this to the devel branch per immediately so Doug can base
his work on top of it.

Yours,
Linus Walleij