From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9439C433F5 for ; Mon, 23 May 2022 12:55:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235748AbiEWMzX (ORCPT ); Mon, 23 May 2022 08:55:23 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55808 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235806AbiEWMzN (ORCPT ); Mon, 23 May 2022 08:55:13 -0400 Received: from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com [IPv6:2607:f8b0:4864:20::112d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 606E65372B for ; Mon, 23 May 2022 05:55:11 -0700 (PDT) Received: by mail-yw1-x112d.google.com with SMTP id 00721157ae682-2ff53d86abbso127623207b3.8 for ; Mon, 23 May 2022 05:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eDfy6GqpIfaV2D3gJJczHKjLm3vz3xNZVsVwjBEGHAk=; b=XIWqezSV7/NwqmML1vVCi0to8RMc5lNXcUXL3XQPhELyW8dZA2LQAyULwEy2suR0zv 4uTa57OMPSrjxlJqoLkarNGhJ1s2VlBJHr5Uohuh1UK6t+KvLBJSqGqaCgIGBe6X6HX8 7EHOYuIukYNOkAEzGhpUyQKgCZKhz5RSMLdOGlJ9aY51zDwLPbPeL+Vy6nmgi+bRbXQw 3kebQnfjJFdKtMuPHRc7tdKjjPxjL0mvrk9LkQwzKO1nlGQTAJZ0dZ3dc7/K6MeXf6qy uJuqKW2ViFJu/C7jbivSInZuS+x4nvyloC8O9pwsFF9ffZlwoceQ9Trju2vJlwI1h+4O kcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eDfy6GqpIfaV2D3gJJczHKjLm3vz3xNZVsVwjBEGHAk=; b=PqOVdgEGOLxhsZCZsq4tPkf72U6x6qRicyzrNfGKH95ip26Ga5vNLQkKqKFmXaH4ap uOdWkvSymdAq8gFf4WNAktWbC1+Ds5t7cm9jkjK/ReSdjmkFNk6XAVLmBcflx+K/jURV z2tODy0hvOSzJLg3Z1OeQaclUjA9gzlZIVEXKOXzG51wEl7+5VTr4pXS8zYFtZWHX17D c2pFDNEnAJHBzUZ0uxBFxhuNEFJsVo537M3F2eP7HGlbSK+lXAw2/IODjKwf5VJf7rAc uW2LINpAgc1MqctvZihtk+bW2gfraWKZeX6irrOmIw/jB1GbwO/X4OAy5t1W+JEbtDvn 2Bfw== X-Gm-Message-State: AOAM532hx/ve86L+VmtXU6rwRUv6vWhhZJnXy1LPWOZWWGzM3qOK4lU5 kBr1+4OWP8o5yKkMjg9qiReRiZ9Hj8wEiixwloO/9Q== X-Google-Smtp-Source: ABdhPJzy078pPsAixd7aoHZE4fZKF4ic8N0z/2T9Yw3r8eUBViOKz7NYD0OqMiHkS7D5dBNqQ6QLB2GiEpY/njCXIlo= X-Received: by 2002:a81:c07:0:b0:2ff:8a7b:f37c with SMTP id 7-20020a810c07000000b002ff8a7bf37cmr15476962ywm.118.1653310510641; Mon, 23 May 2022 05:55:10 -0700 (PDT) MIME-Version: 1.0 References: <20220506123246.21788-1-yuehaibing@huawei.com> In-Reply-To: From: Linus Walleij Date: Mon, 23 May 2022 14:54:59 +0200 Message-ID: Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF To: YueHaibing Cc: airlied@linux.ie, daniel@ffwll.ch, tzimmermann@suse.de, dmitry.baryshkov@linaro.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, May 23, 2022 at 2:46 PM Linus Walleij wr= ote: > On Fri, May 6, 2022 at 2:33 PM YueHaibing wrote: > > > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > Depends on [n]: HAS_IOMEM [=3Dy] && DRM [=3Dy] && OF [=3Dn] > > Selected by [y]: > > - DRM_MSM [=3Dy] && HAS_IOMEM [=3Dy] && DRM [=3Dy] && (ARCH_QCOM || S= OC_IMX5 || COMPILE_TEST [=3Dy]) && COMMON_CLK [=3Dy] && IOMMU_SUPPORT [=3Dy= ] && (QCOM_OCMEM [=3Dn] || QCOM_OCMEM [=3Dn]=3Dn) && (QCOM_LLCC [=3Dy] || Q= COM_LLCC [=3Dy]=3Dn) && (QCOM_COMMAND_DB [=3Dn] || QCOM_COMMAND_DB [=3Dn]= =3Dn) > > > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus su= pport") > > Signed-off-by: YueHaibing > > Patch applied to the DRM tree. Nope, failed: $ dim push-branch drm-misc-next dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): Fixes: SHA1 in not pointing at an ancestor: dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus supp= ort") dim: ERROR: issues in commits detected, aborting I don't know what to do with this, sorry. The other committers are maybe be= tter with this kind of situations. I think it is designed to stop me from shooting myself in the foot. Yours, Linus Walleij From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3CA4DC433EF for ; Mon, 23 May 2022 12:55:14 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5A1C910F4D5; Mon, 23 May 2022 12:55:13 +0000 (UTC) Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by gabe.freedesktop.org (Postfix) with ESMTPS id 77EAF10F4D5 for ; Mon, 23 May 2022 12:55:11 +0000 (UTC) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-30007f11f88so15175647b3.7 for ; Mon, 23 May 2022 05:55:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=eDfy6GqpIfaV2D3gJJczHKjLm3vz3xNZVsVwjBEGHAk=; b=XIWqezSV7/NwqmML1vVCi0to8RMc5lNXcUXL3XQPhELyW8dZA2LQAyULwEy2suR0zv 4uTa57OMPSrjxlJqoLkarNGhJ1s2VlBJHr5Uohuh1UK6t+KvLBJSqGqaCgIGBe6X6HX8 7EHOYuIukYNOkAEzGhpUyQKgCZKhz5RSMLdOGlJ9aY51zDwLPbPeL+Vy6nmgi+bRbXQw 3kebQnfjJFdKtMuPHRc7tdKjjPxjL0mvrk9LkQwzKO1nlGQTAJZ0dZ3dc7/K6MeXf6qy uJuqKW2ViFJu/C7jbivSInZuS+x4nvyloC8O9pwsFF9ffZlwoceQ9Trju2vJlwI1h+4O kcyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=eDfy6GqpIfaV2D3gJJczHKjLm3vz3xNZVsVwjBEGHAk=; b=YA6n0dz9nPFwwV793vRGXZTUQiFXrLVcT5dIUfMJpHS+TDUAkb8mMhyEMrVAZkrrsn Ogv5Nt/+5oXxpfYHJv9t59aYZF0K6QLftuWQRyHKU0BxzMy+nIai8AAVr0gS34G9DOId WHFBe6k680EFXnOzjJIXZcHH6Q7xGgFSaZ9bWHSu3OHMlZ5GsckZJxcddDjGJNDCT+pC oUJJSVl7TyaqxMakPSOwkrcsydwD0qtQUGbPS8u/Le7o4RrcIqSipEDVBdE2i6qRiPsJ scI6Y8ArfW4BZaKUkCZmWRijux07CjqG4oI7z+ST6uEcdI31rXuEefYdfKXytHILHasK azhw== X-Gm-Message-State: AOAM533rPP8Ec53hW1TdvZ+07vt2oDOuMBmKDPIHfLrUjaw1asYwuPE7 lcTid/CRLNx3txZM73m0Bp51nWPOVhPsNYAt0faJgw== X-Google-Smtp-Source: ABdhPJzy078pPsAixd7aoHZE4fZKF4ic8N0z/2T9Yw3r8eUBViOKz7NYD0OqMiHkS7D5dBNqQ6QLB2GiEpY/njCXIlo= X-Received: by 2002:a81:c07:0:b0:2ff:8a7b:f37c with SMTP id 7-20020a810c07000000b002ff8a7bf37cmr15476962ywm.118.1653310510641; Mon, 23 May 2022 05:55:10 -0700 (PDT) MIME-Version: 1.0 References: <20220506123246.21788-1-yuehaibing@huawei.com> In-Reply-To: From: Linus Walleij Date: Mon, 23 May 2022 14:54:59 +0200 Message-ID: Subject: Re: [PATCH v2 -next] drm/display: Fix build error without CONFIG_OF To: YueHaibing Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: airlied@linux.ie, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, tzimmermann@suse.de, dmitry.baryshkov@linaro.org Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Mon, May 23, 2022 at 2:46 PM Linus Walleij wr= ote: > On Fri, May 6, 2022 at 2:33 PM YueHaibing wrote: > > > While CONFIG_OF is n but COMPILE_TEST is y, we got this: > > > > WARNING: unmet direct dependencies detected for DRM_DP_AUX_BUS > > Depends on [n]: HAS_IOMEM [=3Dy] && DRM [=3Dy] && OF [=3Dn] > > Selected by [y]: > > - DRM_MSM [=3Dy] && HAS_IOMEM [=3Dy] && DRM [=3Dy] && (ARCH_QCOM || S= OC_IMX5 || COMPILE_TEST [=3Dy]) && COMMON_CLK [=3Dy] && IOMMU_SUPPORT [=3Dy= ] && (QCOM_OCMEM [=3Dn] || QCOM_OCMEM [=3Dn]=3Dn) && (QCOM_LLCC [=3Dy] || Q= COM_LLCC [=3Dy]=3Dn) && (QCOM_COMMAND_DB [=3Dn] || QCOM_COMMAND_DB [=3Dn]= =3Dn) > > > > Make DRM_DP_AUX_BUS depends on OF || COMPILE_TEST to fix this warning. > > > > Fixes: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus su= pport") > > Signed-off-by: YueHaibing > > Patch applied to the DRM tree. Nope, failed: $ dim push-branch drm-misc-next dim: ac890b9eeb9b ("drm/display: Fix build error without CONFIG_OF"): Fixes: SHA1 in not pointing at an ancestor: dim: f5d01644921b ("drm/msm: select DRM_DP_AUX_BUS for the AUX bus supp= ort") dim: ERROR: issues in commits detected, aborting I don't know what to do with this, sorry. The other committers are maybe be= tter with this kind of situations. I think it is designed to stop me from shooting myself in the foot. Yours, Linus Walleij