All of lore.kernel.org
 help / color / mirror / Atom feed
From: Linus Walleij <linus.walleij@linaro.org>
To: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
	"open list:GPIO SUBSYSTEM" <linux-gpio@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Marek Vasut <marex@denx.de>,
	Paul Kocialkowski <paul.kocialkowski@bootlin.com>
Subject: Re: [PATCH 1/2] gpio: pca953x: reduce indentation level in pca953x_irq_setup()
Date: Mon, 21 Jan 2019 14:05:13 +0100	[thread overview]
Message-ID: <CACRpkdaN=kjgP7wgcOTfxuu_BM_ggADhKtesf4qEhx3aNhS4_Q@mail.gmail.com> (raw)
In-Reply-To: <20190116093158.2850-1-thomas.petazzoni@bootlin.com>

On Wed, Jan 16, 2019 at 10:32 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:

> The current design of pca953x_irq_setup() is:
>
>  if (all conditions to support IRQ are met) {
>    lots of code to support IRQs, which goes to a serious indentation
>    level.
>  }
>
>  return 0;
>
> It makes more sense to handle this like this:
>
>  if (!all conditions to support IRQ are met)
>    return 0;
>
>  handle IRQ support
>
> This commit does just this change, reducing by one tab the indentation
> level of the IRQ setup code. Thanks to this reduced indentation level,
> we are less restricted by the 80-column limit, and we can have more
> function arguments on the same line.
>
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>

Patch applied.

Yours,
Linus Walleij

      parent reply	other threads:[~2019-01-21 13:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16  9:31 [PATCH 1/2] gpio: pca953x: reduce indentation level in pca953x_irq_setup() Thomas Petazzoni
2019-01-16  9:31 ` [PATCH 2/2] gpio: pca953x: use a per instance irq_chip structure Thomas Petazzoni
2019-01-21 13:06   ` Linus Walleij
2019-01-21 13:05 ` Linus Walleij [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACRpkdaN=kjgP7wgcOTfxuu_BM_ggADhKtesf4qEhx3aNhS4_Q@mail.gmail.com' \
    --to=linus.walleij@linaro.org \
    --cc=bgolaszewski@baylibre.com \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marex@denx.de \
    --cc=paul.kocialkowski@bootlin.com \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.