From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <stable-owner@vger.kernel.org>
Received: from mail-it0-f67.google.com ([209.85.214.67]:52285 "EHLO
        mail-it0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1726087AbeIDRHh (ORCPT
        <rfc822;stable@vger.kernel.org>); Tue, 4 Sep 2018 13:07:37 -0400
Received: by mail-it0-f67.google.com with SMTP id h3-v6so4714077ita.2
        for <stable@vger.kernel.org>; Tue, 04 Sep 2018 05:42:38 -0700 (PDT)
MIME-Version: 1.0
References: <20180904091438.3755-1-boris.brezillon@bootlin.com>
In-Reply-To: <20180904091438.3755-1-boris.brezillon@bootlin.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 4 Sep 2018 14:42:26 +0200
Message-ID: <CACRpkdaORSM73HaGz=2j4vvRkZxZCfo_GoTFRy4jk9SLMdMVaQ@mail.gmail.com>
Subject: Re: [PATCH] mtd: rawnand: fsmc: Fix Hamming ECC
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: Richard Weinberger <richard@nod.at>,
        =?UTF-8?Q?Miqu=C3=A8l_Raynal?= <miquel.raynal@bootlin.com>,
        linux-mtd@lists.infradead.org,
        David Woodhouse <dwmw2@infradead.org>,
        Brian Norris <computersforpeace@gmail.com>,
        Mark Vasut <marek.vasut@gmail.com>,
        stable <stable@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Sender: stable-owner@vger.kernel.org
List-ID: <stable.vger.kernel.org>

On Tue, Sep 4, 2018 at 11:14 AM Boris Brezillon
<boris.brezillon@bootlin.com> wrote:

> Apparently ECC bytes are not ordered as expected by nand_correct_data()
> in the ecc_calc buffer which leads to invalid bitflip correction when
> an ECC error is detected (can be reproduced with 'nandbiterrs -i').
>
> Re-ordering ECC bytes seems to fix the problem.
>
> While at it, get rid of the useless u8 cast.
>
> Fixes: 6c009ab89a21 ("mtd: generic FSMC NAND MTD driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij