From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 706E9C433FE for ; Sun, 2 Jan 2022 06:03:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231620AbiABGD3 (ORCPT ); Sun, 2 Jan 2022 01:03:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41664 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230405AbiABGD2 (ORCPT ); Sun, 2 Jan 2022 01:03:28 -0500 Received: from mail-lf1-x136.google.com (mail-lf1-x136.google.com [IPv6:2a00:1450:4864:20::136]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4D24CC061574 for ; Sat, 1 Jan 2022 22:03:28 -0800 (PST) Received: by mail-lf1-x136.google.com with SMTP id h2so57931439lfv.9 for ; Sat, 01 Jan 2022 22:03:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=eOSEt2UYspkO7KlpH0taqWCjFFVAh5LxlRawNiLoSCA=; b=tGCb3hDZ09NPFPr6FT12MbJtVURDBtkxRXV2FAUpIK+IdsXRbxxLlxD5RF8xeHOlEc rdmSfOvohYAfAqnQntjwxXcMrg8fpekXTKeiEFtU+MjoWUpWzrz6GxsLS2PcAK2OmQEy YumzH+DZG7mHqw7l6y3F2G18Ru+zT6NqLuwsAIkADGyZ4dRhzF7YoWyMV5/9RlP8Nu+b z51JezLya73SyPTWGXQTVea/ARxo88mAjh5xPmHLM3Y+UnVUeA3Ir/OY3xosGv89OQP1 vyZohRjymVa7nmmoZKQUluLyyA9P0Wnp6d0ZturGsebk89CRpkHYtSDzYi333r+AjIv+ uUoA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=eOSEt2UYspkO7KlpH0taqWCjFFVAh5LxlRawNiLoSCA=; b=ihPJ7wnKD+FjYAzjZFVxPCKdA+pRSTXfDw8wlm9Y6A4nCgR9+BYUyX6jwZ1QQkbRlQ dFBKS6U1l5jh1TuOY4kHyTW9ad9o4U67IugDbTQ35S+HKkxADcdQWJN7moN4bB024ls5 /+YvaY2ATx7sNlnlGXl9/X+WZy55WvFXXJgyHzDfKR51w4kyu2xVQEgTStXla4i00GC0 Xs0+ozJaCNXKnKYGcApxjlr3MYh5wMOdOvWRyhlT5BRxdRajjQisK+Y5iWKK69WrGAcU Es/6kKhpw6KkPD9temvJLtcp91BTwUd5Wb7KXOtaVXA18/gjDn2i6VNJG6it0zHt3idR JJ4Q== X-Gm-Message-State: AOAM531y40gsFkIffZatbmWc4q92eFDXsFtsnki4nBvT31Mf0iwqMH/R 9CHY3nXqQnMtNtq+enpceH+ymBfJC7FuB2Y4c9wS+g== X-Google-Smtp-Source: ABdhPJyUsJK/0aqdGyEKpwuU7vg2NlhR00lEWpxX20MF2aZZkZEtuybziC46nnAcrr7lYQhYJfFsFAUfCpx4oTaGd/A= X-Received: by 2002:a05:6512:2303:: with SMTP id o3mr36790809lfu.362.1641103406623; Sat, 01 Jan 2022 22:03:26 -0800 (PST) MIME-Version: 1.0 References: <20211226153624.162281-1-marcan@marcan.st> <20211226153624.162281-22-marcan@marcan.st> In-Reply-To: <20211226153624.162281-22-marcan@marcan.st> From: Linus Walleij Date: Sun, 2 Jan 2022 07:03:14 +0100 Message-ID: Subject: Re: [PATCH 21/34] brcmfmac: chip: Only disable D11 cores; handle an arbitrary number To: Hector Martin Cc: Kalle Valo , "David S. Miller" , Jakub Kicinski , Rob Herring , "Rafael J. Wysocki" , Len Brown , Arend van Spriel , Franky Lin , Hante Meuleman , Chi-hsien Lin , Wright Feng , Chung-hsien Hsu , Sven Peter , Alyssa Rosenzweig , Mark Kettenis , =?UTF-8?B?UmFmYcWCIE1pxYJlY2tp?= , Pieter-Paul Giesberts , Hans de Goede , "John W. Linville" , "Daniel (Deognyoun) Kim" , "brian m. carlson" , linux-wireless@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, brcm80211-dev-list.pdl@broadcom.com, SHA-cyfmac-dev-list@infineon.com Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-wireless@vger.kernel.org On Sun, Dec 26, 2021 at 4:39 PM Hector Martin wrote: > At least on BCM4387, the D11 cores are held in reset on cold startup and > firmware expects to release reset itself. Just assert reset here and let > firmware deassert it. Premature deassertion results in the firmware > failing to initialize properly some of the time, with strange AXI bus > errors. > > Also, BCM4387 has 3 cores, up from 2. The logic for handling that is in > brcmf_chip_ai_resetcore(), but since we aren't using that any more, just > handle it here. > > Signed-off-by: Hector Martin Reviewed-by: Linus Walleij Yours, Linus Walleij